From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: andrew.cooper3@citrix.com, julien.grall@arm.com,
sstabellini@kernel.org, xen-devel@lists.xen.org,
ross.lagerwall@citrix.com
Subject: Re: [PATCH 2/2] xen/livepatch: Don't crash on encountering STN_UNDEF relocations
Date: Mon, 19 Jun 2017 14:30:35 -0400 [thread overview]
Message-ID: <20170619183035.GB21025@char.us.oracle.com> (raw)
In-Reply-To: <5941934102000078001007FA@prv-mh.provo.novell.com>
On Wed, Jun 14, 2017 at 12:49:21PM -0600, Jan Beulich wrote:
> >>> Andrew Cooper <andrew.cooper3@citrix.com> 06/14/17 8:34 PM >>>
> >Well - I've got a livepatch with such a relocation. It is probably a
> >livepatch build tools issue, but the question is whether Xen should ever
> >accept such a livepatch or not (irrespective of whether this exact
> >relocation is permitted within the ELF spec).
>
> Since the spec explicitly mentions that case, I think we'd better support it.
> But it wouldn't be the end of the world if we didn't, as presumably there
> aren't that many use cases for it.
OK. In that case:
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Andrew,
Do you think it would be possible to generate an test-case for this
in arch/test/livepatch?
>
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-06-19 18:30 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 20:51 [PATCH 1/2] xen/livepatch: Clean up arch relocation handling Andrew Cooper
2017-06-13 20:51 ` [PATCH 2/2] xen/livepatch: Don't crash on encountering STN_UNDEF relocations Andrew Cooper
2017-06-13 21:13 ` Andrew Cooper
2017-06-14 10:03 ` Jan Beulich
2017-06-14 10:11 ` Jan Beulich
2017-06-14 10:13 ` Andrew Cooper
2017-06-14 10:24 ` Jan Beulich
2017-06-14 14:18 ` Konrad Rzeszutek Wilk
2017-06-14 18:33 ` Andrew Cooper
2017-06-14 18:49 ` Jan Beulich
2017-06-19 18:30 ` Konrad Rzeszutek Wilk [this message]
2017-06-19 23:05 ` Andrew Cooper
2017-06-20 7:15 ` Jan Beulich
2017-06-20 13:30 ` Konrad Rzeszutek Wilk
2017-06-14 19:08 ` Konrad Rzeszutek Wilk
2017-06-21 18:13 ` [PATCH for-4.9 v2] " Andrew Cooper
2017-06-22 1:26 ` Konrad Rzeszutek Wilk
2017-06-22 15:27 ` Konrad Rzeszutek Wilk
2017-06-22 16:10 ` Konrad Rzeszutek Wilk
2017-06-22 16:33 ` Konrad Rzeszutek Wilk
2017-06-22 17:05 ` Konrad Rzeszutek Wilk
2017-06-23 9:44 ` Jan Beulich
2017-06-22 7:40 ` Jan Beulich
2017-06-22 9:49 ` Ross Lagerwall
2017-06-14 9:25 ` [PATCH 1/2] xen/livepatch: Clean up arch relocation handling Jan Beulich
2017-06-14 13:44 ` Konrad Rzeszutek Wilk
2017-06-14 14:02 ` Jan Beulich
2017-06-14 18:28 ` Andrew Cooper
2017-06-19 18:18 ` Konrad Rzeszutek Wilk
2017-06-20 7:36 ` Jan Beulich
2017-06-20 7:39 ` Andrew Cooper
2017-06-20 7:41 ` Andrew Cooper
2017-06-20 7:56 ` Jan Beulich
2017-06-20 13:36 ` Konrad Rzeszutek Wilk
2017-06-22 1:27 ` Is [PATCH for-4.9] Was:Re: " Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619183035.GB21025@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=ross.lagerwall@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).