From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH for-4.9 v2] xen/livepatch: Don't crash on encountering STN_UNDEF relocations Date: Wed, 21 Jun 2017 21:26:15 -0400 Message-ID: <20170622012615.GA8146@char.us.oracle.com> References: <1497387096-19058-2-git-send-email-andrew.cooper3@citrix.com> <1498068816-21894-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1498068816-21894-1-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Andrew Cooper Cc: Ross Lagerwall , Julien Grall , Stefano Stabellini , Jan Beulich , Xen-devel List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBKdW4gMjEsIDIwMTcgYXQgMDc6MTM6MzZQTSArMDEwMCwgQW5kcmV3IENvb3BlciB3 cm90ZToKPiBBIHN5bW5keCBvZiBTVE5fVU5ERUYgaXMgc3BlY2lhbCwgYW5kIG1lYW5zIGEgc3lt Ym9sIHZhbHVlIG9mIDAuICBXaGlsZQo+IGxlZ2l0aW1hdGUgaW4gdGhlIEVMRiBzdGFuZGFyZCwg aXRzIGV4aXN0YW5jZSBpbiBhIGxpdmVwYXRjaCBpcyBxdWVzdGlvbmFibGUKPiBhdCBiZXN0LiAg VW50aWwgYSBwbGF1c2libGUgdXNlY2FzZSBwcmVzZW50cyBpdHNlbGYsIHJlamVjdCBzdWNoIGEg cmVsb2NhdGlvbgo+IHdpdGggLUVPUE5PVFNVUFAuCj4gCj4gQWRkaXRpb25hbGx5LCBwZXJmb3Jt IGEgc2FmZXR5IGNoZWNrIG9uIGVsZi0+c3ltW3N5bW5keF0uc3ltIGJlZm9yZQo+IGRlcmVmZW5j aW5nIGl0LCB0byBhdm9pZCB0cmlwcGluZyBvdmVyIGEgTlVMTCBwb2ludGVyIHdoZW4gY2FsY3Vs YXRpbmcgdmFsLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29w ZXIzQGNpdHJpeC5jb20+CgpSZXZpZXdlZC1ieTogS29ucmFkIFJ6ZXN6dXRlayBXaWxrIDxrb25y YWQud2lsa0BvcmFjbGUuY29tPgpUZXN0ZWQtYnk6IEtvbnJhZCBSemVzenV0ZWsgV2lsayA8a29u cmFkLndpbGtAb3JhY2xlLmNvbT4gW3g4NiByaWdodCBub3csIHdpbGwgZG8KYXJtMzIgdG9tb3Jy b3ddCgpJIG5hdHVyYWxseSBoYWQgdG8gaGF2ZSAieGVuL2xpdmVwYXRjaDogQ2xlYW4gdXAgYXJj aCByZWxvY2F0aW9uIGhhbmRsaW5nIgpvbiB0b3Agb2YgdGhpcy4KCj4gLS0tCj4gQ0M6IEtvbnJh ZCBSemVzenV0ZWsgV2lsayA8a29ucmFkLndpbGtAb3JhY2xlLmNvbT4KPiBDQzogUm9zcyBMYWdl cndhbGwgPHJvc3MubGFnZXJ3YWxsQGNpdHJpeC5jb20+Cj4gQ0M6IEphbiBCZXVsaWNoIDxKQmV1 bGljaEBzdXNlLmNvbT4KPiBDQzogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJu ZWwub3JnPgo+IENDOiBKdWxpZW4gR3JhbGwgPGp1bGllbi5ncmFsbEBhcm0uY29tPgo+IAo+IHYy Ogo+ICAqIFJlamVjdCBTVE5fVU5ERUYgd2l0aCAtRU9QTk9UU1VQUAo+IC0tLQo+ICB4ZW4vYXJj aC9hcm0vYXJtMzIvbGl2ZXBhdGNoLmMgfCAxNyArKysrKysrKysrKysrKystLQo+ICB4ZW4vYXJj aC9hcm0vYXJtNjQvbGl2ZXBhdGNoLmMgfCAxNyArKysrKysrKysrKysrKystLQo+ICB4ZW4vYXJj aC94ODYvbGl2ZXBhdGNoLmMgICAgICAgfCAxNyArKysrKysrKysrKysrKystLQo+ICAzIGZpbGVz IGNoYW5nZWQsIDQ1IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL3hlbi9hcmNoL2FybS9hcm0zMi9saXZlcGF0Y2guYyBiL3hlbi9hcmNoL2FybS9hcm0zMi9s aXZlcGF0Y2guYwo+IGluZGV4IGEzMjgxNzkuLjUzZmVlOTEgMTAwNjQ0Cj4gLS0tIGEveGVuL2Fy Y2gvYXJtL2FybTMyL2xpdmVwYXRjaC5jCj4gKysrIGIveGVuL2FyY2gvYXJtL2FybTMyL2xpdmVw YXRjaC5jCj4gQEAgLTI1NCwxNCArMjU0LDI3IEBAIGludCBhcmNoX2xpdmVwYXRjaF9wZXJmb3Jt KHN0cnVjdCBsaXZlcGF0Y2hfZWxmICplbGYsCj4gICAgICAgICAgICAgIGFkZGVuZCA9IGdldF9h ZGRlbmQodHlwZSwgZGVzdCk7Cj4gICAgICAgICAgfQo+ICAKPiArICAgICAgICBpZiAoIHN5bW5k eCA9PSBTVE5fVU5ERUYgKQo+ICsgICAgICAgIHsKPiArICAgICAgICAgICAgZHByaW50ayhYRU5M T0dfRVJSLCBMSVZFUEFUQ0ggIiVzOiBFbmNvdW50ZXJlZCBTVE5fVU5ERUZcbiIsCj4gKyAgICAg ICAgICAgICAgICAgICAgZWxmLT5uYW1lKTsKPiArICAgICAgICAgICAgcmV0dXJuIC1FT1BOT1RT VVBQOwo+ICsgICAgICAgIH0KPiArCj4gICAgICAgICAgaWYgKCBzeW1uZHggPiBlbGYtPm5zeW0g KQo+ICAgICAgICAgIHsKPiAgICAgICAgICAgICAgZHByaW50ayhYRU5MT0dfRVJSLCBMSVZFUEFU Q0ggIiVzOiBSZWxhdGl2ZSBzeW1ib2wgd2FudHMgc3ltYm9sQCV1IHdoaWNoIGlzIHBhc3QgZW5k IVxuIiwKPiAgICAgICAgICAgICAgICAgICAgICBlbGYtPm5hbWUsIHN5bW5keCk7Cj4gICAgICAg ICAgICAgIHJldHVybiAtRUlOVkFMOwo+ICAgICAgICAgIH0KPiAtCj4gLSAgICAgICAgdmFsID0g ZWxmLT5zeW1bc3ltbmR4XS5zeW0tPnN0X3ZhbHVlOyAvKiBTICovCj4gKyAgICAgICAgZWxzZSBp ZiAoICFlbGYtPnN5bVtzeW1uZHhdLnN5bSApCj4gKyAgICAgICAgewo+ICsgICAgICAgICAgICBk cHJpbnRrKFhFTkxPR19FUlIsIExJVkVQQVRDSCAiJXM6IE5vIHJlbGF0aXZlIHN5bWJvbEAldVxu IiwKPiArICAgICAgICAgICAgICAgICAgICBlbGYtPm5hbWUsIHN5bW5keCk7Cj4gKyAgICAgICAg ICAgIHJldHVybiAtRUlOVkFMOwo+ICsgICAgICAgIH0KPiArICAgICAgICBlbHNlCj4gKyAgICAg ICAgICAgIHZhbCA9IGVsZi0+c3ltW3N5bW5keF0uc3ltLT5zdF92YWx1ZTsgLyogUyAqLwo+ICAK PiAgICAgICAgICByYyA9IHBlcmZvcm1fcmVsKHR5cGUsIGRlc3QsIHZhbCwgYWRkZW5kKTsKPiAg ICAgICAgICBzd2l0Y2ggKCByYyApCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9hcm02NC9s aXZlcGF0Y2guYyBiL3hlbi9hcmNoL2FybS9hcm02NC9saXZlcGF0Y2guYwo+IGluZGV4IDYzOTI5 YjEuLmIwMzM3NjMgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gvYXJtL2FybTY0L2xpdmVwYXRjaC5j Cj4gKysrIGIveGVuL2FyY2gvYXJtL2FybTY0L2xpdmVwYXRjaC5jCj4gQEAgLTI1MiwxNCArMjUy LDI3IEBAIGludCBhcmNoX2xpdmVwYXRjaF9wZXJmb3JtX3JlbGEoc3RydWN0IGxpdmVwYXRjaF9l bGYgKmVsZiwKPiAgICAgICAgICBpbnQgb3ZmID0gMDsKPiAgICAgICAgICB1aW50NjRfdCB2YWw7 Cj4gIAo+ICsgICAgICAgIGlmICggc3ltbmR4ID09IFNUTl9VTkRFRiApCj4gKyAgICAgICAgewo+ ICsgICAgICAgICAgICBkcHJpbnRrKFhFTkxPR19FUlIsIExJVkVQQVRDSCAiJXM6IEVuY291bnRl cmVkIFNUTl9VTkRFRlxuIiwKPiArICAgICAgICAgICAgICAgICAgICBlbGYtPm5hbWUpOwo+ICsg ICAgICAgICAgICByZXR1cm4gLUVPUE5PVFNVUFA7Cj4gKyAgICAgICAgfQo+ICsKPiAgICAgICAg ICBpZiAoIHN5bW5keCA+IGVsZi0+bnN5bSApCj4gICAgICAgICAgewo+ICAgICAgICAgICAgICBk cHJpbnRrKFhFTkxPR19FUlIsIExJVkVQQVRDSCAiJXM6IFJlbGF0aXZlIHJlbG9jYXRpb24gd2Fu dHMgc3ltYm9sQCV1IHdoaWNoIGlzIHBhc3QgZW5kIVxuIiwKPiAgICAgICAgICAgICAgICAgICAg ICBlbGYtPm5hbWUsIHN5bW5keCk7Cj4gICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ICAg ICAgICAgIH0KPiAtCj4gLSAgICAgICAgdmFsID0gZWxmLT5zeW1bc3ltbmR4XS5zeW0tPnN0X3Zh bHVlICsgIHItPnJfYWRkZW5kOyAvKiBTK0EgKi8KPiArICAgICAgICBlbHNlIGlmICggIWVsZi0+ c3ltW3N5bW5keF0uc3ltICkKPiArICAgICAgICB7Cj4gKyAgICAgICAgICAgIGRwcmludGsoWEVO TE9HX0VSUiwgTElWRVBBVENIICIlczogTm8gcmVsYXRpdmUgc3ltYm9sQCV1XG4iLAo+ICsgICAg ICAgICAgICAgICAgICAgIGVsZi0+bmFtZSwgc3ltbmR4KTsKPiArICAgICAgICAgICAgcmV0dXJu IC1FSU5WQUw7Cj4gKyAgICAgICAgfQo+ICsgICAgICAgIGVsc2UKPiArICAgICAgICAgICAgdmFs ID0gZWxmLT5zeW1bc3ltbmR4XS5zeW0tPnN0X3ZhbHVlICsgci0+cl9hZGRlbmQ7IC8qIFMrQSAq Lwo+ICAKPiAgICAgICAgICAvKiBBUk02NCBvcGVyYXRpb25zIGF0IG1pbmltdW0gYXJlIGFsd2F5 cyAzMi1iaXQuICovCj4gICAgICAgICAgaWYgKCByLT5yX29mZnNldCA+PSBiYXNlLT5zZWMtPnNo X3NpemUgfHwKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2xpdmVwYXRjaC5jIGIveGVuL2Fy Y2gveDg2L2xpdmVwYXRjaC5jCj4gaW5kZXggNzkxNzYxMC4uYmZhNTc2YyAxMDA2NDQKPiAtLS0g YS94ZW4vYXJjaC94ODYvbGl2ZXBhdGNoLmMKPiArKysgYi94ZW4vYXJjaC94ODYvbGl2ZXBhdGNo LmMKPiBAQCAtMTcwLDE0ICsxNzAsMjcgQEAgaW50IGFyY2hfbGl2ZXBhdGNoX3BlcmZvcm1fcmVs YShzdHJ1Y3QgbGl2ZXBhdGNoX2VsZiAqZWxmLAo+ICAgICAgICAgIHVpbnQ4X3QgKmRlc3QgPSBi YXNlLT5sb2FkX2FkZHIgKyByLT5yX29mZnNldDsKPiAgICAgICAgICB1aW50NjRfdCB2YWw7Cj4g IAo+ICsgICAgICAgIGlmICggc3ltbmR4ID09IFNUTl9VTkRFRiApCj4gKyAgICAgICAgewo+ICsg ICAgICAgICAgICBkcHJpbnRrKFhFTkxPR19FUlIsIExJVkVQQVRDSCAiJXM6IEVuY291bnRlcmVk IFNUTl9VTkRFRlxuIiwKPiArICAgICAgICAgICAgICAgICAgICBlbGYtPm5hbWUpOwo+ICsgICAg ICAgICAgICByZXR1cm4gLUVPUE5PVFNVUFA7Cj4gKyAgICAgICAgfQo+ICsKPiAgICAgICAgICBp ZiAoIHN5bW5keCA+IGVsZi0+bnN5bSApCj4gICAgICAgICAgewo+ICAgICAgICAgICAgICBkcHJp bnRrKFhFTkxPR19FUlIsIExJVkVQQVRDSCAiJXM6IFJlbGF0aXZlIHJlbG9jYXRpb24gd2FudHMg c3ltYm9sQCV1IHdoaWNoIGlzIHBhc3QgZW5kIVxuIiwKPiAgICAgICAgICAgICAgICAgICAgICBl bGYtPm5hbWUsIHN5bW5keCk7Cj4gICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ICAgICAg ICAgIH0KPiAtCj4gLSAgICAgICAgdmFsID0gci0+cl9hZGRlbmQgKyBlbGYtPnN5bVtzeW1uZHhd LnN5bS0+c3RfdmFsdWU7Cj4gKyAgICAgICAgZWxzZSBpZiAoICFlbGYtPnN5bVtzeW1uZHhdLnN5 bSApCj4gKyAgICAgICAgewo+ICsgICAgICAgICAgICBkcHJpbnRrKFhFTkxPR19FUlIsIExJVkVQ QVRDSCAiJXM6IE5vIHN5bWJvbEAldVxuIiwKPiArICAgICAgICAgICAgICAgICAgICBlbGYtPm5h bWUsIHN5bW5keCk7Cj4gKyAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ICsgICAgICAgIH0K PiArICAgICAgICBlbHNlCj4gKyAgICAgICAgICAgIHZhbCA9IHItPnJfYWRkZW5kICsgZWxmLT5z eW1bc3ltbmR4XS5zeW0tPnN0X3ZhbHVlOwo+ICAKPiAgICAgICAgICBzd2l0Y2ggKCBFTEY2NF9S X1RZUEUoci0+cl9pbmZvKSApCj4gICAgICAgICAgewo+IC0tIAo+IDIuMS40Cj4gCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGlu ZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4t ZGV2ZWwK