From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>
Subject: [PATCH v5 03/13] x86: move do_set_trap_table to pv/callback.c
Date: Mon, 26 Jun 2017 17:28:32 +0100 [thread overview]
Message-ID: <20170626162842.482-4-wei.liu2@citrix.com> (raw)
In-Reply-To: <20170626162842.482-1-wei.liu2@citrix.com>
That hypercall is used to set guest callbacks for traps.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
xen/arch/x86/pv/callback.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++
xen/arch/x86/traps.c | 50 ----------------------------------------------
2 files changed, 50 insertions(+), 50 deletions(-)
diff --git a/xen/arch/x86/pv/callback.c b/xen/arch/x86/pv/callback.c
index d811f48110..0d7641df43 100644
--- a/xen/arch/x86/pv/callback.c
+++ b/xen/arch/x86/pv/callback.c
@@ -16,6 +16,7 @@
* License along with this program; If not, see <http://www.gnu.org/licenses/>.
*/
+#include <xen/event.h>
#include <xen/guest_access.h>
#include <xen/lib.h>
#include <xen/sched.h>
@@ -314,6 +315,55 @@ long compat_set_callbacks(unsigned long event_selector,
return 0;
}
+long do_set_trap_table(XEN_GUEST_HANDLE_PARAM(const_trap_info_t) traps)
+{
+ struct trap_info cur;
+ struct vcpu *curr = current;
+ struct trap_info *dst = curr->arch.pv_vcpu.trap_ctxt;
+ long rc = 0;
+
+ /* If no table is presented then clear the entire virtual IDT. */
+ if ( guest_handle_is_null(traps) )
+ {
+ memset(dst, 0, NR_VECTORS * sizeof(*dst));
+ init_int80_direct_trap(curr);
+ return 0;
+ }
+
+ for ( ; ; )
+ {
+ if ( copy_from_guest(&cur, traps, 1) )
+ {
+ rc = -EFAULT;
+ break;
+ }
+
+ if ( cur.address == 0 )
+ break;
+
+ if ( !is_canonical_address(cur.address) )
+ return -EINVAL;
+
+ fixup_guest_code_selector(curr->domain, cur.cs);
+
+ memcpy(&dst[cur.vector], &cur, sizeof(cur));
+
+ if ( cur.vector == 0x80 )
+ init_int80_direct_trap(curr);
+
+ guest_handle_add_offset(traps, 1);
+
+ if ( hypercall_preempt_check() )
+ {
+ rc = hypercall_create_continuation(
+ __HYPERVISOR_set_trap_table, "h", traps);
+ break;
+ }
+ }
+
+ return rc;
+}
+
/*
* Local variables:
* mode: C
diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
index 8caa9255ed..c43f3f1095 100644
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -2073,56 +2073,6 @@ int send_guest_trap(struct domain *d, uint16_t vcpuid, unsigned int trap_nr)
return -EIO;
}
-
-long do_set_trap_table(XEN_GUEST_HANDLE_PARAM(const_trap_info_t) traps)
-{
- struct trap_info cur;
- struct vcpu *curr = current;
- struct trap_info *dst = curr->arch.pv_vcpu.trap_ctxt;
- long rc = 0;
-
- /* If no table is presented then clear the entire virtual IDT. */
- if ( guest_handle_is_null(traps) )
- {
- memset(dst, 0, NR_VECTORS * sizeof(*dst));
- init_int80_direct_trap(curr);
- return 0;
- }
-
- for ( ; ; )
- {
- if ( copy_from_guest(&cur, traps, 1) )
- {
- rc = -EFAULT;
- break;
- }
-
- if ( cur.address == 0 )
- break;
-
- if ( !is_canonical_address(cur.address) )
- return -EINVAL;
-
- fixup_guest_code_selector(curr->domain, cur.cs);
-
- memcpy(&dst[cur.vector], &cur, sizeof(cur));
-
- if ( cur.vector == 0x80 )
- init_int80_direct_trap(curr);
-
- guest_handle_add_offset(traps, 1);
-
- if ( hypercall_preempt_check() )
- {
- rc = hypercall_create_continuation(
- __HYPERVISOR_set_trap_table, "h", traps);
- break;
- }
- }
-
- return rc;
-}
-
void activate_debugregs(const struct vcpu *curr)
{
ASSERT(curr == current);
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-06-26 16:29 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 16:28 [PATCH v5 00/13] x86: refactor trap handling code Wei Liu
2017-06-26 16:28 ` [PATCH v5 01/13] x86: move callback_op code to pv/callback.c Wei Liu
2017-06-26 16:44 ` Andrew Cooper
2017-06-27 6:13 ` Jan Beulich
2017-06-27 8:48 ` Wei Liu
2017-06-27 17:57 ` Andrew Cooper
2017-06-28 10:14 ` Wei Liu
2017-06-26 16:28 ` [PATCH v5 02/13] x86: move the compat callback ops next to the non-compat variant Wei Liu
2017-06-26 16:51 ` Andrew Cooper
2017-06-26 16:28 ` Wei Liu [this message]
2017-06-26 16:53 ` [PATCH v5 03/13] x86: move do_set_trap_table to pv/callback.c Andrew Cooper
2017-06-26 16:28 ` [PATCH v5 04/13] x86: move compat_set_trap_table along side the non-compat variant Wei Liu
2017-06-26 16:53 ` Andrew Cooper
2017-06-26 16:28 ` [PATCH v5 05/13] x86: remove the now empty x86_64/compat/traps.c Wei Liu
2017-06-26 16:54 ` Andrew Cooper
2017-06-26 16:28 ` [PATCH v5 06/13] x86: simplify guest_has_trap_callback Wei Liu
2017-06-26 16:57 ` Andrew Cooper
2017-06-27 6:09 ` Jan Beulich
2017-06-27 9:02 ` Wei Liu
2017-06-26 16:28 ` [PATCH v5 07/13] x86/traps: simplify and rename send_guest_trap Wei Liu
2017-06-27 18:01 ` Andrew Cooper
2017-06-27 18:21 ` Jan Beulich
2017-06-27 18:28 ` Andrew Cooper
2017-06-26 16:28 ` [PATCH v5 08/13] x86/traps: factor out pv_trap_init Wei Liu
2017-06-27 18:05 ` Andrew Cooper
2017-06-27 18:19 ` Jan Beulich
2017-06-28 11:43 ` Andrew Cooper
2017-06-27 18:26 ` Jan Beulich
2017-06-28 10:06 ` Wei Liu
2017-06-28 10:13 ` Wei Liu
2017-06-26 16:28 ` [PATCH v5 09/13] xen: move do_nmi_op and make it x86 only Wei Liu
2017-06-27 18:08 ` Andrew Cooper
2017-06-27 18:31 ` Jan Beulich
2017-06-27 18:50 ` Andrew Cooper
2017-06-28 10:12 ` Wei Liu
2017-06-27 20:34 ` Stefano Stabellini
2017-06-26 16:28 ` [PATCH v5 10/13] x86/traps: move {un, }register_guest_nmi_callback to pv/callback.c Wei Liu
2017-06-27 18:09 ` Andrew Cooper
2017-06-26 16:28 ` [PATCH v5 11/13] x86/callback.c: slightly change {un, }register_guest_nmi_callback Wei Liu
2017-06-27 18:10 ` Andrew Cooper
2017-06-26 16:28 ` [PATCH v5 12/13] x86/traps: move some PV specific functions to pv/traps.c Wei Liu
2017-06-27 18:12 ` Andrew Cooper
2017-06-27 18:34 ` Jan Beulich
2017-06-26 16:28 ` [PATCH v5 13/13] x86/traps.h: remove unused declaration of cpu_user_regs Wei Liu
2017-06-27 18:13 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170626162842.482-4-wei.liu2@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).