From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: andrew.cooper3@citrix.com, julien.grall@arm.com,
sstabellini@kernel.org, wei.liu2@citrix.com,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v5 09/13] xen: move do_nmi_op and make it x86 only
Date: Wed, 28 Jun 2017 11:12:51 +0100 [thread overview]
Message-ID: <20170628101251.64orhobtr3ne2eos@citrix.com> (raw)
In-Reply-To: <5952A478020000780010153B@prv-mh.provo.novell.com>
On Tue, Jun 27, 2017 at 12:31:20PM -0600, Jan Beulich wrote:
> >>> Wei Liu <wei.liu2@citrix.com> 06/26/17 6:29 PM >>>
> >Since ARM doesn't need do_nmi_op, move the hypercall handler from
> >common/kernel.c to pv/callback.c.
>
> There are two handlers you actually move, and while their neither large nor
> likely to change, I still somewhat dislike the code duplication you introduce.
> But I guess not enough to put under question the R-b you've already got
> from Andrew.
>
I'm with Andrew here. I deliberately unrolled all macros because the
resulting code is cleaner.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-06-28 10:13 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 16:28 [PATCH v5 00/13] x86: refactor trap handling code Wei Liu
2017-06-26 16:28 ` [PATCH v5 01/13] x86: move callback_op code to pv/callback.c Wei Liu
2017-06-26 16:44 ` Andrew Cooper
2017-06-27 6:13 ` Jan Beulich
2017-06-27 8:48 ` Wei Liu
2017-06-27 17:57 ` Andrew Cooper
2017-06-28 10:14 ` Wei Liu
2017-06-26 16:28 ` [PATCH v5 02/13] x86: move the compat callback ops next to the non-compat variant Wei Liu
2017-06-26 16:51 ` Andrew Cooper
2017-06-26 16:28 ` [PATCH v5 03/13] x86: move do_set_trap_table to pv/callback.c Wei Liu
2017-06-26 16:53 ` Andrew Cooper
2017-06-26 16:28 ` [PATCH v5 04/13] x86: move compat_set_trap_table along side the non-compat variant Wei Liu
2017-06-26 16:53 ` Andrew Cooper
2017-06-26 16:28 ` [PATCH v5 05/13] x86: remove the now empty x86_64/compat/traps.c Wei Liu
2017-06-26 16:54 ` Andrew Cooper
2017-06-26 16:28 ` [PATCH v5 06/13] x86: simplify guest_has_trap_callback Wei Liu
2017-06-26 16:57 ` Andrew Cooper
2017-06-27 6:09 ` Jan Beulich
2017-06-27 9:02 ` Wei Liu
2017-06-26 16:28 ` [PATCH v5 07/13] x86/traps: simplify and rename send_guest_trap Wei Liu
2017-06-27 18:01 ` Andrew Cooper
2017-06-27 18:21 ` Jan Beulich
2017-06-27 18:28 ` Andrew Cooper
2017-06-26 16:28 ` [PATCH v5 08/13] x86/traps: factor out pv_trap_init Wei Liu
2017-06-27 18:05 ` Andrew Cooper
2017-06-27 18:19 ` Jan Beulich
2017-06-28 11:43 ` Andrew Cooper
2017-06-27 18:26 ` Jan Beulich
2017-06-28 10:06 ` Wei Liu
2017-06-28 10:13 ` Wei Liu
2017-06-26 16:28 ` [PATCH v5 09/13] xen: move do_nmi_op and make it x86 only Wei Liu
2017-06-27 18:08 ` Andrew Cooper
2017-06-27 18:31 ` Jan Beulich
2017-06-27 18:50 ` Andrew Cooper
2017-06-28 10:12 ` Wei Liu [this message]
2017-06-27 20:34 ` Stefano Stabellini
2017-06-26 16:28 ` [PATCH v5 10/13] x86/traps: move {un, }register_guest_nmi_callback to pv/callback.c Wei Liu
2017-06-27 18:09 ` Andrew Cooper
2017-06-26 16:28 ` [PATCH v5 11/13] x86/callback.c: slightly change {un, }register_guest_nmi_callback Wei Liu
2017-06-27 18:10 ` Andrew Cooper
2017-06-26 16:28 ` [PATCH v5 12/13] x86/traps: move some PV specific functions to pv/traps.c Wei Liu
2017-06-27 18:12 ` Andrew Cooper
2017-06-27 18:34 ` Jan Beulich
2017-06-26 16:28 ` [PATCH v5 13/13] x86/traps.h: remove unused declaration of cpu_user_regs Wei Liu
2017-06-27 18:13 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628101251.64orhobtr3ne2eos@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).