Re: [PATCH 15/17 v5] xen/arm: vpl011: Add a new vuart console type to xenconsole client

[Wei Liu <wei.liu2@citrix.com>]

On Thu, Jun 29, 2017 at 03:03:45PM +0530, Bhupinder Thakur wrote:
> Hi Wei,
> 
> On 28 June 2017 at 22:47, Wei Liu <wei.liu2@citrix.com> wrote:
> > On Thu, Jun 22, 2017 at 01:08:50PM +0530, Bhupinder Thakur wrote:
> > [...]
> >>  static struct termios stdin_old_attr;
> >> @@ -343,6 +344,7 @@ int main(int argc, char **argv)
> >>       char *end;
> >>       console_type type = CONSOLE_INVAL;
> >>       bool interactive = 0;
> >> +     char *console_names = "serial, pv, vuart";
> >>
> >>       if (isatty(STDIN_FILENO) && isatty(STDOUT_FILENO))
> >>               interactive = 1;
> >> @@ -361,9 +363,12 @@ int main(int argc, char **argv)
> >>                               type = CONSOLE_SERIAL;
> >>                       else if (!strcmp(optarg, "pv"))
> >>                               type = CONSOLE_PV;
> >> +                     else if (!strcmp(optarg, "vuart"))
> >> +                             type = CONSOLE_VUART;
> >>                       else {
> >>                               fprintf(stderr, "Invalid type argument\n");
> >> -                             fprintf(stderr, "Console types supported are: serial, pv\n");
> >> +                             fprintf(stderr, "Console types supported are: %s\n",
> >> +                                             console_names);
> >
> > Coding style.
> I believe you are referring to the alignment of console_names with
> stderr above? Since in this file, tabs are used for indentation and

Yes.

> preserved, I am using tabs to align them but for some reason it is
> showing as unaligned here. If I open the patch file in vim with a tab
> setting of 4 then it is displayed correctly aligned.
> 

That's the problem. We all use 8 spaces for tab. :-)

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel