From: Wei Liu <wei.liu2@citrix.com>
To: Andreas Kinzler <ml-ak@posteo.de>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel <xen-devel@lists.xen.org>
Subject: Re: race in vif-common.sh
Date: Mon, 3 Jul 2017 14:07:15 +0100 [thread overview]
Message-ID: <20170703130715.gmo2hpnlnmnsd5kw@citrix.com> (raw)
In-Reply-To: <51dfd58a-9e63-3ad9-9bf4-be220233d469@posteo.de>
CC George (author of recent change) and Ian
On Mon, Jul 03, 2017 at 01:30:09PM +0200, Andreas Kinzler wrote:
> Hello
>
> in /etc/xen/scripts/vif-common.sh there is a function handle_iptable.
> At its start there is a check for a working iptables implementation.
> This check is outside the iptables lock section (claim_lock
> "iptables") and even if it is only a read-only operation the
> underlying iptables operation still accesses the xtables lock. I
> debugged a malfunction (=race) with multiple vif-interfaces down to
> the following iptables error message in the check section above:
>
> iptables -L -n Another app is currently holding the xtables lock.
> Perhaps you want to use the -w option?
>
> So this check needs to be inside the lock or removed at all (iptables
> should be working).
>
> Regards Andreas
>
> _______________________________________________ Xen-devel mailing list
> Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-07-03 13:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 11:30 race in vif-common.sh Andreas Kinzler
2017-07-03 13:07 ` Wei Liu [this message]
2017-07-27 10:55 ` George Dunlap
2017-07-27 16:12 ` Andreas Kinzler
2017-07-27 16:49 ` George Dunlap
2017-07-27 17:11 ` Andreas Kinzler
2017-07-27 20:13 ` George Dunlap
[not found] <c78e6100-18d6-87c3-b67b-c2088e071b4c@posteo.de>
2017-07-03 11:28 ` Andreas Kinzler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170703130715.gmo2hpnlnmnsd5kw@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ml-ak@posteo.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).