Re: [PATCH v13 16/23] x86: L2 CAT: implement CPU init flow.

[Yi Sun <yi.y.sun@linux.intel.com>]

On 17-07-12 14:09:40, Jan Beulich wrote:
> >>> Yi Sun <yi.y.sun@linux.intel.com> 07/06/17 4:07 AM >>>
> >This patch implements the CPU init flow for L2 CAT.
> >
> >Note: L2 CAT does NOT work until you apply the later patches of L2 CAT.
> >"x86: L2 CAT: implement get hw info flow."
> >"x86: L2 CAT: implement get value flow."
> >"x86: L2 CAT: implement set value flow."
> 
> Same comment as on the respective CDP one.
> 
Will change it.

> >@@ -269,6 +271,12 @@ static bool psr_check_cbm(unsigned int cbm_len, unsigned long cbm)
>  >}
>  >
>  >/* CAT common functions implementation. */
> >+static char *feat_name[FEAT_TYPE_NUM] = {
> 
> const char * const
> 
> Additionally - do you need or plan to use this in more than one function? If
> not, it should be made local to its only user. If so, the variable name should
> include "cat", as these appear to be CAT-specific feature names only.
> 
This should be moved into cat_init_feature() as a local array. Thanks!

> Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel