From: Wei Liu <wei.liu2@citrix.com>
To: Haozhong Zhang <haozhong.zhang@intel.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v9 7/7] tools/xen-mceinj: add support of injecting LMCE
Date: Tue, 18 Jul 2017 11:33:04 +0100 [thread overview]
Message-ID: <20170718103304.3c2xpvj6mrlnwh2f@citrix.com> (raw)
In-Reply-To: <20170712020440.777-8-haozhong.zhang@intel.com>
On Wed, Jul 12, 2017 at 10:04:40AM +0800, Haozhong Zhang wrote:
>
> +static int inject_lmce(xc_interface *xc_handle, unsigned int cpu)
> +{
> + uint8_t *cpumap = NULL;
> + size_t cpumap_size, line, shift;
> + unsigned int nr_cpus;
> + int ret;
> +
> + nr_cpus = mca_cpuinfo(xc_handle);
> + if ( !nr_cpus )
> + err(xc_handle, "Failed to get mca_cpuinfo");
> + if ( cpu >= nr_cpus )
> + err(xc_handle, "-c %u is larger than %u", cpu, nr_cpus - 1);
> +
> + cpumap_size = (nr_cpus + 7) / 8;
> + cpumap = malloc(cpumap_size);
> + if ( !cpumap )
> + err(xc_handle, "Failed to allocate cpumap\n");
> + memset(cpumap, 0, cpumap_size);
> + line = cpu / 8;
> + shift = cpu % 8;
> + memset(cpumap + line, 1 << shift, 1);
> +
> + ret = xc_mca_op_inject_v2(xc_handle, XEN_MC_INJECT_TYPE_LMCE,
> + cpumap, cpumap_size * 8);
This doesn't compile because XEN_MC_INJECT_TYPE_LMCE is not defined.
Please rework this patch and make sure it compiles before submitting.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-07-18 10:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 2:04 [PATCH v9 0/7] Add LMCE support Haozhong Zhang
2017-07-12 2:04 ` [PATCH v9 1/7] x86/domctl: generalize the restore of vMCE parameters Haozhong Zhang
2017-07-12 6:50 ` Jan Beulich
2017-07-12 2:04 ` [PATCH v9 2/7] x86/vmce: emulate MSR_IA32_MCG_EXT_CTL Haozhong Zhang
2017-07-12 2:04 ` [PATCH v9 3/7] x86/vmce: enable injecting LMCE to guest on Intel host Haozhong Zhang
2017-07-12 2:04 ` [PATCH v9 4/7] x86/vmce, tools/libxl: expose LMCE capability in guest MSR_IA32_MCG_CAP Haozhong Zhang
2017-07-12 2:04 ` [PATCH v9 5/7] xen/mce: add support of vLMCE injection to XEN_MC_inject_v2 Haozhong Zhang
2017-07-12 2:04 ` [PATCH v9 6/7] tools/libxc: add support of injecting MC# to specified CPUs Haozhong Zhang
2017-07-12 13:25 ` Konrad Rzeszutek Wilk
2017-07-13 6:15 ` Haozhong Zhang
2017-07-12 2:04 ` [PATCH v9 7/7] tools/xen-mceinj: add support of injecting LMCE Haozhong Zhang
2017-07-12 13:26 ` Konrad Rzeszutek Wilk
2017-07-13 2:10 ` Haozhong Zhang
2017-07-17 10:05 ` Wei Liu
2017-07-17 15:21 ` Wei Liu
2017-07-18 10:33 ` Wei Liu [this message]
2017-07-18 10:34 ` Wei Liu
2017-07-14 10:48 ` [PATCH v9 0/7] Add LMCE support Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718103304.3c2xpvj6mrlnwh2f@citrix.com \
--to=wei.liu2@citrix.com \
--cc=haozhong.zhang@intel.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).