xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Tim Deegan <tim@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	xen-devel@lists.xen.org,
	Venu Busireddy <venu.busireddy@oracle.com>,
	Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH 2/6] xl: Add commands for hiding and unhiding pcie passthrough devices
Date: Tue, 18 Jul 2017 11:38:45 -0400	[thread overview]
Message-ID: <20170718153845.GE28241@char.us.oracle.com> (raw)
In-Reply-To: <20170718133814.bwwn4fggh7n7y7oq@citrix.com>

On Tue, Jul 18, 2017 at 02:38:14PM +0100, Wei Liu wrote:
> On Fri, Jul 07, 2017 at 10:00:01AM -0400, Konrad Rzeszutek Wilk wrote:
> > > 
> > > 1. PV PCI passthrough is done via pciback, which means the physical
> > >    device is assigned to the driver domain. All events to / from the
> > >    guest / device are handled by the driver domain -- which includes
> > >    the AER error you're trying to handle.
> > > 
> > > 2. HVM PCI passthrough is done via QEMU, but you also need to pre-assign
> > >    the device to the driver domain in which QEMU runs. All events are only
> > >    visible to the driver domain.
> > > 
> > > Yes, a guest is going to be always killable by Dom0 (the toolstack
> > > domain), even if some devices of the guest are handled by a driver
> > > domain.
> > > 
> > > But Dom0 now can't see the AER event so it won't be able to issue the
> > > "kill" or whatever action you want it to do. Is this not the case? Do
> > 
> > It can. That is how it works right now - the AER errors are sent to the
> > PCIe bridge which is a device driver in domain0. Then the kernel
> > sends it to pciback (which owns the device) to deal with.
> > 
> 
> So pciback will have to run in Dom0?

You need a kernel piece to deal with AER (as it is an normal interrupt to
the PCIe bridge and the PCIe bridge picks this up and does its thing).

The AER mechanism (in Linux) then walks through all the devices underneath
the PCIe bridge and gives it options to do things - and in case of pciback
we can do the right thing.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-07-18 15:38 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27 17:14 [PATCH 0/6] AER unrecoverable error containment Venu Busireddy
2017-06-27 17:14 ` [PATCH 1/6] xen: Add support for hiding and unhiding pcie passthrough devices Venu Busireddy
2017-07-04 15:46   ` Jan Beulich
2017-07-05 19:38     ` Venu Busireddy
2017-07-05 20:48       ` Konrad Rzeszutek Wilk
2017-07-06  8:45       ` Jan Beulich
2017-07-07 11:00         ` Wei Liu
2017-07-07 18:22           ` Venu Busireddy
2017-07-07 18:11         ` Venu Busireddy
2017-07-10  7:52           ` Jan Beulich
2017-07-10 16:58             ` Venu Busireddy
2017-06-27 17:14 ` [PATCH 2/6] xl: Add commands " Venu Busireddy
2017-06-30 10:18   ` Wei Liu
2017-07-05 19:52     ` Venu Busireddy
2017-07-07 10:56       ` Wei Liu
2017-07-07 14:00         ` Konrad Rzeszutek Wilk
2017-07-18 13:38           ` Wei Liu
2017-07-18 15:38             ` Konrad Rzeszutek Wilk [this message]
2017-06-27 17:14 ` [PATCH 3/6] libxc: Add wrappers for new commands Venu Busireddy
2017-06-29 17:52   ` Wei Liu
2017-06-27 17:14 ` [PATCH 4/6] libxl: Add wrappers for new commands and add AER error handler Venu Busireddy
2017-06-30 10:18   ` Wei Liu
2017-07-05 20:06     ` Venu Busireddy
2017-06-27 17:14 ` [PATCH 5/6] tools/python/xc: Update pyxc_methods with new commands Venu Busireddy
2017-06-27 17:14 ` [PATCH 6/6] docs: Document the " Venu Busireddy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170718153845.GE28241@char.us.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=venu.busireddy@oracle.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).