From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey G Subject: Re: [PATCH] xen-mapcache: Fix the bug when overlapping emulated DMA operations may cause inconsistency in guest memory mappings Date: Wed, 19 Jul 2017 19:06:29 +1000 Message-ID: <20170719190629.00001a7b@gmail.com> References: <20170711060015.00004b1f@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Stefano Stabellini Cc: Anthony PERARD , james.mckenzie@bromium.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org U3RlZmFubywKCk9uIFR1ZSwgMTggSnVsIDIwMTcgMTU6MTc6MjUgLTA3MDAgKFBEVCkKU3RlZmFu byBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPiB3cm90ZToKCj4gPiBUaGUgcGF0 Y2ggbW9kaWZpZXMgdGhlIGJlaGF2aW9yIGluIHdoaWNoIE1hcENhY2hlRW50cnkncyBhcmUgYWRk ZWQgdG8KPiA+IHRoZSBsaXN0LCBhdm9pZGluZyBkdXBsaWNhdGVzLiAgCj4gCj4gSSB0YWtlIHRo YXQgdGhlIGlkZWEgaXMgdG8gYWx3YXlzIGdvIHRocm91Z2ggdGhlIHdob2xlIGxpc3QgdG8gY2hl Y2sgZm9yCj4gZHVwbGljYXRlIGxvY2tlZCBlbnRyaWVzLCByaWdodD8KIApUaGF0J3MgYSBzaG9y dCBsaXN0LgoKSW4gZmFjdCwgaXQncyBub3QgZWFzeSB0byBnZW5lcmF0ZSBtdWx0aXBsZSBsaW5r ZWQgZW50cmllcyBpbiB0aGlzIGxpc3QgLS0Kbm9ybWFsbHksIGVudHJpZXMgd2lsbCBiZSBhZGRl ZCwgdXNlZCBhbmQgdGhlbiByZW1vdmVkIGltbWVkaWF0ZWx5IGJ5Cnhlbl9pbnZhbGlkYXRlX21h cF9jYWNoZSgpLiBTcGVjaWZpYyBjb25kaXRpb25zIGFyZSByZXF1aXJlZCB0byBtYWtlIHRoZQps aXN0IGdyb3cgLS0gbGlrZSBzaW11bHRhbmVvdXMgRE1BIG9wZXJhdGlvbnMgKG9mIGRpZmZlcmVu dCBjYWNoZV9zaXplKQpvcmlnaW5hdGluZyB0aGUgc2FtZSBhZGRyZXNzX2luZGV4IG9yIHByZXNl bmNlIG9mIHRoZSBPcHRpb24gUk9NIG1hcHBpbmcgaW4KdGhlIGFyZWEuIAoKU28gbm9ybWFsbHkg d2UgZGVhbCB3aXRoIGp1c3QgMS0yIGVudHJpZXMgaW4gdGhlIGxpc3QuIEV2ZW4gdGhyZWUgZW50 cmllcwphcmUgbGlrZWx5IHRvIGJlIGdlbmVyYXRlZCBvbmx5IGludGVudGlvbmFsbHkgYW5kIHdp dGggYSBiaXQgb2YgbHVjayBhcyBpdApkZXBlbmRzIG9uIGhvc3QncyBwZXJmb3JtYW5jZS93b3Jr bG9hZCBhIGxvdC4gQWxzbywgYSBnb29kIGNhY2hlX3NpemUKZGl2ZXJzaXR5IGlzIHJlcXVpcmVk IHRvIHByb2R1Y2UgZW50cmllcyBpbiB0aGUgbGlzdCBidXQgd2UgYWN0dWFsbHkKbGltaXRlZCB0 byBvbmx5IGZldyBtdWx0aXBsaWVzIG9mIE1DQUNIRV9CVUNLRVRfU0laRSBkdWUgdG8gdGhlIG1h eGltdW0gRE1BCnNpemUgbGltaXRhdGlvbnMgb2YgZW11bGF0ZWQgZGV2aWNlcy4KCj4gWWVzLCBJ IHRoaW5rIHRoaXMgd291bGQgd29yaywgYnV0IHdlIHNob3VsZCBtYWtlIHN1cmUgdG8gc2NhbiB0 aGUgd2hvbGUKPiBsaXN0IG9ubHkgd2hlbiBsb2NrID09ICB0cnVlLiBTb21ldGhpbmcgbGlrZSB0 aGUgZm9sbG93aW5nOgo+IAo+IC0gICAgd2hpbGUgKGVudHJ5ICYmIGVudHJ5LT5sb2NrICYmIGVu dHJ5LT52YWRkcl9iYXNlICYmCj4gKyAgICB3aGlsZSAoZW50cnkgJiYgKGxvY2sgfHwgZW50cnkt PmxvY2spICYmIGVudHJ5LT52YWRkcl9iYXNlICYmCj4gICAgICAgICAgICAgIChlbnRyeS0+cGFk ZHJfaW5kZXggIT0gYWRkcmVzc19pbmRleCB8fCBlbnRyeS0+c2l6ZSAhPQo+IGNhY2hlX3NpemUg fHwgIXRlc3RfYml0cyhhZGRyZXNzX29mZnNldCA+PiBYQ19QQUdFX1NISUZULAo+ICAgICAgICAg ICAgICAgICAgIHRlc3RfYml0X3NpemUgPj4gWENfUEFHRV9TSElGVCwKPiAgICAgICAgICAgICAg ICAgICBlbnRyeS0+dmFsaWRfbWFwcGluZykpKSB7Cj4gKyAgICAgICAgaWYgKCFmcmVlX2VudHJ5 ICYmICFlbnRyeS0+bG9jaykgewo+ICsgICAgICAgICAgICBmcmVlX2VudHJ5ID0gZW50cnk7Cj4g KyAgICAgICAgICAgIGZyZWVfcGVudHJ5ID0gcGVudHJ5Owo+ICsgICAgICAgIH0KPiAgICAgICAg ICBwZW50cnkgPSBlbnRyeTsKPiAgICAgICAgICBlbnRyeSA9IGVudHJ5LT5uZXh0Owo+ICAgICAg fQo+IAo+IFdvdWxkIHRoaXMgd29yaz8KClRoaXMgd291bGQsIGJ1dCB0aGUgcXVlc3Rpb24gaXMg aWYgdGhlcmUgd2lsbCBiZSBhIGJlbmVmaXQuIEluIHRoaXMgd2F5IHdlCmF2b2lkaW5nIHRvIHRy YXZlcnNlIHRoZSByZXN0IG9mIHRoZSBsaXN0IChmZXcgZW50cmllcywgaWYgYW55KSBpZiB3ZSBh c2tlZApmb3Igc29tZSBsb2NrPTAgbWFwcGluZyBhbmQgZm91bmQgc3VjaCBlbnRyeSBiZWZvcmUg dGhlIHJldXNlYWJsZSBsb2NrPW4KZW50cnkuIFdlIHdpbiBmZXcgaXRlcmF0aW9ucyBvZiBxdWlj ayBjaGVja3MsIGJ1dCBvbiBvdGhlciBoYW5kIHJpc2tpbmcgdG8KaGF2ZSB0byBleGVjdXRlIHhl bl9yZW1hcF9idWNrZXQoKSBmb3IgdGhpcyBlbnRyeSAod2l0aCBsb3Qgb2YgZmFpcmx5IHNsb3cK c3R1ZmYpLiBJZiB0aGVyZSB3YXMgYSByZXVzYWJsZSBlbnRyeSBsYXRlciBpbiB0aGUgbGlzdCAt LSB1c2luZyBpdCBpbnN0ZWFkCm9mIChwb3NzaWJseSkgcmVtYXBwaW5nIGFuIGVudHJ5IHdpbGwg YmUgZmFzdGVyLi4uIHNvIGl0J3MgcHJvcyBhbmQgY29ucwpoZXJlLgoKV2UgY2FuIHVzZSBsb2Nr ZWQgZW50cnkgZm9yICJub24tbG9ja2VkIiByZXF1ZXN0IGFzIGl0IGlzIHByb3RlY3RlZCBieSB0 aGUKc2FtZSAoa2luZGEgc3VzcGljaW91cykgcmN1X3JlYWRfbG9jay9yY3VfcmVhZF91bmxvY2sg bWVjaGFuaXNtIGFib3ZlLiBUaGUKYmlnIHF1ZXN0aW9uIGhlcmUgaXMgd2hldGhlciByY3VfcmVh ZF8odW4pbG9jayBpcyBlbm91Z2ggYXQgYWxsCmZvciB1bmRlcm5lYXRoIHhlbi1tYXBjYWNoZSB1 c2FnZSAtLSBzZWVtcyBsaWtlIHRoZSB4ZW4tbWFwY2FjaGUtcmVsYXRlZApjb2RlIGluIFFFTVUg ZXhwZWN0cyBSQ1UgcmVhZCBsb2NrIHRvIHdvcmsgbGlrZSBhIHBsYWluIGNyaXRpY2FsIHNlY3Rp b24uLi4KYWx0aG91Z2ggdGhpcyBuZWVkcyB0byBiZSBjaGVja2VkLgoKT25lIHBvc3NpYmxlIG1p bm9yIG9wdGltaXphdGlvbiBmb3IgeGVuLW1hcGNhY2hlIHdvdWxkIGJlIHRvIHJldXNlIGxhcmdl cgptYXBwaW5ncyBmb3IgbWFwcGluZ3Mgb2YgbGVzc2VyIGNhY2hlX3NpemUuIFJpZ2h0IG5vdyBl eGlzdGluZyBjb2RlIGRvZXMKY2hlY2tzIGluIHRoZSAiZW50cnktPnNpemUgPT0gY2FjaGVfc2l6 ZSIgbWFubmVyLCB3aGlsZSB3ZSBjYW4gdXNlCiJlbnRyeS0+c2l6ZSA+PSBjYWNoZV9zaXplIiBo ZXJlLiBIb3dldmVyLCB3ZSBtYXkgZW5kIHVwIHdpdGggcmVzaWRlbnQKTWFwQ2FjaGVFbnRyaWVz IGJlaW5nIG1hcHBlZCB0byBhIGJpZ2dlciBtYXBwaW5nIHNpemVzIHRoYW4gbmVjZXNzYXJ5IGFu ZAp0aHVzIG1pZ2h0IG5lZWQgdG8gYWRkIHJlbWFwcGluZyBiYWNrIHRvIHRoZSBub3JtYWwgc2l6 ZSBpbgp4ZW5faW52YWxpZGF0ZV9tYXBfY2FjaGVfZW50cnlfdW5sb2NrZWQoKSB3aGVuIHRoZXJl IGFyZSBubyBvdGhlciBtYXBwaW5ncy4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhl bi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=