* [PATCH] docs: fix superpage default value @ 2017-07-20 11:35 Wei Liu 2017-07-20 11:45 ` Roger Pau Monné 0 siblings, 1 reply; 10+ messages in thread From: Wei Liu @ 2017-07-20 11:35 UTC (permalink / raw) To: Xen-devel Cc: Stefano Stabellini, Wei Liu, George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan, Jan Beulich The code says it defaults to false. Signed-off-by: Wei Liu <wei.liu2@citrix.com> --- Cc: Andrew Cooper <andrew.cooper3@citrix.com> Cc: George Dunlap <George.Dunlap@eu.citrix.com> Cc: Ian Jackson <ian.jackson@eu.citrix.com> Cc: Jan Beulich <jbeulich@suse.com> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Cc: Stefano Stabellini <sstabellini@kernel.org> Cc: Tim Deegan <tim@xen.org> Cc: Wei Liu <wei.liu2@citrix.com> --- docs/misc/xen-command-line.markdown | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-command-line.markdown index 3f90c3b7a8..f524294aa6 100644 --- a/docs/misc/xen-command-line.markdown +++ b/docs/misc/xen-command-line.markdown @@ -136,7 +136,7 @@ mode during S3 resume. ### allowsuperpage > `= <boolean>` -> Default: `true` +> Default: `false` Permit Xen to use superpages when performing memory management. -- 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] docs: fix superpage default value 2017-07-20 11:35 [PATCH] docs: fix superpage default value Wei Liu @ 2017-07-20 11:45 ` Roger Pau Monné 2017-07-20 11:47 ` Wei Liu 0 siblings, 1 reply; 10+ messages in thread From: Roger Pau Monné @ 2017-07-20 11:45 UTC (permalink / raw) To: Wei Liu Cc: Stefano Stabellini, George Dunlap, Ian Jackson, Tim Deegan, Jan Beulich, Andrew Cooper, Xen-devel On Thu, Jul 20, 2017 at 12:35:56PM +0100, Wei Liu wrote: > The code says it defaults to false. > > Signed-off-by: Wei Liu <wei.liu2@citrix.com> > --- > Cc: Andrew Cooper <andrew.cooper3@citrix.com> > Cc: George Dunlap <George.Dunlap@eu.citrix.com> > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > Cc: Jan Beulich <jbeulich@suse.com> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > Cc: Stefano Stabellini <sstabellini@kernel.org> > Cc: Tim Deegan <tim@xen.org> > Cc: Wei Liu <wei.liu2@citrix.com> > --- > docs/misc/xen-command-line.markdown | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-command-line.markdown > index 3f90c3b7a8..f524294aa6 100644 > --- a/docs/misc/xen-command-line.markdown > +++ b/docs/misc/xen-command-line.markdown > @@ -136,7 +136,7 @@ mode during S3 resume. > ### allowsuperpage > > `= <boolean>` > > -> Default: `true` > +> Default: `false` > > Permit Xen to use superpages when performing memory management. I'm not an expert on Xen MM code, but isn't this intended for PV guests? The description above makes it look like this is for Xen itself, but AFAICT from skimming over the code this seems to be a PV feature, in which case the text above should be fixed to prevent confusion. Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] docs: fix superpage default value 2017-07-20 11:45 ` Roger Pau Monné @ 2017-07-20 11:47 ` Wei Liu 2017-07-20 11:49 ` Andrew Cooper 0 siblings, 1 reply; 10+ messages in thread From: Wei Liu @ 2017-07-20 11:47 UTC (permalink / raw) To: Roger Pau Monné Cc: Stefano Stabellini, Wei Liu, George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan, Jan Beulich, Xen-devel On Thu, Jul 20, 2017 at 12:45:38PM +0100, Roger Pau Monné wrote: > On Thu, Jul 20, 2017 at 12:35:56PM +0100, Wei Liu wrote: > > The code says it defaults to false. > > > > Signed-off-by: Wei Liu <wei.liu2@citrix.com> > > --- > > Cc: Andrew Cooper <andrew.cooper3@citrix.com> > > Cc: George Dunlap <George.Dunlap@eu.citrix.com> > > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > > Cc: Jan Beulich <jbeulich@suse.com> > > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > Cc: Stefano Stabellini <sstabellini@kernel.org> > > Cc: Tim Deegan <tim@xen.org> > > Cc: Wei Liu <wei.liu2@citrix.com> > > --- > > docs/misc/xen-command-line.markdown | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-command-line.markdown > > index 3f90c3b7a8..f524294aa6 100644 > > --- a/docs/misc/xen-command-line.markdown > > +++ b/docs/misc/xen-command-line.markdown > > @@ -136,7 +136,7 @@ mode during S3 resume. > > ### allowsuperpage > > > `= <boolean>` > > > > -> Default: `true` > > +> Default: `false` > > > > Permit Xen to use superpages when performing memory management. > > I'm not an expert on Xen MM code, but isn't this intended for PV > guests? The description above makes it look like this is for Xen > itself, but AFAICT from skimming over the code this seems to be a PV > feature, in which case the text above should be fixed to prevent > confusion. I believe it is PV only, but I'm not 100% sure. I would love to fix the text as well if possible. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] docs: fix superpage default value 2017-07-20 11:47 ` Wei Liu @ 2017-07-20 11:49 ` Andrew Cooper 2017-07-20 12:57 ` Wei Liu 0 siblings, 1 reply; 10+ messages in thread From: Andrew Cooper @ 2017-07-20 11:49 UTC (permalink / raw) To: Wei Liu, Roger Pau Monné Cc: Stefano Stabellini, George Dunlap, Tim Deegan, Ian Jackson, Jan Beulich, Xen-devel On 20/07/17 12:47, Wei Liu wrote: > On Thu, Jul 20, 2017 at 12:45:38PM +0100, Roger Pau Monné wrote: >> On Thu, Jul 20, 2017 at 12:35:56PM +0100, Wei Liu wrote: >>> The code says it defaults to false. >>> >>> Signed-off-by: Wei Liu <wei.liu2@citrix.com> >>> --- >>> Cc: Andrew Cooper <andrew.cooper3@citrix.com> >>> Cc: George Dunlap <George.Dunlap@eu.citrix.com> >>> Cc: Ian Jackson <ian.jackson@eu.citrix.com> >>> Cc: Jan Beulich <jbeulich@suse.com> >>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> >>> Cc: Stefano Stabellini <sstabellini@kernel.org> >>> Cc: Tim Deegan <tim@xen.org> >>> Cc: Wei Liu <wei.liu2@citrix.com> >>> --- >>> docs/misc/xen-command-line.markdown | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-command-line.markdown >>> index 3f90c3b7a8..f524294aa6 100644 >>> --- a/docs/misc/xen-command-line.markdown >>> +++ b/docs/misc/xen-command-line.markdown >>> @@ -136,7 +136,7 @@ mode during S3 resume. >>> ### allowsuperpage >>> > `= <boolean>` >>> >>> -> Default: `true` >>> +> Default: `false` >>> >>> Permit Xen to use superpages when performing memory management. >> I'm not an expert on Xen MM code, but isn't this intended for PV >> guests? The description above makes it look like this is for Xen >> itself, but AFAICT from skimming over the code this seems to be a PV >> feature, in which case the text above should be fixed to prevent >> confusion. > I believe it is PV only, but I'm not 100% sure. > > I would love to fix the text as well if possible. I'm fairly sure this option applies exclusively to PV superpages. Double check the logic through the code, but I think (since dropping 32bit support), we have no configuration where Xen might not be able to use superpages. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] docs: fix superpage default value 2017-07-20 11:49 ` Andrew Cooper @ 2017-07-20 12:57 ` Wei Liu 2017-07-21 16:21 ` Andrew Cooper 2017-07-21 16:44 ` Konrad Rzeszutek Wilk 0 siblings, 2 replies; 10+ messages in thread From: Wei Liu @ 2017-07-20 12:57 UTC (permalink / raw) To: Andrew Cooper Cc: Stefano Stabellini, Wei Liu, George Dunlap, Tim Deegan, Ian Jackson, Jan Beulich, Xen-devel, Roger Pau Monné On Thu, Jul 20, 2017 at 12:49:37PM +0100, Andrew Cooper wrote: > On 20/07/17 12:47, Wei Liu wrote: > > On Thu, Jul 20, 2017 at 12:45:38PM +0100, Roger Pau Monné wrote: > > > On Thu, Jul 20, 2017 at 12:35:56PM +0100, Wei Liu wrote: > > > > The code says it defaults to false. > > > > > > > > Signed-off-by: Wei Liu <wei.liu2@citrix.com> > > > > --- > > > > Cc: Andrew Cooper <andrew.cooper3@citrix.com> > > > > Cc: George Dunlap <George.Dunlap@eu.citrix.com> > > > > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > > > > Cc: Jan Beulich <jbeulich@suse.com> > > > > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > > > Cc: Stefano Stabellini <sstabellini@kernel.org> > > > > Cc: Tim Deegan <tim@xen.org> > > > > Cc: Wei Liu <wei.liu2@citrix.com> > > > > --- > > > > docs/misc/xen-command-line.markdown | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-command-line.markdown > > > > index 3f90c3b7a8..f524294aa6 100644 > > > > --- a/docs/misc/xen-command-line.markdown > > > > +++ b/docs/misc/xen-command-line.markdown > > > > @@ -136,7 +136,7 @@ mode during S3 resume. > > > > ### allowsuperpage > > > > > `= <boolean>` > > > > -> Default: `true` > > > > +> Default: `false` > > > > Permit Xen to use superpages when performing memory management. > > > I'm not an expert on Xen MM code, but isn't this intended for PV > > > guests? The description above makes it look like this is for Xen > > > itself, but AFAICT from skimming over the code this seems to be a PV > > > feature, in which case the text above should be fixed to prevent > > > confusion. > > I believe it is PV only, but I'm not 100% sure. > > > > I would love to fix the text as well if possible. > > I'm fairly sure this option applies exclusively to PV superpages. Double > check the logic through the code, but I think (since dropping 32bit > support), we have no configuration where Xen might not be able to use > superpages. > So we can just delete this option and make Xen always use superpage? That would be fine by me, too. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] docs: fix superpage default value 2017-07-20 12:57 ` Wei Liu @ 2017-07-21 16:21 ` Andrew Cooper 2017-07-21 16:26 ` Wei Liu 2017-07-21 16:44 ` Konrad Rzeszutek Wilk 1 sibling, 1 reply; 10+ messages in thread From: Andrew Cooper @ 2017-07-21 16:21 UTC (permalink / raw) To: Wei Liu Cc: Stefano Stabellini, George Dunlap, Ian Jackson, Tim Deegan, Jan Beulich, Xen-devel, Roger Pau Monné On 20/07/17 13:57, Wei Liu wrote: > On Thu, Jul 20, 2017 at 12:49:37PM +0100, Andrew Cooper wrote: >> On 20/07/17 12:47, Wei Liu wrote: >>> On Thu, Jul 20, 2017 at 12:45:38PM +0100, Roger Pau Monné wrote: >>>> On Thu, Jul 20, 2017 at 12:35:56PM +0100, Wei Liu wrote: >>>>> The code says it defaults to false. >>>>> >>>>> Signed-off-by: Wei Liu <wei.liu2@citrix.com> >>>>> --- >>>>> Cc: Andrew Cooper <andrew.cooper3@citrix.com> >>>>> Cc: George Dunlap <George.Dunlap@eu.citrix.com> >>>>> Cc: Ian Jackson <ian.jackson@eu.citrix.com> >>>>> Cc: Jan Beulich <jbeulich@suse.com> >>>>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> >>>>> Cc: Stefano Stabellini <sstabellini@kernel.org> >>>>> Cc: Tim Deegan <tim@xen.org> >>>>> Cc: Wei Liu <wei.liu2@citrix.com> >>>>> --- >>>>> docs/misc/xen-command-line.markdown | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-command-line.markdown >>>>> index 3f90c3b7a8..f524294aa6 100644 >>>>> --- a/docs/misc/xen-command-line.markdown >>>>> +++ b/docs/misc/xen-command-line.markdown >>>>> @@ -136,7 +136,7 @@ mode during S3 resume. >>>>> ### allowsuperpage >>>>> > `= <boolean>` >>>>> -> Default: `true` >>>>> +> Default: `false` >>>>> Permit Xen to use superpages when performing memory management. >>>> I'm not an expert on Xen MM code, but isn't this intended for PV >>>> guests? The description above makes it look like this is for Xen >>>> itself, but AFAICT from skimming over the code this seems to be a PV >>>> feature, in which case the text above should be fixed to prevent >>>> confusion. >>> I believe it is PV only, but I'm not 100% sure. >>> >>> I would love to fix the text as well if possible. >> I'm fairly sure this option applies exclusively to PV superpages. Double >> check the logic through the code, but I think (since dropping 32bit >> support), we have no configuration where Xen might not be able to use >> superpages. >> > So we can just delete this option and make Xen always use superpage? > That would be fine by me, too. No - my point was that this option now exclusively controls PV superpages, IIRC. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] docs: fix superpage default value 2017-07-21 16:21 ` Andrew Cooper @ 2017-07-21 16:26 ` Wei Liu 0 siblings, 0 replies; 10+ messages in thread From: Wei Liu @ 2017-07-21 16:26 UTC (permalink / raw) To: Andrew Cooper Cc: Stefano Stabellini, Wei Liu, George Dunlap, Tim Deegan, Ian Jackson, Jan Beulich, Xen-devel, Roger Pau Monné On Fri, Jul 21, 2017 at 05:21:26PM +0100, Andrew Cooper wrote: > On 20/07/17 13:57, Wei Liu wrote: > > On Thu, Jul 20, 2017 at 12:49:37PM +0100, Andrew Cooper wrote: > > > On 20/07/17 12:47, Wei Liu wrote: > > > > On Thu, Jul 20, 2017 at 12:45:38PM +0100, Roger Pau Monné wrote: > > > > > On Thu, Jul 20, 2017 at 12:35:56PM +0100, Wei Liu wrote: > > > > > > The code says it defaults to false. > > > > > > > > > > > > Signed-off-by: Wei Liu <wei.liu2@citrix.com> > > > > > > --- > > > > > > Cc: Andrew Cooper <andrew.cooper3@citrix.com> > > > > > > Cc: George Dunlap <George.Dunlap@eu.citrix.com> > > > > > > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > > > > > > Cc: Jan Beulich <jbeulich@suse.com> > > > > > > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > > > > > Cc: Stefano Stabellini <sstabellini@kernel.org> > > > > > > Cc: Tim Deegan <tim@xen.org> > > > > > > Cc: Wei Liu <wei.liu2@citrix.com> > > > > > > --- > > > > > > docs/misc/xen-command-line.markdown | 2 +- > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-command-line.markdown > > > > > > index 3f90c3b7a8..f524294aa6 100644 > > > > > > --- a/docs/misc/xen-command-line.markdown > > > > > > +++ b/docs/misc/xen-command-line.markdown > > > > > > @@ -136,7 +136,7 @@ mode during S3 resume. > > > > > > ### allowsuperpage > > > > > > > `= <boolean>` > > > > > > -> Default: `true` > > > > > > +> Default: `false` > > > > > > Permit Xen to use superpages when performing memory management. > > > > > I'm not an expert on Xen MM code, but isn't this intended for PV > > > > > guests? The description above makes it look like this is for Xen > > > > > itself, but AFAICT from skimming over the code this seems to be a PV > > > > > feature, in which case the text above should be fixed to prevent > > > > > confusion. > > > > I believe it is PV only, but I'm not 100% sure. > > > > > > > > I would love to fix the text as well if possible. > > > I'm fairly sure this option applies exclusively to PV superpages. Double > > > check the logic through the code, but I think (since dropping 32bit > > > support), we have no configuration where Xen might not be able to use > > > superpages. > > > > > So we can just delete this option and make Xen always use superpage? > > That would be fine by me, too. > > No - my point was that this option now exclusively controls PV superpages, > IIRC. > OK. I misunderstood. In that case. We can change the text to: Permit PV guests to use suerpages. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] docs: fix superpage default value 2017-07-20 12:57 ` Wei Liu 2017-07-21 16:21 ` Andrew Cooper @ 2017-07-21 16:44 ` Konrad Rzeszutek Wilk 2017-07-21 16:51 ` Wei Liu 1 sibling, 1 reply; 10+ messages in thread From: Konrad Rzeszutek Wilk @ 2017-07-21 16:44 UTC (permalink / raw) To: Wei Liu Cc: Stefano Stabellini, George Dunlap, Andrew Cooper, Tim Deegan, Jan Beulich, Xen-devel, Ian Jackson, Roger Pau Monné On Thu, Jul 20, 2017 at 01:57:17PM +0100, Wei Liu wrote: > On Thu, Jul 20, 2017 at 12:49:37PM +0100, Andrew Cooper wrote: > > On 20/07/17 12:47, Wei Liu wrote: > > > On Thu, Jul 20, 2017 at 12:45:38PM +0100, Roger Pau Monné wrote: > > > > On Thu, Jul 20, 2017 at 12:35:56PM +0100, Wei Liu wrote: > > > > > The code says it defaults to false. > > > > > > > > > > Signed-off-by: Wei Liu <wei.liu2@citrix.com> > > > > > --- > > > > > Cc: Andrew Cooper <andrew.cooper3@citrix.com> > > > > > Cc: George Dunlap <George.Dunlap@eu.citrix.com> > > > > > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > > > > > Cc: Jan Beulich <jbeulich@suse.com> > > > > > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > > > > Cc: Stefano Stabellini <sstabellini@kernel.org> > > > > > Cc: Tim Deegan <tim@xen.org> > > > > > Cc: Wei Liu <wei.liu2@citrix.com> > > > > > --- > > > > > docs/misc/xen-command-line.markdown | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-command-line.markdown > > > > > index 3f90c3b7a8..f524294aa6 100644 > > > > > --- a/docs/misc/xen-command-line.markdown > > > > > +++ b/docs/misc/xen-command-line.markdown > > > > > @@ -136,7 +136,7 @@ mode during S3 resume. > > > > > ### allowsuperpage > > > > > > `= <boolean>` > > > > > -> Default: `true` > > > > > +> Default: `false` > > > > > Permit Xen to use superpages when performing memory management. > > > > I'm not an expert on Xen MM code, but isn't this intended for PV > > > > guests? The description above makes it look like this is for Xen > > > > itself, but AFAICT from skimming over the code this seems to be a PV > > > > feature, in which case the text above should be fixed to prevent > > > > confusion. > > > I believe it is PV only, but I'm not 100% sure. > > > > > > I would love to fix the text as well if possible. > > > > I'm fairly sure this option applies exclusively to PV superpages. Double > > check the logic through the code, but I think (since dropping 32bit > > support), we have no configuration where Xen might not be able to use > > superpages. > > > > So we can just delete this option and make Xen always use superpage? > That would be fine by me, too. Can we just nuke the code altogther? Oracle is not using it anymore. > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] docs: fix superpage default value 2017-07-21 16:44 ` Konrad Rzeszutek Wilk @ 2017-07-21 16:51 ` Wei Liu 2017-07-21 17:06 ` Konrad Rzeszutek Wilk 0 siblings, 1 reply; 10+ messages in thread From: Wei Liu @ 2017-07-21 16:51 UTC (permalink / raw) To: Konrad Rzeszutek Wilk Cc: Stefano Stabellini, Wei Liu, George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan, Jan Beulich, Xen-devel, Roger Pau Monné On Fri, Jul 21, 2017 at 12:44:18PM -0400, Konrad Rzeszutek Wilk wrote: > On Thu, Jul 20, 2017 at 01:57:17PM +0100, Wei Liu wrote: > > On Thu, Jul 20, 2017 at 12:49:37PM +0100, Andrew Cooper wrote: > > > On 20/07/17 12:47, Wei Liu wrote: > > > > On Thu, Jul 20, 2017 at 12:45:38PM +0100, Roger Pau Monné wrote: > > > > > On Thu, Jul 20, 2017 at 12:35:56PM +0100, Wei Liu wrote: > > > > > > The code says it defaults to false. > > > > > > > > > > > > Signed-off-by: Wei Liu <wei.liu2@citrix.com> > > > > > > --- > > > > > > Cc: Andrew Cooper <andrew.cooper3@citrix.com> > > > > > > Cc: George Dunlap <George.Dunlap@eu.citrix.com> > > > > > > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > > > > > > Cc: Jan Beulich <jbeulich@suse.com> > > > > > > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > > > > > Cc: Stefano Stabellini <sstabellini@kernel.org> > > > > > > Cc: Tim Deegan <tim@xen.org> > > > > > > Cc: Wei Liu <wei.liu2@citrix.com> > > > > > > --- > > > > > > docs/misc/xen-command-line.markdown | 2 +- > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-command-line.markdown > > > > > > index 3f90c3b7a8..f524294aa6 100644 > > > > > > --- a/docs/misc/xen-command-line.markdown > > > > > > +++ b/docs/misc/xen-command-line.markdown > > > > > > @@ -136,7 +136,7 @@ mode during S3 resume. > > > > > > ### allowsuperpage > > > > > > > `= <boolean>` > > > > > > -> Default: `true` > > > > > > +> Default: `false` > > > > > > Permit Xen to use superpages when performing memory management. > > > > > I'm not an expert on Xen MM code, but isn't this intended for PV > > > > > guests? The description above makes it look like this is for Xen > > > > > itself, but AFAICT from skimming over the code this seems to be a PV > > > > > feature, in which case the text above should be fixed to prevent > > > > > confusion. > > > > I believe it is PV only, but I'm not 100% sure. > > > > > > > > I would love to fix the text as well if possible. > > > > > > I'm fairly sure this option applies exclusively to PV superpages. Double > > > check the logic through the code, but I think (since dropping 32bit > > > support), we have no configuration where Xen might not be able to use > > > superpages. > > > > > > > So we can just delete this option and make Xen always use superpage? > > That would be fine by me, too. > > Can we just nuke the code altogther? > > Oracle is not using it anymore. Sure! I was about to ask you about that. I'm happy to submit patches to nuke it from both the hypervisor and toolstack. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] docs: fix superpage default value 2017-07-21 16:51 ` Wei Liu @ 2017-07-21 17:06 ` Konrad Rzeszutek Wilk 0 siblings, 0 replies; 10+ messages in thread From: Konrad Rzeszutek Wilk @ 2017-07-21 17:06 UTC (permalink / raw) To: Wei Liu Cc: Stefano Stabellini, George Dunlap, Andrew Cooper, Tim Deegan, Jan Beulich, Xen-devel, Ian Jackson, Roger Pau Monné On Fri, Jul 21, 2017 at 05:51:02PM +0100, Wei Liu wrote: > On Fri, Jul 21, 2017 at 12:44:18PM -0400, Konrad Rzeszutek Wilk wrote: > > On Thu, Jul 20, 2017 at 01:57:17PM +0100, Wei Liu wrote: > > > On Thu, Jul 20, 2017 at 12:49:37PM +0100, Andrew Cooper wrote: > > > > On 20/07/17 12:47, Wei Liu wrote: > > > > > On Thu, Jul 20, 2017 at 12:45:38PM +0100, Roger Pau Monné wrote: > > > > > > On Thu, Jul 20, 2017 at 12:35:56PM +0100, Wei Liu wrote: > > > > > > > The code says it defaults to false. > > > > > > > > > > > > > > Signed-off-by: Wei Liu <wei.liu2@citrix.com> > > > > > > > --- > > > > > > > Cc: Andrew Cooper <andrew.cooper3@citrix.com> > > > > > > > Cc: George Dunlap <George.Dunlap@eu.citrix.com> > > > > > > > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > > > > > > > Cc: Jan Beulich <jbeulich@suse.com> > > > > > > > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > > > > > > Cc: Stefano Stabellini <sstabellini@kernel.org> > > > > > > > Cc: Tim Deegan <tim@xen.org> > > > > > > > Cc: Wei Liu <wei.liu2@citrix.com> > > > > > > > --- > > > > > > > docs/misc/xen-command-line.markdown | 2 +- > > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > > > diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-command-line.markdown > > > > > > > index 3f90c3b7a8..f524294aa6 100644 > > > > > > > --- a/docs/misc/xen-command-line.markdown > > > > > > > +++ b/docs/misc/xen-command-line.markdown > > > > > > > @@ -136,7 +136,7 @@ mode during S3 resume. > > > > > > > ### allowsuperpage > > > > > > > > `= <boolean>` > > > > > > > -> Default: `true` > > > > > > > +> Default: `false` > > > > > > > Permit Xen to use superpages when performing memory management. > > > > > > I'm not an expert on Xen MM code, but isn't this intended for PV > > > > > > guests? The description above makes it look like this is for Xen > > > > > > itself, but AFAICT from skimming over the code this seems to be a PV > > > > > > feature, in which case the text above should be fixed to prevent > > > > > > confusion. > > > > > I believe it is PV only, but I'm not 100% sure. > > > > > > > > > > I would love to fix the text as well if possible. > > > > > > > > I'm fairly sure this option applies exclusively to PV superpages. Double > > > > check the logic through the code, but I think (since dropping 32bit > > > > support), we have no configuration where Xen might not be able to use > > > > superpages. > > > > > > > > > > So we can just delete this option and make Xen always use superpage? > > > That would be fine by me, too. > > > > Can we just nuke the code altogther? > > > > Oracle is not using it anymore. > > Sure! I was about to ask you about that. > > I'm happy to submit patches to nuke it from both the hypervisor and toolstack. Feel free to add Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> on them :-) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-07-21 17:06 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-07-20 11:35 [PATCH] docs: fix superpage default value Wei Liu 2017-07-20 11:45 ` Roger Pau Monné 2017-07-20 11:47 ` Wei Liu 2017-07-20 11:49 ` Andrew Cooper 2017-07-20 12:57 ` Wei Liu 2017-07-21 16:21 ` Andrew Cooper 2017-07-21 16:26 ` Wei Liu 2017-07-21 16:44 ` Konrad Rzeszutek Wilk 2017-07-21 16:51 ` Wei Liu 2017-07-21 17:06 ` Konrad Rzeszutek Wilk
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).