From: Felix Schmoll <eggi.innovations@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: andrew.cooper3@citrix.com, wei.liu2@citrix.com,
Felix Schmoll <eggi.innovations@gmail.com>
Subject: [PATCH XTF v4] Implement pv_read_some
Date: Mon, 24 Jul 2017 08:24:15 +0200 [thread overview]
Message-ID: <20170724062415.1542-1-eggi.innovations@gmail.com> (raw)
Implement reading from PV console. Making use of polling.
Signed-off-by: Felix Schmoll <eggi.innovations@gmail.com>
---
Changed since v3:
* Add to comment: read function blocks if no data available
---
common/console.c | 26 ++++++++++++++++++++++++++
include/xtf/console.h | 2 ++
2 files changed, 28 insertions(+)
diff --git a/common/console.c b/common/console.c
index 7cb2361..b1a35f4 100644
--- a/common/console.c
+++ b/common/console.c
@@ -46,6 +46,32 @@ static size_t pv_console_write_some(const char *buf, size_t len)
}
/*
+ * Read out data from the pv ring, either until buffer is filled or no
+ * more data are available. Might result in partial strings, depending
+ * on how xenconsoled passes in data.
+ *
+ * Will block if no data are available.
+ */
+size_t pv_console_read_some(char *buf, size_t len)
+{
+ size_t s = 0;
+ uint32_t cons, prod;
+
+ while ( !test_and_clear_bit(pv_evtchn, shared_info.evtchn_pending) ||
+ (pv_ring->in_cons == pv_ring->in_prod) )
+ hypercall_poll(pv_evtchn);
+
+ cons = pv_ring->in_cons, prod = LOAD_ACQUIRE(&pv_ring->in_prod);
+
+ while ( (s < len) && (0 < (prod - cons)) )
+ buf[s++] = pv_ring->in[cons++ & (sizeof(pv_ring->in) - 1)];
+
+ STORE_RELEASE(&pv_ring->in_cons, cons);
+
+ return s;
+}
+
+/*
* Write some data into the pv ring, synchronously waiting for all data to be
* consumed.
*/
diff --git a/include/xtf/console.h b/include/xtf/console.h
index 2a93c06..caec790 100644
--- a/include/xtf/console.h
+++ b/include/xtf/console.h
@@ -25,6 +25,8 @@ void init_pv_console(xencons_interface_t *ring,
void vprintk(const char *fmt, va_list args) __printf(1, 0);
void printk(const char *fmt, ...) __printf(1, 2);
+size_t pv_console_read_some(char *buf, size_t len);
+
#endif /* XTF_CONSOLE_H */
/*
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next reply other threads:[~2017-07-24 6:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 6:24 Felix Schmoll [this message]
2017-07-24 9:11 ` [PATCH XTF v4] Implement pv_read_some Wei Liu
2017-07-24 10:29 ` Wei Liu
2017-07-24 10:38 ` Andrew Cooper
2017-07-25 6:58 ` Felix Schmoll
2017-07-25 7:00 ` Felix Schmoll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170724062415.1542-1-eggi.innovations@gmail.com \
--to=eggi.innovations@gmail.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).