From: Wei Liu <wei.liu2@citrix.com>
To: Petre Pircalabu <ppircalabu@bitdefender.com>
Cc: elena.ufimtseva@oracle.com, tamas@tklengyel.com,
wei.liu2@citrix.com, rcojocaru@bitdefender.com,
george.dunlap@eu.citrix.com, ian.jackson@eu.citrix.com,
dave@recoil.org, tim@xen.org, marmarek@invisiblethingslab.com,
andrew.cooper3@citrix.com, jbeulich@suse.com,
samuel.thibault@ens-lyon.org, xen-devel@lists.xenproject.org,
dgdegra@tycho.nsa.gov
Subject: Re: [PATCH] Makefile: Fix uninstall target
Date: Fri, 28 Jul 2017 16:21:49 +0100 [thread overview]
Message-ID: <20170728152149.7druunvh2bf4n2ff@citrix.com> (raw)
In-Reply-To: <1501175307-4939-1-git-send-email-ppircalabu@bitdefender.com>
On Thu, Jul 27, 2017 at 08:08:27PM +0300, Petre Pircalabu wrote:
> Running "make uninstall" does not remove all installed files, a
> situation which might cause link related issues if xen is re-installed
> in a different location.
> In order to make uninstall correctly remove the files it is best
> the process should be done recursively by mirroring each "install"
> target with an "uninstall" who removes the installed files.
>
> An exception to this rule is uninstalling the files produced by
> "qemu-xen-dir-remote" and "qemu-xen-traditional-dir", which are external
> to the project. These projects do not implement an "uninstall" target so
> the files have to be removed manually.
>
> Signed-off-by: Petre Pircalabu <ppircalabu@bitdefender.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
AFAICT this patch adds a bunch of uninstall targets, which shouldn't
break existing code.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-07-28 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 17:08 [PATCH] Makefile: Fix uninstall target Petre Pircalabu
2017-07-28 15:21 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170728152149.7druunvh2bf4n2ff@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=dave@recoil.org \
--cc=dgdegra@tycho.nsa.gov \
--cc=elena.ufimtseva@oracle.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=marmarek@invisiblethingslab.com \
--cc=ppircalabu@bitdefender.com \
--cc=rcojocaru@bitdefender.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=tamas@tklengyel.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).