Re: [PATCH v2 2/2] xl: Register the AER event handler to handle AER errors.

[Venu Busireddy <venu.busireddy@oracle.com>]

On 2017-07-28 16:58:16 +0100, Wei Liu wrote:
> On Wed, Jul 26, 2017 at 07:16:39PM -0500, Venu Busireddy wrote:
> > When a guest is created, register the AER event handler to handle the
> > AER errors. When an AER error occurs, the handler will forcibly remove
> > the erring PCIe device from the guest.
> > 
> > Signed-off-by: Venu Busireddy <venu.busireddy@oracle.com>
> > ---
> >  tools/xl/xl_vmcontrol.c | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c
> > index 89c2b25..10a48a9 100644
> > --- a/tools/xl/xl_vmcontrol.c
> > +++ b/tools/xl/xl_vmcontrol.c
> > @@ -966,6 +966,15 @@ start:
> >      LOG("Waiting for domain %s (domid %u) to die [pid %ld]",
> >          d_config.c_info.name, domid, (long)getpid());
> >  
> > +    ret = libxl_reg_aer_events_handler(ctx, domid);
> > +    if (ret) {
> > +        /*
> > +         * This error may not be severe enough to fail the creation of the VM.
> > +         * Log the error, and continue with the creation.
> > +         */
> 
> What does this comment mean? This is called after the guest is created,
> right?

Maybe too many words. I can change it as:

/* Log the error, and move on...  */

Is that okay?

Venu


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel