From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH] libxl: do not start dom0 qemu for stubdomain when not needed Date: Fri, 28 Jul 2017 18:29:32 +0200 Message-ID: <20170728162932.GR1095@mail-itl> References: <1501109065-8022-1-git-send-email-marmarek@invisiblethingslab.com> <20170728151750.5ksd6hpl7ij65phu@citrix.com> <20170728160513.GQ1095@mail-itl> <20170728161226.bv3smti3mwucjyuy@citrix.com> <22907.25480.717848.777692@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2132734719581470196==" Return-path: In-Reply-To: <22907.25480.717848.777692@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Ian Jackson Cc: Wei Liu , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============2132734719581470196== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kCMc/XPzzbnOIvDj" Content-Disposition: inline --kCMc/XPzzbnOIvDj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 28, 2017 at 05:17:12PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH] libxl: do not start dom0 qemu for stubdomain= when not needed"): > > On Fri, Jul 28, 2017 at 06:05:13PM +0200, Marek Marczykowski-G=C3=B3rec= ki wrote: > > > On Fri, Jul 28, 2017 at 04:17:51PM +0100, Wei Liu wrote: > > > > On Thu, Jul 27, 2017 at 12:44:25AM +0200, Marek Marczykowski-G=C3= =B3recki wrote: > > > > > + if (libxl_defbool_val(guest_config->b_info.u.hvm.vnc.enable)= || > > > > > + libxl_defbool_val(guest_config->b_info.u.hvm.spice.e= nable) || > > > > > + libxl_defbool_val(guest_config->b_info.u.hvm.sdl.ena= ble)) { > > > >=20 > > > > Indentation. > > >=20 > > > Should it really be indented at the same level as the code inside this > > > block? Looks misleading (you need to look for ") {" to see where > > > condition ends). > >=20 > > That's how existing code in libxl is like, isn't it? >=20 > Yes. Sadly. >=20 > If you like we could have a bunfight about changing the indent level. > I like 2, personally :-P. >=20 > A compromise might be to move the || to the start of the next line, so >=20 > if (cond1 > || cond2 > || cond3) { > code1; > code2; >=20 > I have done that sometimes in libxl and no-one has objected. Ok, it would be much better, thanks. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? --kCMc/XPzzbnOIvDj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJZe2ZtAAoJENuP0xzK19cs8JkH/A484DsgCPQ5bBsZJ+qKBtNT y11/IKsVqQJiNeFaGLdCzhmAjK8fwKu9pqNvwA1GyJ3lboMxJfbPTOBroklcfmuU OUGQIB91buQg40XD3gsYfpRWRLahMJo/qF0U02MF5BuCcpBx0ToUYzBkpZWX9lzh LkRgG93JMFW5axIRi9/+QZtl+/2qHOy1znB6iKXUnpS+exAtS3ZhrbxH6YEEytq2 MM7Doh9SR8jCpDI5kdYw3Ig8IlRGIC7G1YXl9pN+76h3RwEYJx4tLq8/TzF0CO30 LnMjdE8kGqjxGACuo/qPZpkM6sBUCkG1/Za3iyiZsZZ1926g0jhwldyGq8+iKYc= =o3zK -----END PGP SIGNATURE----- --kCMc/XPzzbnOIvDj-- --===============2132734719581470196== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============2132734719581470196==--