* [PATCH v2] xl: add --clear option to dmesg command
@ 2017-08-01 15:57 Xiao Liang
2017-08-01 16:10 ` Wei Liu
0 siblings, 1 reply; 6+ messages in thread
From: Xiao Liang @ 2017-08-01 15:57 UTC (permalink / raw)
To: wei.liu2; +Cc: xiliang, ian.jackson, xen-devel
From: xiliang <xiliang@redhat.com>
The manual of xl says --clear option is supported and that option worked for xm. Add that to xl now.
Signed-off-by: xiliang <xiliang@redhat.com>
---
tools/xl/xl_info.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
index 94bd1fd9ab..e9890ca5f2 100644
--- a/tools/xl/xl_info.c
+++ b/tools/xl/xl_info.c
@@ -884,8 +884,12 @@ int main_dmesg(int argc, char **argv)
libxl_xen_console_reader *cr;
char *line;
int opt, ret = 1;
+ static struct option opts[] = {
+ {"clear", 0, 0, 'c'},
+ COMMON_LONG_OPTS
+ };
- SWITCH_FOREACH_OPT(opt, "c", NULL, "dmesg", 0) {
+ SWITCH_FOREACH_OPT(opt, "c", opts, "dmesg", 0) {
case 'c':
clear = 1;
break;
--
2.13.3
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] xl: add --clear option to dmesg command
2017-08-01 15:57 [PATCH v2] xl: add --clear option to dmesg command Xiao Liang
@ 2017-08-01 16:10 ` Wei Liu
2017-08-04 10:57 ` Wei Liu
0 siblings, 1 reply; 6+ messages in thread
From: Wei Liu @ 2017-08-01 16:10 UTC (permalink / raw)
To: Xiao Liang; +Cc: ian.jackson, wei.liu2, xen-devel
On Tue, Aug 01, 2017 at 11:57:50PM +0800, Xiao Liang wrote:
> From: xiliang <xiliang@redhat.com>
>
> The manual of xl says --clear option is supported and that option worked for xm. Add that to xl now.
I will wrap this long line to 72 columns while committing.
>
> Signed-off-by: xiliang <xiliang@redhat.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] xl: add --clear option to dmesg command
2017-08-01 16:10 ` Wei Liu
@ 2017-08-04 10:57 ` Wei Liu
2017-08-04 11:05 ` Wei Liu
0 siblings, 1 reply; 6+ messages in thread
From: Wei Liu @ 2017-08-04 10:57 UTC (permalink / raw)
To: Xiao Liang; +Cc: ian.jackson, wei.liu2, xen-devel
On Tue, Aug 01, 2017 at 05:10:27PM +0100, Wei Liu wrote:
> On Tue, Aug 01, 2017 at 11:57:50PM +0800, Xiao Liang wrote:
> > From: xiliang <xiliang@redhat.com>
> >
> > The manual of xl says --clear option is supported and that option worked for xm. Add that to xl now.
>
> I will wrap this long line to 72 columns while committing.
>
> >
> > Signed-off-by: xiliang <xiliang@redhat.com>
I was about to commit this, but I realised "xiliang" as your name seems
wrong. Should it be "Xi Liang" instead?
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] xl: add --clear option to dmesg command
2017-08-04 10:57 ` Wei Liu
@ 2017-08-04 11:05 ` Wei Liu
2017-08-04 14:34 ` Xiao Liang
0 siblings, 1 reply; 6+ messages in thread
From: Wei Liu @ 2017-08-04 11:05 UTC (permalink / raw)
To: Xiao Liang; +Cc: ian.jackson, wei.liu2, xen-devel
On Fri, Aug 04, 2017 at 11:57:53AM +0100, Wei Liu wrote:
> On Tue, Aug 01, 2017 at 05:10:27PM +0100, Wei Liu wrote:
> > On Tue, Aug 01, 2017 at 11:57:50PM +0800, Xiao Liang wrote:
> > > From: xiliang <xiliang@redhat.com>
> > >
> > > The manual of xl says --clear option is supported and that option worked for xm. Add that to xl now.
> >
> > I will wrap this long line to 72 columns while committing.
> >
> > >
> > > Signed-off-by: xiliang <xiliang@redhat.com>
>
> I was about to commit this, but I realised "xiliang" as your name seems
> wrong. Should it be "Xi Liang" instead?
I think it should be "Xiao Liang" because that is what is in your email
handle.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] xl: add --clear option to dmesg command
2017-08-04 11:05 ` Wei Liu
@ 2017-08-04 14:34 ` Xiao Liang
2017-08-04 14:35 ` Wei Liu
0 siblings, 1 reply; 6+ messages in thread
From: Xiao Liang @ 2017-08-04 14:34 UTC (permalink / raw)
To: Wei Liu; +Cc: ian.jackson, xen-devel
Yes, the full name is "Xiao Liang". Thanks :)
On 08/04/2017 07:05 PM, Wei Liu wrote:
> On Fri, Aug 04, 2017 at 11:57:53AM +0100, Wei Liu wrote:
>> On Tue, Aug 01, 2017 at 05:10:27PM +0100, Wei Liu wrote:
>>> On Tue, Aug 01, 2017 at 11:57:50PM +0800, Xiao Liang wrote:
>>>> From: xiliang <xiliang@redhat.com>
>>>>
>>>> The manual of xl says --clear option is supported and that option worked for xm. Add that to xl now.
>>> I will wrap this long line to 72 columns while committing.
>>>
>>>> Signed-off-by: xiliang <xiliang@redhat.com>
>> I was about to commit this, but I realised "xiliang" as your name seems
>> wrong. Should it be "Xi Liang" instead?
> I think it should be "Xiao Liang" because that is what is in your email
> handle.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] xl: add --clear option to dmesg command
2017-08-04 14:34 ` Xiao Liang
@ 2017-08-04 14:35 ` Wei Liu
0 siblings, 0 replies; 6+ messages in thread
From: Wei Liu @ 2017-08-04 14:35 UTC (permalink / raw)
To: Xiao Liang; +Cc: ian.jackson, Wei Liu, xen-devel
On Fri, Aug 04, 2017 at 10:34:18PM +0800, Xiao Liang wrote:
> Yes, the full name is "Xiao Liang". Thanks :)
>
Cool, thanks for confirming. I will push your patch shortly.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-04 14:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-01 15:57 [PATCH v2] xl: add --clear option to dmesg command Xiao Liang
2017-08-01 16:10 ` Wei Liu
2017-08-04 10:57 ` Wei Liu
2017-08-04 11:05 ` Wei Liu
2017-08-04 14:34 ` Xiao Liang
2017-08-04 14:35 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).