From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: [PATCH OSSTEST v3 2/8] mfi-common: move set_freebsd_runvars to mfi-common
Date: Wed, 2 Aug 2017 12:52:15 +0100 [thread overview]
Message-ID: <20170802115221.29116-3-roger.pau@citrix.com> (raw)
In-Reply-To: <20170802115221.29116-1-roger.pau@citrix.com>
So that it can also be used by make-hosts-flight. No functional change
intended.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
make-freebsd-flight | 31 -------------------------------
mfi-common | 31 +++++++++++++++++++++++++++++++
2 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/make-freebsd-flight b/make-freebsd-flight
index 64dfe9a6..72695742 100755
--- a/make-freebsd-flight
+++ b/make-freebsd-flight
@@ -36,37 +36,6 @@ job_create_build_filter_callback () {
:
}
-set_freebsd_runvars () {
- # Caller should have done if required:
- # local freebsd_runvars
- #
- # Figure out where are the installer binaries. The order is the
- # following:
- #
- # 1. Env variable FREEBSD_<arch>_BUILDJOB: use the output from a
- # previous build-<arch>-freebsd.
- #
- # 2. Env variables FREEBSD_DIST, FREEBSD_VERSION: set before calling
- # into make-flight, provide the path to the installer image, the sets
- # to install and the version being installed.
- #
- # 3. Config file FreeBSDDist, FreeBSDVersion: same as 2. except that
- # they are set on the config file.
- #
- envvar="FREEBSD_${arch^^}_BUILDJOB"
- if [ -n "${!envvar}" ]; then
- freebsd_runvars="freebsdbuildjob=${!envvar}"
- elif [ -n "$FREEBSD_DIST" ] && [ -n "$FREEBSD_VERSION" ]; then
- freebsd_runvars="freebsd_distpath=$FREEBSD_DIST/$arch \
- freebsd_version=$FREEBSD_VERSION"
- else
- distpath=`getconfig "FreeBSDDist"`
- version=`getconfig "FreeBSDVersion"`
- freebsd_runvars="freebsd_distpath=$distpath/$arch \
- freebsd_version=$version"
- fi
-}
-
for arch in "$arches"; do
set_freebsd_runvars
job_create_build build-$arch-freebsd build-freebsd \
diff --git a/mfi-common b/mfi-common
index 4827c827..8a9546ab 100644
--- a/mfi-common
+++ b/mfi-common
@@ -113,6 +113,37 @@ set_hostos_runvars () {
esac
}
+set_freebsd_runvars () {
+ # Caller should have done if required:
+ # local freebsd_runvars
+ #
+ # Figure out where are the installer binaries. The order is the
+ # following:
+ #
+ # 1. Env variable FREEBSD_<arch>_BUILDJOB: use the output from a
+ # previous build-<arch>-freebsd.
+ #
+ # 2. Env variables FREEBSD_DIST, FREEBSD_VERSION: set before calling
+ # into make-flight, provide the path to the installer image, the sets
+ # to install and the version being installed.
+ #
+ # 3. Config file FreeBSDDist, FreeBSDVersion: same as 2. except that
+ # they are set on the config file.
+ #
+ local envvar="FREEBSD_${arch^^}_BUILDJOB"
+ if [ -n "${!envvar}" ]; then
+ freebsd_runvars="freebsdbuildjob=${!envvar}"
+ elif [ -n "$FREEBSD_DIST" ] && [ -n "$FREEBSD_VERSION" ]; then
+ freebsd_runvars="freebsd_distpath=$FREEBSD_DIST/$arch \
+ freebsd_version=$FREEBSD_VERSION"
+ else
+ local distpath=`getconfig "FreeBSDDist"`
+ local version=`getconfig "FreeBSDVersion"`
+ freebsd_runvars="freebsd_distpath=$distpath/$arch \
+ freebsd_version=$version"
+ fi
+}
+
create_build_jobs () {
local arch
--
2.11.0 (Apple Git-81)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-08-02 11:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 11:52 [PATCH OSSTEST v3 0/8] Add support to examine the needed memdisk flags for each hos Roger Pau Monne
2017-08-02 11:52 ` [PATCH OSSTEST v3 1/8] HostDB: introduce set_property Roger Pau Monne
2017-08-02 11:52 ` Roger Pau Monne [this message]
2017-08-02 11:52 ` [PATCH OSSTEST v3 3/8] TestSupport: introduce hostprop_putative_record Roger Pau Monne
2017-08-02 11:52 ` [PATCH OSSTEST v3 4/8] ts-freebsd-host-install: add arguments to test memdisk append options Roger Pau Monne
2017-08-02 11:52 ` [PATCH OSSTEST v3 5/8] ts-memdisk-try-append: introduce a script to test memdisk options Roger Pau Monne
2017-08-02 11:52 ` [PATCH OSSTEST v3 6/8] ts-examine-hostprops-save: introduce a script to save properties Roger Pau Monne
2017-08-02 11:52 ` [PATCH OSSTEST v3 7/8] make-hosts-flight: set runvars for FreeBSD test Roger Pau Monne
2017-08-02 11:52 ` [PATCH OSSTEST v3 8/8] sg-run-job: hook the memdisk test into examine Roger Pau Monne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802115221.29116-3-roger.pau@citrix.com \
--to=roger.pau@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).