From: Olaf Hering <olaf@aepfle.de>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v2 3/3] tools/libxc: use superpages during restore of HVM guest
Date: Wed, 23 Aug 2017 15:44:30 +0200 [thread overview]
Message-ID: <20170823134430.GD6372@aepfle.de> (raw)
In-Reply-To: <20170823103339.pl3fq7bh46awiuwu@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 1101 bytes --]
On Wed, Aug 23, Wei Liu wrote:
> On Tue, Aug 22, 2017 at 05:53:25PM +0200, Olaf Hering wrote:
> > In my testing I have seen the case of over-allocation. Thats why I
> > implemented the freeing of unpopulated parts. It would be nice to know
> > how many pages are actually coming. I think this info is not available.
> Not sure I follow. What do you mean by "how many pages are actually
> coming"?
This meant the expected number of pages to populate.
The value of p2m_size does not represent the actual number of pages
assigned to a domU. This info is stored in getdomaininfo.max_pages,
which is currently not used by restore. I will see if using this value
will avoid triggering the Over-allocation check.
> > On the other side, the first iteration sends the pfns linear. This is
> > when the allocation actually happens. So the over-allocation will only
> > trigger near the end, if a 1G range is allocated but only a few pages
> > will be stored into this range.
> This could be making too many assumptions on the data stream.
With the usage of max_pages some assumptions can be avoided.
Olaf
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-08-23 13:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 17:01 [PATCH v2 0/3] tools/libxc: use superpages Olaf Hering
2017-08-17 17:01 ` [PATCH v2 1/3] tools/libxc: move SUPERPAGE macros to common header Olaf Hering
2017-08-22 14:23 ` Wei Liu
2017-08-17 17:01 ` [PATCH v2 2/3] tools/libxc: add API for bitmap access for restore Olaf Hering
2017-08-22 14:34 ` Wei Liu
2017-08-22 15:01 ` Wei Liu
2017-08-24 6:36 ` Olaf Hering
2017-08-24 11:13 ` Wei Liu
2017-08-17 17:01 ` [PATCH v2 3/3] tools/libxc: use superpages during restore of HVM guest Olaf Hering
2017-08-22 15:31 ` Wei Liu
2017-08-22 15:53 ` Olaf Hering
2017-08-23 8:05 ` Olaf Hering
2017-08-23 10:33 ` Wei Liu
2017-08-23 10:33 ` Wei Liu
2017-08-23 13:44 ` Olaf Hering [this message]
2017-08-23 14:32 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170823134430.GD6372@aepfle.de \
--to=olaf@aepfle.de \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).