From: Olaf Hering <olaf@aepfle.de>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v3 3/3] tools/libxc: use superpages during restore of HVM guest
Date: Fri, 25 Aug 2017 16:00:15 +0200 [thread overview]
Message-ID: <20170825140015.GO6372@aepfle.de> (raw)
In-Reply-To: <20170825133604.tyjebwqdt5kuuiti@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 663 bytes --]
On Fri, Aug 25, Wei Liu wrote:
> Maybe a middle ground is to scan the batch to see if pfns can be fit
> into a whole super page? I don't think you can get a batch as big as 1G
> but there should be a lot of 2M batches?
I think with the new check of max_pages an overallocation can not happen
anymore. If at some point the domU still has room for a superpage, it
will be allocated. In case the batch does not fully fill the superpage,
the holes will be freed. In the next batch no superpage can be allocated
anymore, but single pages will be used.
This punching of holes might be inefficent, the win is the usage of
superpages in case of contiguous pfns.
Olaf
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-08-25 14:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 10:14 [PATCH v3 0/3] tools/libxc: use superpages Olaf Hering
2017-08-24 10:14 ` [PATCH v3 1/3] tools/libxc: move SUPERPAGE macros to common header Olaf Hering
2017-08-25 12:06 ` Wei Liu
2017-08-24 10:14 ` [PATCH v3 2/3] tools/libxc: add API for bitmap access for restore Olaf Hering
2017-08-25 12:06 ` Wei Liu
2017-08-24 10:14 ` [PATCH v3 3/3] tools/libxc: use superpages during restore of HVM guest Olaf Hering
2017-08-25 12:06 ` Wei Liu
2017-08-25 12:51 ` Olaf Hering
2017-08-25 13:36 ` Wei Liu
2017-08-25 14:00 ` Olaf Hering [this message]
2017-08-25 14:51 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825140015.GO6372@aepfle.de \
--to=olaf@aepfle.de \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).