From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v5 07/15] xen/common/kexec.c: remove custom_param() error messages
Date: Mon, 28 Aug 2017 09:34:42 +0200 [thread overview]
Message-ID: <20170828073450.12024-8-jgross@suse.com> (raw)
In-Reply-To: <20170828073450.12024-1-jgross@suse.com>
With _cmdline_parse() now issuing error messages in case of illegal
parameters signalled by parsing functions specified in custom_param()
some messages issued by parse_low_crashinfo() and
parse_crashinfo_maxaddr() can be removed.
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
xen/common/kexec.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/xen/common/kexec.c b/xen/common/kexec.c
index fcc68bd4d8..e0f1e3eafa 100644
--- a/xen/common/kexec.c
+++ b/xen/common/kexec.c
@@ -213,7 +213,6 @@ static int __init parse_low_crashinfo(const char *str)
low_crashinfo_mode = LOW_CRASHINFO_ALL;
else
{
- printk("Unknown low_crashinfo parameter '%s'. Defaulting to min.\n", str);
low_crashinfo_mode = LOW_CRASHINFO_MIN;
return -EINVAL;
}
@@ -240,11 +239,7 @@ static int __init parse_crashinfo_maxaddr(const char *str)
if ( (addr = parse_size_and_unit(str, &q)) )
crashinfo_maxaddr = addr;
else
- {
- printk("Unable to parse crashinfo_maxaddr. Defaulting to %"PRIpaddr"\n",
- crashinfo_maxaddr);
return -EINVAL;
- }
return *q ? -EINVAL : 0;
}
--
2.12.3
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-08-28 7:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 7:34 [PATCH v5 00/15] Support for modifying parameters at runtime Juergen Gross
2017-08-28 7:34 ` [PATCH v5 01/15] xen/arch/x86/psr.c: let custom parameter parsing routines return errno Juergen Gross
2017-08-28 8:40 ` Jan Beulich
2017-08-28 7:34 ` [PATCH v5 02/15] xen: check parameter validity when parsing command line Juergen Gross
2017-08-28 7:34 ` [PATCH v5 03/15] xen/arch/x86/apic.c: remove custom_param() error messages Juergen Gross
2017-08-28 7:34 ` [PATCH v5 04/15] xen/arch/x86/cpu/mcheck/mce.c: " Juergen Gross
2017-08-28 7:34 ` [PATCH v5 05/15] xen/arch/x86/hvm/viridian.c: " Juergen Gross
2017-08-28 7:34 ` [PATCH v5 06/15] xen/arch/x86/io_apic.c: " Juergen Gross
2017-08-28 7:34 ` Juergen Gross [this message]
2017-08-28 7:34 ` [PATCH v5 08/15] xen/common/sched_credit2.c: " Juergen Gross
2017-08-28 7:34 ` [PATCH v5 09/15] xen: carve out a generic parsing function from _cmdline_parse() Juergen Gross
2017-08-28 7:34 ` [PATCH v5 10/15] xen: add basic support for runtime parameter changing Juergen Gross
2017-08-28 7:34 ` [PATCH v5 11/15] xen: add hypercall for setting parameters at runtime Juergen Gross
2017-08-28 7:34 ` [PATCH v5 12/15] libxc: add function to set hypervisor parameters Juergen Gross
2017-08-28 7:34 ` [PATCH v5 13/15] libxl: add libxl_set_parameters() function Juergen Gross
2017-08-28 7:34 ` [PATCH v5 14/15] xl: add new xl command set-parameters Juergen Gross
2017-08-28 7:34 ` [PATCH v5 15/15] xen: make some console related parameters settable at runtime Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828073450.12024-8-jgross@suse.com \
--to=jgross@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).