From: Yi Sun <yi.y.sun@linux.intel.com>
To: "Roger Pau Monn�" <roger.pau@citrix.com>
Cc: kevin.tian@intel.com, wei.liu2@citrix.com,
andrew.cooper3@citrix.com, dario.faggioli@citrix.com,
ian.jackson@eu.citrix.com, julien.grall@arm.com,
mengxu@cis.upenn.edu, jbeulich@suse.com,
chao.p.peng@linux.intel.com, xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 08/15] tools: create general interfaces to support psr allocation features
Date: Mon, 4 Sep 2017 10:09:48 +0800 [thread overview]
Message-ID: <20170904020948.GN23665@yi.y.sun> (raw)
In-Reply-To: <20170831083745.yk5z7l7zotan74a2@MacBook-Pro-de-Roger.local>
On 17-08-31 09:37:45, Roger Pau Monn� wrote:
> On Thu, Aug 31, 2017 at 10:38:46AM +0800, Yi Sun wrote:
> > On 17-08-30 09:42:56, Roger Pau Monn� wrote:
> > > On Thu, Aug 24, 2017 at 09:14:42AM +0800, Yi Sun wrote:
> > > > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> > > > index 6e80d36..ab847f8 100644
> > > > --- a/tools/libxl/libxl_types.idl
> > > > +++ b/tools/libxl/libxl_types.idl
> > > > @@ -977,6 +977,7 @@ libxl_psr_cbm_type = Enumeration("psr_cbm_type", [
> > > > (2, "L3_CBM_CODE"),
> > > > (3, "L3_CBM_DATA"),
> > > > (4, "L2_CBM"),
> > > > + (5, "MBA_THRTL"),
> > >
> > > Is this really a CBM type?
> > >
> > This is not CBM type. The 'libxl_psr_cbm_type' name is not good enough. But I
> > have to introduce a new generic interface here if we want to make the name be
> > generic. I think it is not so valuable. So, I reuse the 'libxl_psr_cbm_type'
> > to cover MBA. How do you think?
>
> Maybe you could introduce a new typedef, so that old code call still
> work, ie:
>
> typedef enum libxl_psr_cbm_type libxl_psr_type;
>
Is there a way in '.idl' to make such 'typedef'? Thanks!
> (Or whatever name you find suitable).
>
> Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-09-04 2:10 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 1:14 [PATCH v2 00/15] Enable Memory Bandwidth Allocation in Xen Yi Sun
2017-08-24 1:14 ` [PATCH v2 01/15] docs: create Memory Bandwidth Allocation (MBA) feature document Yi Sun
2017-08-29 11:46 ` Roger Pau Monné
2017-08-30 5:20 ` Yi Sun
2017-08-30 7:42 ` Roger Pau Monn�
2017-08-24 1:14 ` [PATCH v2 02/15] Rename PSR sysctl/domctl interfaces and xsm policy to make them be general Yi Sun
2017-08-29 12:00 ` Roger Pau Monné
2017-08-30 5:23 ` Yi Sun
2017-08-30 7:47 ` Roger Pau Monn�
2017-08-30 8:14 ` Yi Sun
2017-08-24 1:14 ` [PATCH v2 03/15] x86: rename 'cbm_type' to 'psr_val_type' to make it general Yi Sun
2017-08-29 12:15 ` Roger Pau Monné
2017-08-30 5:47 ` Yi Sun
2017-08-30 7:51 ` Roger Pau Monn�
2017-08-30 8:14 ` Yi Sun
2017-08-24 1:14 ` [PATCH v2 04/15] x86: implement data structure and CPU init flow for MBA Yi Sun
2017-08-29 13:44 ` Roger Pau Monné
2017-08-29 13:58 ` Jan Beulich
2017-08-30 6:07 ` Yi Sun
2017-08-30 5:31 ` Yi Sun
2017-08-30 7:55 ` Roger Pau Monn�
2017-08-30 8:19 ` Yi Sun
2017-08-30 8:45 ` Jan Beulich
2017-08-24 1:14 ` [PATCH v2 05/15] x86: implement get hw info " Yi Sun
2017-08-29 15:01 ` Roger Pau Monné
2017-08-30 5:33 ` Yi Sun
2017-08-24 1:14 ` [PATCH v2 06/15] x86: implement get value interface " Yi Sun
2017-08-29 15:04 ` Roger Pau Monné
2017-08-24 1:14 ` [PATCH v2 07/15] x86: implement set value flow " Yi Sun
2017-08-30 8:31 ` Roger Pau Monné
2017-08-31 2:20 ` Yi Sun
2017-08-31 8:30 ` Roger Pau Monn�
2017-08-31 9:13 ` Yi Sun
2017-08-31 9:30 ` Roger Pau Monn�
2017-08-31 10:10 ` Yi Sun
2017-08-31 10:19 ` Roger Pau Monn�
2017-08-24 1:14 ` [PATCH v2 08/15] tools: create general interfaces to support psr allocation features Yi Sun
2017-08-30 8:42 ` Roger Pau Monné
2017-08-31 2:38 ` Yi Sun
2017-08-31 8:37 ` Roger Pau Monn�
2017-09-04 2:09 ` Yi Sun [this message]
2017-09-04 8:43 ` Wei Liu
2017-08-24 1:14 ` [PATCH v2 09/15] tools: implement the new libxc get hw info interface Yi Sun
2017-08-30 8:58 ` Roger Pau Monné
2017-08-31 3:05 ` Yi Sun
2017-08-24 1:14 ` [PATCH v2 10/15] tools: implement the new libxl " Yi Sun
2017-08-30 9:15 ` Roger Pau Monné
2017-08-31 3:16 ` Yi Sun
2017-08-31 8:40 ` Roger Pau Monn�
2017-08-31 9:19 ` Yi Sun
2017-08-31 9:32 ` Roger Pau Monn�
2017-08-31 10:11 ` Yi Sun
2017-08-24 1:14 ` [PATCH v2 11/15] tools: implement the new xl " Yi Sun
2017-08-30 9:23 ` Roger Pau Monné
2017-08-31 5:57 ` Yi Sun
2017-08-31 8:43 ` Roger Pau Monn�
2017-08-31 9:24 ` Yi Sun
2017-08-24 1:14 ` [PATCH v2 12/15] tools: rename 'xc_psr_cat_type' to 'xc_psr_val_type' Yi Sun
2017-08-30 9:24 ` Roger Pau Monné
2017-08-24 1:14 ` [PATCH v2 13/15] tools: implement new generic get value interface and MBA get value command Yi Sun
2017-08-24 1:14 ` [PATCH v2 14/15] tools: implement new generic set value interface and MBA set " Yi Sun
2017-08-30 9:47 ` Roger Pau Monné
2017-08-31 5:58 ` Yi Sun
2017-08-24 1:14 ` [PATCH v2 15/15] docs: add MBA description in docs Yi Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904020948.GN23665@yi.y.sun \
--to=yi.y.sun@linux.intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=chao.p.peng@linux.intel.com \
--cc=dario.faggioli@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=kevin.tian@intel.com \
--cc=mengxu@cis.upenn.edu \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).