From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH v9 3/3] tools/libxc: use superpages during restore of HVM guest Date: Wed, 6 Sep 2017 12:34:10 +0100 Message-ID: <20170906113410.2upxmdambiwzvk5g@citrix.com> References: <20170901160843.9057-1-olaf@aepfle.de> <20170901160843.9057-4-olaf@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170901160843.9057-4-olaf@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Olaf Hering Cc: Andrew Cooper , Ian Jackson , Wei Liu , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBTZXAgMDEsIDIwMTcgYXQgMDY6MDg6NDNQTSArMDIwMCwgT2xhZiBIZXJpbmcgd3Jv dGU6ClsuLi5dCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhjL3hjX3NyX2NvbW1vbi5oIGIvdG9v bHMvbGlieGMveGNfc3JfY29tbW9uLmgKPiBpbmRleCA3MzQzMjA5NDdhLi45MzE0MWE2ZTI1IDEw MDY0NAo+IC0tLSBhL3Rvb2xzL2xpYnhjL3hjX3NyX2NvbW1vbi5oCj4gKysrIGIvdG9vbHMvbGli eGMveGNfc3JfY29tbW9uLmgKPiBAQCAtMTM5LDYgKzEzOSwxNiBAQCBzdHJ1Y3QgeGNfc3JfcmVz dG9yZV9vcHMKPiAgICAgICAqLwo+ICAgICAgaW50ICgqc2V0dXApKHN0cnVjdCB4Y19zcl9jb250 ZXh0ICpjdHgpOwo+ICAKPiArICAgIC8qKgo+ICsgICAgICogUG9wdWxhdGUgUEZOcwo+ICsgICAg ICoKPiArICAgICAqIEdpdmVuIGEgc2V0IG9mIHBmbnMsIG9idGFpbiBtZW1vcnkgZnJvbSBYZW4g dG8gZmlsbCB0aGUgcGh5c21hcCBmb3IgdGhlCj4gKyAgICAgKiB1bnBvcHVsYXRlZCBzdWJzZXQu Cj4gKyAgICAgKi8KPiArICAgIGludCAoKnBvcHVsYXRlX3BmbnMpKHN0cnVjdCB4Y19zcl9jb250 ZXh0ICpjdHgsIHVuc2lnbmVkIGNvdW50LAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgY29u c3QgeGVuX3Bmbl90ICpvcmlnaW5hbF9wZm5zLCBjb25zdCB1aW50MzJfdCAqdHlwZXMpOwo+ICsK Ck9uZSBibGFuayBsaW5lIGlzIGdvb2QgZW5vdWdoLgoKPiArCj4gICAgICAvKioKPiAgICAgICAq IFByb2Nlc3MgYW4gaW5kaXZpZHVhbCByZWNvcmQgZnJvbSB0aGUgc3RyZWFtLiAgVGhlIGNhbGxl ciBzaGFsbCB0YWtlCj4gICAgICAgKiBjYXJlIG9mIHByb2Nlc3NpbmcgY29tbW9uIHJlY29yZHMg KGUuZy4gRU5ELCBQQUdFX0RBVEEpLgo+IEBAIC0yMjQsNiArMjM0LDggQEAgc3RydWN0IHhjX3Ny X2NvbnRleHQKPiAgCj4gICAgICAgICAgICAgIGludCBzZW5kX2JhY2tfZmQ7Cj4gICAgICAgICAg ICAgIHVuc2lnbmVkIGxvbmcgcDJtX3NpemU7Cj4gKyAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcg bWF4X3BhZ2VzOwo+ICsgICAgICAgICAgICB1bnNpZ25lZCBsb25nIHRvdF9wYWdlczsKPiAgICAg ICAgICAgICAgeGNfaHlwZXJjYWxsX2J1ZmZlcl90IGRpcnR5X2JpdG1hcF9oYnVmOwo+ICAKPiAg ICAgICAgICAgICAgLyogRnJvbSBJbWFnZSBIZWFkZXIuICovCj4gQEAgLTMzNiw2ICszNDgsMTIg QEAgc3RydWN0IHhjX3NyX2NvbnRleHQKPiAgICAgICAgICAgICAgICAgICAgICAvKiBIVk0gY29u dGV4dCBibG9iLiAqLwo+ICAgICAgICAgICAgICAgICAgICAgIHZvaWQgKmNvbnRleHQ7Cj4gICAg ICAgICAgICAgICAgICAgICAgc2l6ZV90IGNvbnRleHRzejsKPiArCj4gKyAgICAgICAgICAgICAg ICAgICAgLyogQml0bWFwIG9mIGN1cnJlbnRseSBhbGxvY2F0ZWQgUEZOcyBkdXJpbmcgcmVzdG9y ZS4gKi8KPiArICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgeGNfc3JfYml0bWFwIGF0dGVtcHRl ZF8xZzsKPiArICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgeGNfc3JfYml0bWFwIGF0dGVtcHRl ZF8ybTsKPiArICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgeGNfc3JfYml0bWFwIGFsbG9jYXRl ZF9wZm5zOwo+ICsgICAgICAgICAgICAgICAgICAgIHhlbl9wZm5fdCBpZHgxR19wcmV2LCBpZHgy TV9wcmV2Owo+ICAgICAgICAgICAgICAgICAgfSByZXN0b3JlOwo+ICAgICAgICAgICAgICB9Owo+ ICAgICAgICAgIH0geDg2X2h2bTsKPiBAQCAtNDU5LDE0ICs0NzcsNiBAQCBzdGF0aWMgaW5saW5l IGludCB3cml0ZV9yZWNvcmQoc3RydWN0IHhjX3NyX2NvbnRleHQgKmN0eCwKPiAgICovCj4gIGlu dCByZWFkX3JlY29yZChzdHJ1Y3QgeGNfc3JfY29udGV4dCAqY3R4LCBpbnQgZmQsIHN0cnVjdCB4 Y19zcl9yZWNvcmQgKnJlYyk7Cj4gIAo+IC0vKgo+IC0gKiBUaGlzIHdvdWxkIGlkZWFsbHkgYmUg cHJpdmF0ZSBpbiByZXN0b3JlLmMsIGJ1dCBpcyBuZWVkZWQgYnkKPiAtICogeDg2X3B2X2xvY2Fs aXNlX3BhZ2UoKSBpZiB3ZSByZWNlaXZlIHBhZ2V0YWJsZXMgZnJhbWVzIGFoZWFkIG9mIHRoZQo+ IC0gKiBjb250ZW50cyBvZiB0aGUgZnJhbWVzIHRoZXkgcG9pbnQgYXQuCj4gLSAqLwo+IC1pbnQg cG9wdWxhdGVfcGZucyhzdHJ1Y3QgeGNfc3JfY29udGV4dCAqY3R4LCB1bnNpZ25lZCBjb3VudCwK PiAtICAgICAgICAgICAgICAgICAgY29uc3QgeGVuX3Bmbl90ICpvcmlnaW5hbF9wZm5zLCBjb25z dCB1aW50MzJfdCAqdHlwZXMpOwo+IC0KPiAgI2VuZGlmCj4gIC8qCj4gICAqIExvY2FsIHZhcmlh YmxlczoKWy4uLl0KPiAgCj4gK3N0cnVjdCB4ODZfaHZtX3NwIHsKCkZvcmdvdCB0byBhc2s6IHdo YXQgZG9lcyBzcCBzdGFuZCBmb3I/Cgo+ICtzdGF0aWMgYm9vbCB4ODZfaHZtX3B1bmNoX2hvbGUo c3RydWN0IHhjX3NyX2NvbnRleHQgKmN0eCwgeGVuX3Bmbl90IG1heF9wZm4pCj4gK3sKPiArICAg IHhjX2ludGVyZmFjZSAqeGNoID0gY3R4LT54Y2g7Cj4gKyAgICBzdHJ1Y3QgeGNfc3JfYml0bWFw ICpibTsKPiArICAgIHhlbl9wZm5fdCBfcGZuLCBwZm4sIG1pbl9wZm47Cj4gKyAgICB1aW50MzJf dCBkb21pZCwgZnJlZWQgPSAwLCBvcmRlcjsKCnVuc2lnbmVkIGludCAvIGxvbmcgZm9yIGZyZWVk IGFuZCBvcmRlci4KCj4gKyAgICBpbnQgcmMgPSAtMTsKPiArCj4gKyAgICAvKgo+ICsgICAgICog U2NhbiB0aGUgZW50aXJlIHN1cGVycGFnZSBiZWNhdXNlIHNldmVyYWwgYmF0Y2hlcyB3aWxsIGZp dCBpbnRvCj4gKyAgICAgKiBhIHN1cGVycGFnZSwgYW5kIGl0IGlzIHVua25vd24gd2hpY2ggcGZu IHRyaWdnZXJlZCB0aGUgYWxsb2NhdGlvbi4KPiArICAgICAqLwo+ICsgICAgb3JkZXIgPSBTVVBF UlBBR0VfMUdCX1NISUZUOwo+ICsgICAgcGZuID0gbWluX3BmbiA9IChtYXhfcGZuID4+IG9yZGVy KSA8PCBvcmRlcjsKPiArCgptaW5fcGZuIC0+IHN0YXJ0X3Bmbj8KCj4gKyAgICB3aGlsZSAoIHBm biA8PSBtYXhfcGZuICkKPiArICAgIHsKCmJtIGNhbiBiZSBkZWZpbmVkIGhlcmUuCgo+ICsgICAg ICAgIGJtID0gJmN0eC0+eDg2X2h2bS5yZXN0b3JlLmFsbG9jYXRlZF9wZm5zOwo+ICsgICAgICAg IGlmICggIXhjX3NyX2JpdG1hcF9yZXNpemUoYm0sIHBmbikgKQo+ICsgICAgICAgIHsKPiArICAg ICAgICAgICAgUEVSUk9SKCJGYWlsZWQgdG8gcmVhbGxvYyBhbGxvY2F0ZWRfcGZucyAlIiBQUklf eGVuX3BmbiwgcGZuKTsKPiArICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwo+ICsgICAgICAgIH0K PiArICAgICAgICBpZiAoICFwZm5faXNfcG9wdWxhdGVkKGN0eCwgcGZuKSAmJgo+ICsgICAgICAg ICAgICB4Y19zcl90ZXN0X2FuZF9jbGVhcl9iaXQocGZuLCBibSkgKSB7Cgpkb21pZCBhbmQgX3Bm biBjYW4gYmUgZGVmaW5lZCBoZXJlLgoKPiArICAgICAgICAgICAgZG9taWQgPSBjdHgtPmRvbWlk Owo+ICsgICAgICAgICAgICBfcGZuID0gcGZuOwo+ICsgICAgICAgICAgICByYyA9IHhjX2RvbWFp bl9kZWNyZWFzZV9yZXNlcnZhdGlvbl9leGFjdCh4Y2gsIGRvbWlkLCAxLCAwLCAmX3Bmbik7CgpQ bGVhc2UgYmF0Y2ggdGhlIHJlcXVlc3RzIG90aGVyd2lzZSBpdCBpcyBnb2luZyB0byBiZSB2ZXJ5 IHNsb3cuCgpJdCBzaG91bGQgYmUgZmVhc2libGUgdG8gY29uc3RydWN0IGFuIGFycmF5IG9mIHBm bnMgaGVyZSBhbmQgaXNzdWUgYQpzaW5nbGUgZGVjcmVhc2VfcmVzZXJ2YXRpb24gb3V0c2lkZSBv ZiB0aGlzIGxvb3AuCgo+ICsgICAgICAgICAgICBpZiAoIHJjICkKPiArICAgICAgICAgICAgewo+ ICsgICAgICAgICAgICAgICAgUEVSUk9SKCJGYWlsZWQgdG8gcmVsZWFzZSBwZm4gJSIgUFJJX3hl bl9wZm4sIHBmbik7Cj4gKyAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Cj4gKyAgICAgICAg ICAgIH0KPiArICAgICAgICAgICAgY3R4LT5yZXN0b3JlLnRvdF9wYWdlcy0tOwo+ICsgICAgICAg ICAgICBmcmVlZCsrOwo+ICsgICAgICAgIH0KPiArICAgICAgICBwZm4rKzsKPiArICAgIH0KPiAr ICAgIGlmICggZnJlZWQgKQo+ICsgICAgICAgIERQUklOVEYoImZyZWVkICV1IGJldHdlZW4gJSIg UFJJX3hlbl9wZm4gIiAlIiBQUklfeGVuX3BmbiAiXG4iLAo+ICsgICAgICAgICAgICAgICAgZnJl ZWQsIG1pbl9wZm4sIG1heF9wZm4pOwo+ICsgICAgcmV0dXJuIHRydWU7Cj4gK30KPiArCj4gKy8q Cj4gKyAqIFRyeSB0byBhbGxvY2F0ZSBzdXBlcnBhZ2VzLgo+ICsgKiBUaGlzIHdvcmtzIHdpdGhv dXQgbWVtb3J5IG1hcCBvbmx5IGlmIHRoZSBwZm5zIGFycml2ZSBpbiBpbmNyZW1lbnRhbCBvcmRl ci4KPiArICovCgpJIGhhdmUgc2FpZCBzZXZlcmFsIHRpbWVzLCBvbmUgd2F5IG9yIGFub3RoZXIs IEkgZG9uJ3Qgd2FudCB0byBtYWtlCmFzc3VtcHRpb24gb24gdGhlIHN0cmVhbSBvZiBwZm5zLiBT byBJJ20gYWZyYWlkIEkgY2FuJ3QgYWNrIGEgcGF0Y2ggbGlrZQp0aGlzLgoKSWYgSWFuIG9yIEFu ZHJldyB0aGlua3MgdGhpcyBpcyBPSywgSSB3b24ndCBzdGFuZCBpbiB0aGUgd2F5LgoKPiArc3Rh dGljIGludCB4ODZfaHZtX3BvcHVsYXRlX3BmbnMoc3RydWN0IHhjX3NyX2NvbnRleHQgKmN0eCwg dW5zaWduZWQgY291bnQsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0 IHhlbl9wZm5fdCAqb3JpZ2luYWxfcGZucywKCm9yaWdpbmFsX3BmbnMgLT4gcGZucz8KClRoZSBs aXN0IGlzIG5vdCBjb3BpZWQgYW5kL29yIGFsdGVyZWQgaW4gYW55IHdheSBhZmFpY3QuCgooSSBz a2lwcGVkIHRoZSByZXN0KQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpo dHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==