From: Wei Liu <wei.liu2@citrix.com>
To: Oleksandr Grytsov <al1img@gmail.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Oleksandr Grytsov <oleksandr_grytsov@epam.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4 03/13] libxl: add vdispl device
Date: Wed, 6 Sep 2017 14:39:06 +0100 [thread overview]
Message-ID: <20170906133906.vslf66jaqvfbac4t@citrix.com> (raw)
In-Reply-To: <CACvf2oUBg=PUNJNoQgdz83GDqD9FMiLdRNpscbYyiUbiR8As-Q@mail.gmail.com>
On Wed, Sep 06, 2017 at 04:02:23PM +0300, Oleksandr Grytsov wrote:
> On Tue, Sep 5, 2017 at 4:04 PM, Wei Liu <wei.liu2@citrix.com> wrote:
> > On Tue, Sep 05, 2017 at 01:58:53PM +0100, Ian Jackson wrote:
> >> Wei Liu writes ("Re: [PATCH v4 03/13] libxl: add vdispl device"):
> >> > > + rc = snprintf(connector_path, 128, "%s/%d", path, info->num_connectors);
> >>
> >> Why not use GCSPRINTF ? These statically sized buffers etc. are an
> >> invitation to bugs.
> >
> > Right, that's a better suggestion.
>
> I reuse connector_path buffer as path to read connector settings from xen store.
> So if I use GCSPRINTF for each setting then this function will allocate
> about 256 bytes for one connector. In typical scenario each frontend will
> have 1 or 2 connectors.
>
That's OK I think.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-09-06 13:39 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 14:25 [PATCH v4 00/13] libxl: add PV display device driver interface Oleksandr Grytsov
2017-07-18 14:25 ` [PATCH v4 01/13] libxl: add generic function to add device Oleksandr Grytsov
2017-09-05 11:47 ` Wei Liu
2017-09-05 16:44 ` Oleksandr Grytsov
2017-09-06 9:36 ` Wei Liu
2017-09-06 12:08 ` Oleksandr Grytsov
2017-07-18 14:25 ` [PATCH v4 02/13] libxl: add generic functions to get and free device list Oleksandr Grytsov
2017-09-05 11:51 ` Wei Liu
2017-09-06 12:31 ` Oleksandr Grytsov
2017-07-18 14:25 ` [PATCH v4 03/13] libxl: add vdispl device Oleksandr Grytsov
2017-09-05 12:52 ` Wei Liu
2017-09-05 12:58 ` Ian Jackson
2017-09-05 13:04 ` Wei Liu
2017-09-06 13:02 ` Oleksandr Grytsov
2017-09-06 13:39 ` Wei Liu [this message]
2017-07-18 14:25 ` [PATCH v4 04/13] xl: add PV display device commands Oleksandr Grytsov
2017-07-28 14:11 ` Wei Liu
2017-07-18 14:25 ` [PATCH v4 05/13] docs: add PV display driver information Oleksandr Grytsov
2017-07-28 14:11 ` Wei Liu
2017-07-18 14:25 ` [PATCH v4 06/13] libxl: change p9 to use generec add function Oleksandr Grytsov
2017-07-28 14:11 ` Wei Liu
2017-07-28 16:23 ` Wei Liu
2017-07-30 18:42 ` Oleksandr Grytsov
2017-07-31 14:36 ` Wei Liu
2017-08-01 11:58 ` Oleksandr Grytsov
2017-08-01 13:00 ` Wei Liu
2017-08-02 11:37 ` Oleksandr Grytsov
2017-08-04 11:53 ` Wei Liu
2017-08-08 12:39 ` Oleksandr Grytsov
2017-08-08 15:05 ` Wei Liu
2017-09-05 12:53 ` Wei Liu
2017-07-18 14:25 ` [PATCH v4 07/13] libxl: change vkb " Oleksandr Grytsov
2017-09-05 12:54 ` Wei Liu
2017-07-18 14:25 ` [PATCH v4 08/13] libxl: change vfb " Oleksandr Grytsov
2017-09-05 12:55 ` Wei Liu
2017-07-18 14:25 ` [PATCH v4 09/13] libxl: change disk to use generic getting list functions Oleksandr Grytsov
2017-09-05 12:58 ` Wei Liu
2017-07-18 14:25 ` [PATCH v4 10/13] libxl: change nic to use generec add function Oleksandr Grytsov
2017-09-05 13:03 ` Wei Liu
2017-09-06 15:39 ` Oleksandr Grytsov
2017-07-18 14:25 ` [PATCH v4 11/13] libxl: change vtpm " Oleksandr Grytsov
2017-09-05 13:05 ` Wei Liu
2017-07-18 14:25 ` [PATCH v4 12/13] libxl: remove unneeded DEVICE_ADD macro Oleksandr Grytsov
2017-09-05 13:05 ` Wei Liu
2017-07-18 14:25 ` [PATCH v4 13/13] libxl: make pci and usb setdefault function generic Oleksandr Grytsov
2017-09-05 13:06 ` Wei Liu
2017-09-06 15:53 ` Oleksandr Grytsov
2017-09-07 9:05 ` Wei Liu
2017-07-27 11:30 ` [PATCH v4 00/13] libxl: add PV display device driver interface Oleksandr Andrushchenko
2017-07-27 14:49 ` Wei Liu
2017-07-28 14:13 ` Wei Liu
2017-08-17 10:13 ` Oleksandr Grytsov
2017-08-17 11:11 ` Wei Liu
2017-08-30 15:49 ` Oleksandr Grytsov
2017-08-30 15:52 ` Ian Jackson
2017-08-31 9:01 ` Oleksandr Grytsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906133906.vslf66jaqvfbac4t@citrix.com \
--to=wei.liu2@citrix.com \
--cc=al1img@gmail.com \
--cc=ian.jackson@eu.citrix.com \
--cc=oleksandr_grytsov@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).