From: Olaf Hering <olaf@aepfle.de>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v9 3/3] tools/libxc: use superpages during restore of HVM guest
Date: Wed, 6 Sep 2017 14:02:41 +0200 [thread overview]
Message-ID: <20170906140241.1a09ccb1.olaf@aepfle.de> (raw)
In-Reply-To: <20170906113410.2upxmdambiwzvk5g@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 703 bytes --]
Am Wed, 6 Sep 2017 12:34:10 +0100
schrieb Wei Liu <wei.liu2@citrix.com>:
> > +struct x86_hvm_sp {
> Forgot to ask: what does sp stand for?
superpage. I will check if there is room to expand this string.
> > + * Try to allocate superpages.
> > + * This works without memory map only if the pfns arrive in incremental order.
> > + */
> I have said several times, one way or another, I don't want to make
> assumption on the stream of pfns. So I'm afraid I can't ack a patch like
> this.
It will work with any order, I think. Just with incremental order the superpages will not be split once they are allocated.
Thanks for the review. I will send another series shortly.
Olaf
[-- Attachment #1.2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-09-06 12:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 16:08 [PATCH v9 0/3] tools/libxc: use superpages Olaf Hering
2017-09-01 16:08 ` [PATCH v9 1/3] tools/libxc: move SUPERPAGE macros to common header Olaf Hering
2017-09-01 16:08 ` [PATCH v9 2/3] tools/libxc: add API for bitmap access for restore Olaf Hering
2017-09-06 11:57 ` Andrew Cooper
2017-09-06 12:15 ` Olaf Hering
2017-09-01 16:08 ` [PATCH v9 3/3] tools/libxc: use superpages during restore of HVM guest Olaf Hering
2017-09-06 11:34 ` Wei Liu
2017-09-06 11:39 ` Andrew Cooper
2017-09-08 11:45 ` Olaf Hering
2017-10-11 14:15 ` Olaf Hering
2017-10-11 15:09 ` Olaf Hering
2017-09-06 12:02 ` Olaf Hering [this message]
2017-09-06 12:13 ` Andrew Cooper
2017-09-06 12:17 ` Olaf Hering
2017-09-06 12:23 ` Andrew Cooper
2017-09-06 12:25 ` Olaf Hering
2017-09-06 12:24 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906140241.1a09ccb1.olaf@aepfle.de \
--to=olaf@aepfle.de \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).