From: Wei Liu <wei.liu2@citrix.com>
To: Yi Sun <yi.y.sun@linux.intel.com>
Cc: kevin.tian@intel.com, wei.liu2@citrix.com,
andrew.cooper3@citrix.com, dario.faggioli@citrix.com,
ian.jackson@eu.citrix.com, julien.grall@arm.com,
mengxu@cis.upenn.edu, jbeulich@suse.com,
chao.p.peng@linux.intel.com, xen-devel@lists.xenproject.org,
dgdegra@tycho.nsa.gov, "Roger Pau Monn�" <roger.pau@citrix.com>
Subject: Re: [PATCH v3 06/15] x86: implement get value interface for MBA
Date: Wed, 20 Sep 2017 17:02:54 +0100 [thread overview]
Message-ID: <20170920160254.alka2ibxamwem43q@citrix.com> (raw)
In-Reply-To: <20170920092222.GU11006@yi.y.sun>
On Wed, Sep 20, 2017 at 05:22:22PM +0800, Yi Sun wrote:
> On 17-09-20 09:43:40, Roger Pau Monn� wrote:
> > On Wed, Sep 20, 2017 at 01:09:06PM +0800, Yi Sun wrote:
> > > On 17-09-19 10:15:42, Roger Pau Monn� wrote:
> > > > On Tue, Sep 05, 2017 at 05:32:28PM +0800, Yi Sun wrote:
> > > > > diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
> > > > > index 696eff2..7902af7 100644
> > > > > --- a/xen/arch/x86/domctl.c
> > > > > +++ b/xen/arch/x86/domctl.c
> > > > > @@ -1496,6 +1496,13 @@ long arch_do_domctl(
> > > > > copyback = true;
> > > > > break;
> > > > >
> > > > > + case XEN_DOMCTL_PSR_ALLOC_GET_MBA_THRTL:
> > > > > + ret = psr_get_val(d, domctl->u.psr_alloc.target,
> > > > > + &val32, PSR_TYPE_MBA_THRTL);
> > > > > + domctl->u.psr_alloc.data = val32;
> > > >
> > > > Hm, why does psr_get_val take a uint32_t * instead of a uint64_t *? So
> > > > that you can directly pass &domctl->u.psr_alloc.data.
> > > >
> > > > Or the other way around, why is domctl->u.psr_alloc.data a uint64_t
> > > > instead of a uint32_t?
> > > >
> > > There is a historical reason. The COS MSR is 64bit. So, the original codes
> > > in L3 CAT (submitted years ago) used uint64_t.
> > >
> > > But during L2 CAT review, per Jan's comment, the uint64_t is not necessary
> > > in psr.c. So, we convert it to uint32_t in psr.c and make the codes you see
> > > here.
> >
> > Since this is a DOMCTL, you can change the type of the structure to be
> > an uint32_t, so that you can pass it directly (unless I'm missing
> > something else that requires this to be uint64_t).
> >
> The tools layer implementation uses uint64_t according to SDM definition. So,
> we have to do a convertion here or in tools/. Or, we need modify interfaces in
> tools layer.
>
> As CAT interfaces in tools layer have been released and it is a natural choice
> to make it same as SDM, I think should keep uint64_t in tools at least. If so,
> we must do the convertion somewhere. Then, I think it is not so necessary to
> change current codes. Is that good to you?
You can change libxc interfaces at will, you need to pay more attention
if you change libxl. This is just FYI. I'm not suggesting you have to
change the interfaces.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-09-20 16:04 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 9:32 [PATCH v3 00/15] Enable Memory Bandwidth Allocation in Xen Yi Sun
2017-09-05 9:32 ` [PATCH v3 01/15] docs: create Memory Bandwidth Allocation (MBA) feature document Yi Sun
2017-09-18 17:16 ` Roger Pau Monné
2017-09-19 6:07 ` Jan Beulich
2017-09-20 2:59 ` Yi Sun
2017-09-20 3:06 ` Yi Sun
2017-09-20 8:36 ` Roger Pau Monné
2017-09-20 9:08 ` Yi Sun
2017-09-05 9:32 ` [PATCH v3 02/15] Rename PSR sysctl/domctl interfaces and xsm policy to make them be general Yi Sun
2017-09-19 8:03 ` Roger Pau Monné
2017-09-20 3:12 ` Yi Sun
2017-09-05 9:32 ` [PATCH v3 03/15] x86: rename 'cbm_type' to 'psr_type' to make it general Yi Sun
2017-09-19 8:22 ` Roger Pau Monné
2017-09-05 9:32 ` [PATCH v3 04/15] x86: implement data structure and CPU init flow for MBA Yi Sun
2017-09-19 8:55 ` Roger Pau Monné
2017-09-20 3:22 ` Yi Sun
2017-09-20 7:11 ` Jan Beulich
2017-09-20 7:27 ` Yi Sun
2017-09-05 9:32 ` [PATCH v3 05/15] x86: implement get hw info " Yi Sun
2017-09-19 9:08 ` Roger Pau Monné
2017-09-20 5:05 ` Yi Sun
2017-09-05 9:32 ` [PATCH v3 06/15] x86: implement get value interface " Yi Sun
2017-09-19 9:15 ` Roger Pau Monné
2017-09-20 5:09 ` Yi Sun
2017-09-20 8:43 ` Roger Pau Monné
2017-09-20 9:22 ` Yi Sun
2017-09-20 16:02 ` Wei Liu [this message]
2017-09-05 9:32 ` [PATCH v3 07/15] x86: implement set value flow " Yi Sun
2017-09-19 9:57 ` Roger Pau Monné
2017-09-20 5:39 ` Yi Sun
2017-09-05 9:32 ` [PATCH v3 08/15] tools: create general interfaces to support psr allocation features Yi Sun
2017-09-19 10:04 ` Roger Pau Monné
2017-09-20 5:45 ` Yi Sun
2017-09-22 7:01 ` Chao Peng
2017-09-28 16:11 ` Wei Liu
2017-09-05 9:32 ` [PATCH v3 09/15] tools: implement the new libxc get hw info interface Yi Sun
2017-09-19 10:15 ` Roger Pau Monné
2017-09-20 6:13 ` Yi Sun
2017-09-05 9:32 ` [PATCH v3 10/15] tools: implement the new libxl " Yi Sun
2017-09-19 10:28 ` Roger Pau Monné
2017-09-20 6:20 ` Yi Sun
2017-09-05 9:32 ` [PATCH v3 11/15] tools: implement the new xl " Yi Sun
2017-09-19 10:32 ` Roger Pau Monné
2017-09-20 6:23 ` Yi Sun
2017-09-05 9:32 ` [PATCH v3 12/15] tools: rename 'xc_psr_cat_type' to 'xc_psr_type' Yi Sun
2017-09-19 10:34 ` Roger Pau Monné
2017-09-20 6:25 ` Yi Sun
2017-09-05 9:32 ` [PATCH v3 13/15] tools: implement new generic get value interface and MBA get value command Yi Sun
2017-09-19 11:02 ` Roger Pau Monné
2017-09-20 6:46 ` Yi Sun
2017-09-20 8:57 ` Roger Pau Monné
2017-09-20 9:11 ` Yi Sun
2017-09-05 9:32 ` [PATCH v3 14/15] tools: implement new generic set value interface and MBA set " Yi Sun
2017-09-19 11:30 ` Roger Pau Monné
2017-09-20 7:25 ` Yi Sun
2017-09-20 16:10 ` Wei Liu
2017-09-28 16:23 ` Dario Faggioli
2017-09-29 12:58 ` Wei Liu
2017-09-05 9:32 ` [PATCH v3 15/15] docs: add MBA description in docs Yi Sun
2017-09-19 11:37 ` Roger Pau Monné
2017-09-20 7:26 ` Yi Sun
2017-09-28 16:56 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170920160254.alka2ibxamwem43q@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=chao.p.peng@linux.intel.com \
--cc=dario.faggioli@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=kevin.tian@intel.com \
--cc=mengxu@cis.upenn.edu \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--cc=yi.y.sun@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).