* [PATCH] libxl: remove dead code in libxl__domain_build_info_setdefault
@ 2017-09-29 9:53 Roger Pau Monne
2017-09-29 12:22 ` Wei Liu
2017-10-02 10:27 ` Wei Liu
0 siblings, 2 replies; 3+ messages in thread
From: Roger Pau Monne @ 2017-09-29 9:53 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Ian Jackson, Roger Pau Monne
Spotted by Coverity.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
tools/libxl/libxl_create.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
index c4b7d08532..fa3c668a56 100644
--- a/tools/libxl/libxl_create.c
+++ b/tools/libxl/libxl_create.c
@@ -259,8 +259,6 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
break;
}
break;
- b_info->video_memkb = 0;
- break;
case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN:
default:
switch (b_info->u.hvm.vga.kind) {
--
2.13.5 (Apple Git-94)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libxl: remove dead code in libxl__domain_build_info_setdefault
2017-09-29 9:53 [PATCH] libxl: remove dead code in libxl__domain_build_info_setdefault Roger Pau Monne
@ 2017-09-29 12:22 ` Wei Liu
2017-10-02 10:27 ` Wei Liu
1 sibling, 0 replies; 3+ messages in thread
From: Wei Liu @ 2017-09-29 12:22 UTC (permalink / raw)
To: Roger Pau Monne; +Cc: xen-devel, Ian Jackson, Wei Liu
On Fri, Sep 29, 2017 at 10:53:07AM +0100, Roger Pau Monne wrote:
> Spotted by Coverity.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libxl: remove dead code in libxl__domain_build_info_setdefault
2017-09-29 9:53 [PATCH] libxl: remove dead code in libxl__domain_build_info_setdefault Roger Pau Monne
2017-09-29 12:22 ` Wei Liu
@ 2017-10-02 10:27 ` Wei Liu
1 sibling, 0 replies; 3+ messages in thread
From: Wei Liu @ 2017-10-02 10:27 UTC (permalink / raw)
To: Roger Pau Monne; +Cc: xen-devel, Ian Jackson, Wei Liu
On Fri, Sep 29, 2017 at 10:53:07AM +0100, Roger Pau Monne wrote:
> Spotted by Coverity.
>
This now has a Coverity ID 1418831.
I will add that to commit message.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-02 10:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-29 9:53 [PATCH] libxl: remove dead code in libxl__domain_build_info_setdefault Roger Pau Monne
2017-09-29 12:22 ` Wei Liu
2017-10-02 10:27 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).