From: Julien Grall <julien.grall@arm.com>
To: xen-devel@lists.xen.org
Cc: andre.przywara@arm.com, Julien Grall <julien.grall@arm.com>,
sstabellini@kernel.org
Subject: [PATCH v3 5/9] xen/arm: mm: Rename 'ai' into 'flags' in create_xen_entries
Date: Mon, 2 Oct 2017 18:31:46 +0100 [thread overview]
Message-ID: <20171002173150.5404-6-julien.grall@arm.com> (raw)
In-Reply-To: <20171002173150.5404-1-julien.grall@arm.com>
The parameter 'ai' is used either for attribute index or for
permissions. Follow-up patch will rework that parameters to carry more
information. So rename the parameter to 'flags'.
Signed-off-by: Julien Grall <julien.grall@arm.com>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Changes in v3:
- Add Stefano's reviewed-by
Changes in v2:
- Add Andre's reviewed-by
---
xen/arch/arm/mm.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 73677902d4..39bade63f5 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -986,7 +986,7 @@ static int create_xen_entries(enum xenmap_operation op,
unsigned long virt,
mfn_t mfn,
unsigned long nr_mfns,
- unsigned int ai)
+ unsigned int flags)
{
int rc;
unsigned long addr = virt, addr_end = addr + nr_mfns * PAGE_SIZE;
@@ -1021,7 +1021,7 @@ static int create_xen_entries(enum xenmap_operation op,
}
if ( op == RESERVE )
break;
- pte = mfn_to_xen_entry(mfn, ai);
+ pte = mfn_to_xen_entry(mfn, flags);
pte.pt.table = 1;
write_pte(entry, pte);
break;
@@ -1038,8 +1038,8 @@ static int create_xen_entries(enum xenmap_operation op,
else
{
pte = *entry;
- pte.pt.ro = PTE_RO_MASK(ai);
- pte.pt.xn = PTE_NX_MASK(ai);
+ pte.pt.ro = PTE_RO_MASK(flags);
+ pte.pt.xn = PTE_NX_MASK(flags);
if ( !pte.pt.ro && !pte.pt.xn )
{
printk("%s: Incorrect combination for addr=%lx\n",
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-10-02 17:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 17:31 [PATCH v3 0/9] xen/arm: Memory subsystem clean-up Julien Grall
2017-10-02 17:31 ` [PATCH v3 1/9] xen/arm: page: Use ARMv8 naming to improve readability Julien Grall
2017-10-02 17:31 ` [PATCH v3 2/9] xen/arm: page: Clean-up the definition of MAIRVAL Julien Grall
2017-10-02 17:31 ` [PATCH v3 3/9] xen/arm: mm: Rename and clarify AP[1] in the stage-1 page table Julien Grall
2017-10-02 17:31 ` [PATCH v3 4/9] xen/arm: Switch to SYS_STATE_boot just after end_boot_allocator() Julien Grall
2017-10-02 17:31 ` Julien Grall [this message]
2017-10-02 17:31 ` [PATCH v3 6/9] xen/arm: page: Describe the layout of flags used to update page tables Julien Grall
2017-10-02 17:31 ` [PATCH v3 7/9] xen/arm: mm: Embed permission in the flags Julien Grall
2017-10-09 12:34 ` Julien Grall
2017-10-02 17:31 ` [PATCH v3 8/9] xen/arm: mm: Handle permission flags when adding a new mapping Julien Grall
2017-10-02 17:31 ` [PATCH v3 9/9] xen/arm: mm: Use memory flags for modify_xen_mappings rather than custom one Julien Grall
2017-10-02 18:14 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171002173150.5404-6-julien.grall@arm.com \
--to=julien.grall@arm.com \
--cc=andre.przywara@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).