From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Julien Grall <julien.grall@arm.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] tools/libxc: Fix domid parameter types
Date: Wed, 11 Oct 2017 11:01:53 +0100 [thread overview]
Message-ID: <20171011100153.zsasotualmyj4ltx@citrix.com> (raw)
In-Reply-To: <be9e490f-1042-df8a-ca6a-d0b5071c8900@citrix.com>
On Wed, Oct 11, 2017 at 10:52:42AM +0100, Andrew Cooper wrote:
> On 11/10/17 10:51, Ian Jackson wrote:
> > Andrew Cooper writes ("[PATCH] tools/libxc: Fix domid parameter types"):
> >> Mixed throughout libxc are uint32_t, int, and domid_t for domid parameters.
> >> With a signed type, and an explicitly 16-bit type, it is exceedingly difficult
> >> to construct an INVALID_DOMID constant which works with all of them. (The
> >> main problem being that domid_t gets unconditionally zero extended when
> >> promoted to int for arithmatic.)
> >>
> >> Libxl uses uint32_t consistently everywhere, so alter libxc to match.
> > I like this plan. But I think this comes a bit late for 4.10 ?
>
> I'm sorry for it being late, but it is blocking my other series to fix
> gnttab construction in the domain builder, which really is 4.10 material.
>
OK. I don't want to block the more important work.
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-10-11 10:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 19:00 [PATCH] tools/libxc: Fix domid parameter types Andrew Cooper
2017-10-09 14:47 ` Wei Liu
2017-10-09 14:51 ` Andrew Cooper
2017-10-09 15:19 ` Wei Liu
2017-10-09 15:38 ` Andrew Cooper
2017-10-11 9:51 ` Ian Jackson
2017-10-11 9:52 ` Andrew Cooper
2017-10-11 10:01 ` Wei Liu [this message]
2017-10-11 10:28 ` Ian Jackson
2017-10-11 10:32 ` Julien Grall
2017-10-11 11:01 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011100153.zsasotualmyj4ltx@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).