xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
	Wei Liu <wei.liu2@citrix.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH v9 3/3] tools/libxc: use superpages during restore of HVM guest
Date: Wed, 11 Oct 2017 17:09:43 +0200	[thread overview]
Message-ID: <20171011150943.GK4226@aepfle.de> (raw)
In-Reply-To: <20171011141532.GI4226@aepfle.de>


[-- Attachment #1.1: Type: text/plain, Size: 495 bytes --]

On Wed, Oct 11, Olaf Hering wrote:

> -#define MAX_BATCH_SIZE 1024   /* up to 1024 pages (4MB) at a time */
> +#define MAX_BATCH_SIZE SUPERPAGE_1GB_NR_PFNS   /* up to 1GB at a time */

Actually the error is something else, I missed this in the debug output:

xc: error: Failed to get types for pfn batch (7 = Argument list too long): Internal error

write_batch() should probably split the requests when filling types[] because
Xen has "1024" hardcoded in XEN_DOMCTL_getpageframeinfo3...


Olaf

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-10-11 15:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-01 16:08 [PATCH v9 0/3] tools/libxc: use superpages Olaf Hering
2017-09-01 16:08 ` [PATCH v9 1/3] tools/libxc: move SUPERPAGE macros to common header Olaf Hering
2017-09-01 16:08 ` [PATCH v9 2/3] tools/libxc: add API for bitmap access for restore Olaf Hering
2017-09-06 11:57   ` Andrew Cooper
2017-09-06 12:15     ` Olaf Hering
2017-09-01 16:08 ` [PATCH v9 3/3] tools/libxc: use superpages during restore of HVM guest Olaf Hering
2017-09-06 11:34   ` Wei Liu
2017-09-06 11:39     ` Andrew Cooper
2017-09-08 11:45       ` Olaf Hering
2017-10-11 14:15         ` Olaf Hering
2017-10-11 15:09           ` Olaf Hering [this message]
2017-09-06 12:02     ` Olaf Hering
2017-09-06 12:13   ` Andrew Cooper
2017-09-06 12:17     ` Olaf Hering
2017-09-06 12:23       ` Andrew Cooper
2017-09-06 12:25         ` Olaf Hering
2017-09-06 12:24     ` Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171011150943.GK4226@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).