* [PATCH for-4.10] xen: Fix XEN_DMOP_remote_shutdown return value
@ 2017-10-11 15:41 Ross Lagerwall
2017-10-11 15:45 ` Andrew Cooper
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Ross Lagerwall @ 2017-10-11 15:41 UTC (permalink / raw)
To: xen-devel
Cc: Ross Lagerwall, Julien Grall, Ian Jackson, Jan Beulich,
Andrew Cooper
Return 0 to indicate success rather than whatever rc was previously set
to (-EINVAL).
Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
---
xen/arch/x86/hvm/dm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c
index 82addea..32ade95 100644
--- a/xen/arch/x86/hvm/dm.c
+++ b/xen/arch/x86/hvm/dm.c
@@ -636,6 +636,7 @@ static int dm_op(const struct dmop_args *op_args)
&op.u.remote_shutdown;
domain_shutdown(d, data->reason);
+ rc = 0;
break;
}
--
2.9.5
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH for-4.10] xen: Fix XEN_DMOP_remote_shutdown return value
2017-10-11 15:41 [PATCH for-4.10] xen: Fix XEN_DMOP_remote_shutdown return value Ross Lagerwall
@ 2017-10-11 15:45 ` Andrew Cooper
2017-10-11 15:53 ` Ian Jackson
2017-10-11 15:48 ` Jan Beulich
2017-10-11 15:52 ` Wei Liu
2 siblings, 1 reply; 5+ messages in thread
From: Andrew Cooper @ 2017-10-11 15:45 UTC (permalink / raw)
To: Ross Lagerwall, xen-devel; +Cc: Julien Grall, Ian Jackson, Jan Beulich
On 11/10/17 16:41, Ross Lagerwall wrote:
> Return 0 to indicate success rather than whatever rc was previously set
> to (-EINVAL).
>
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
> ---
> xen/arch/x86/hvm/dm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c
> index 82addea..32ade95 100644
> --- a/xen/arch/x86/hvm/dm.c
> +++ b/xen/arch/x86/hvm/dm.c
> @@ -636,6 +636,7 @@ static int dm_op(const struct dmop_args *op_args)
> &op.u.remote_shutdown;
>
> domain_shutdown(d, data->reason);
> + rc = 0;
Ideally with a newline here (can be fixed on commit).
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH for-4.10] xen: Fix XEN_DMOP_remote_shutdown return value
2017-10-11 15:45 ` Andrew Cooper
@ 2017-10-11 15:53 ` Ian Jackson
0 siblings, 0 replies; 5+ messages in thread
From: Ian Jackson @ 2017-10-11 15:53 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Ross Lagerwall, Julien Grall, Jan Beulich, xen-devel
Andrew Cooper writes ("Re: [PATCH for-4.10] xen: Fix XEN_DMOP_remote_shutdown return value"):
> On 11/10/17 16:41, Ross Lagerwall wrote:
> > Return 0 to indicate success rather than whatever rc was previously set
> > to (-EINVAL).
> >
> > Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
> > ---
> > xen/arch/x86/hvm/dm.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c
> > index 82addea..32ade95 100644
> > --- a/xen/arch/x86/hvm/dm.c
> > +++ b/xen/arch/x86/hvm/dm.c
> > @@ -636,6 +636,7 @@ static int dm_op(const struct dmop_args *op_args)
> > &op.u.remote_shutdown;
> >
> > domain_shutdown(d, data->reason);
> > + rc = 0;
>
> Ideally with a newline here (can be fixed on commit).
Thanks to Ross for spotting this, and to whoever committed it so
speedily.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH for-4.10] xen: Fix XEN_DMOP_remote_shutdown return value
2017-10-11 15:41 [PATCH for-4.10] xen: Fix XEN_DMOP_remote_shutdown return value Ross Lagerwall
2017-10-11 15:45 ` Andrew Cooper
@ 2017-10-11 15:48 ` Jan Beulich
2017-10-11 15:52 ` Wei Liu
2 siblings, 0 replies; 5+ messages in thread
From: Jan Beulich @ 2017-10-11 15:48 UTC (permalink / raw)
To: Ross Lagerwall; +Cc: Andrew Cooper, Julien Grall, Ian Jackson, xen-devel
>>> On 11.10.17 at 17:41, <ross.lagerwall@citrix.com> wrote:
> Return 0 to indicate success rather than whatever rc was previously set
> to (-EINVAL).
>
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH for-4.10] xen: Fix XEN_DMOP_remote_shutdown return value
2017-10-11 15:41 [PATCH for-4.10] xen: Fix XEN_DMOP_remote_shutdown return value Ross Lagerwall
2017-10-11 15:45 ` Andrew Cooper
2017-10-11 15:48 ` Jan Beulich
@ 2017-10-11 15:52 ` Wei Liu
2 siblings, 0 replies; 5+ messages in thread
From: Wei Liu @ 2017-10-11 15:52 UTC (permalink / raw)
To: Ross Lagerwall
Cc: Wei Liu, Andrew Cooper, Ian Jackson, xen-devel, Julien Grall,
Jan Beulich
On Wed, Oct 11, 2017 at 04:41:57PM +0100, Ross Lagerwall wrote:
> Return 0 to indicate success rather than whatever rc was previously set
> to (-EINVAL).
>
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-11 15:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-11 15:41 [PATCH for-4.10] xen: Fix XEN_DMOP_remote_shutdown return value Ross Lagerwall
2017-10-11 15:45 ` Andrew Cooper
2017-10-11 15:53 ` Ian Jackson
2017-10-11 15:48 ` Jan Beulich
2017-10-11 15:52 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).