From: Anthony PERARD <anthony.perard@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Juergen Gross <jgross@suse.com>,
Ross Lagerwall <ross.lagerwall@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
qemu-devel@nongnu.org, xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/8] xen: link against xentoolcore
Date: Thu, 19 Oct 2017 17:47:28 +0100 [thread overview]
Message-ID: <20171019164728.GC11934@perard.uk.xensource.com> (raw)
In-Reply-To: <23016.54514.243025.328812@mariner.uk.xensource.com>
On Thu, Oct 19, 2017 at 05:38:10PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("Re: [PATCH 1/8] xen: link against xentoolcore"):
> > I don't think it is necessary to do anything in qemu. The linker should
> > find on its own the new libxentoolcore as long as an option
> > -Wl,-rpath-link= provide the right path to xentoolcore when building
> > qemu from xen.git. In other cases, the pkg-config files should be
> > enough (configure doesn't need to known about a new xentoolcore.pc
> > file).
>
> It seems that the build still works, without this patch but without
> the rest of my series too, because we end up passing
> -L/u/iwj/work/xen.git/tools/../tools/libs/toolcore
> -Wl,-rpath-link=/u/iwj/work/xen.git/tools/../tools/libs/toolcore
> (or similar) on the qemu link line. So when ld links against
> libxenstore (say) it finds that xenstore needs toolcore and finds
> toolcore in the relevant paths.
>
> We still need this patch for the rest of the series, though.
Of course, I was only arguing that this patch on its own is not usefull.
Do you need a signed-off-by or review-by from me? Since it looks like
I'm the author.
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-10-19 16:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 16:01 [PATCH v4 0/8] xen: xen-domid-restrict improvements Ian Jackson
2017-10-09 16:01 ` [PATCH 1/8] xen: link against xentoolcore Ian Jackson
2017-10-09 16:28 ` Ian Jackson
2017-10-10 10:32 ` Anthony PERARD
2017-10-10 17:13 ` Ian Jackson
2017-10-19 16:38 ` Ian Jackson
2017-10-19 16:47 ` Anthony PERARD [this message]
2017-10-20 10:25 ` Ian Jackson
2017-10-09 16:01 ` [PATCH 2/8] xen: restrict: use xentoolcore_restrict_all Ian Jackson
2017-10-10 11:26 ` Anthony PERARD
2017-10-09 16:01 ` [PATCH 3/8] xen: defer call to xen_restrict until just before os_setup_post Ian Jackson
2017-10-10 11:48 ` Anthony PERARD
2017-10-13 8:37 ` Ross Lagerwall
2017-10-13 8:59 ` Andrew Cooper
2017-10-13 9:06 ` Paul Durrant
2017-10-13 10:43 ` Ian Jackson
2017-10-09 16:01 ` [PATCH 4/8] xen: destroy_hvm_domain: Move reason into a variable Ian Jackson
2017-10-09 16:01 ` [PATCH 5/8] xen: move xc_interface compatibility fallback further up the file Ian Jackson
2017-10-10 11:48 ` Anthony PERARD
2017-10-09 16:01 ` [PATCH 6/8] xen: destroy_hvm_domain: Try xendevicemodel_shutdown Ian Jackson
2017-10-10 11:55 ` Anthony PERARD
2017-10-09 16:01 ` [PATCH 7/8] os-posix: Provide new -runas <uid>.<gid> facility Ian Jackson
2017-10-09 16:01 ` [PATCH 8/8] configure: do_compiler: Dump some extra info under bash Ian Jackson
2017-10-09 18:53 ` [Qemu-devel] [PATCH v4 0/8] xen: xen-domid-restrict improvements no-reply
-- strict thread matches above, loose matches on Subject: below --
2017-10-19 16:51 [PATCH v5 " Ian Jackson
2017-10-19 16:51 ` [PATCH 1/8] xen: link against xentoolcore Ian Jackson
2017-10-06 18:27 [PATCH v3 0/8] xen: xen-domid-restrict improvements Ian Jackson
2017-10-06 18:27 ` [PATCH 1/8] xen: link against xentoolcore Ian Jackson
2017-10-04 16:18 [PATCH v2 0/*] xen: xen-domid-restrict improvements Ian Jackson
2017-10-04 16:18 ` [PATCH 1/8] xen: link against xentoolcore Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019164728.GC11934@perard.uk.xensource.com \
--to=anthony.perard@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=qemu-devel@nongnu.org \
--cc=ross.lagerwall@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).