From: Julien Grall <julien.grall@linaro.org>
To: xen-devel@lists.xen.org
Cc: Julien Grall <julien.grall@linaro.org>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v3 for-next 2/4] xen/arm32: mm: Rework is_xen_heap_page to avoid nameclash
Date: Wed, 1 Nov 2017 14:03:14 +0000 [thread overview]
Message-ID: <20171101140316.31333-3-julien.grall@linaro.org> (raw)
In-Reply-To: <20171101140316.31333-1-julien.grall@linaro.org>
The arm32 version of the function is_xen_heap_page currently define a
variable _mfn. This will lead to a compiler when use typesafe MFN in a
follow-up patch:
called object '_mfn' is not a function or function pointer
Fix it by renaming the local variable _mfn to mfn_.
Signed-off-by: Julien Grall <julien.grall@linaro.org>
---
Cc: Stefano Stabellini <sstabellini@kernel.org>
Changes in v3:
- Fix typo in the commit message
---
xen/include/asm-arm/mm.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h
index cd6dfb54b9..737a429409 100644
--- a/xen/include/asm-arm/mm.h
+++ b/xen/include/asm-arm/mm.h
@@ -140,9 +140,9 @@ extern vaddr_t xenheap_virt_start;
#ifdef CONFIG_ARM_32
#define is_xen_heap_page(page) is_xen_heap_mfn(page_to_mfn(page))
#define is_xen_heap_mfn(mfn) ({ \
- unsigned long _mfn = (mfn); \
- (_mfn >= mfn_x(xenheap_mfn_start) && \
- _mfn < mfn_x(xenheap_mfn_end)); \
+ unsigned long mfn_ = (mfn); \
+ (mfn_ >= mfn_x(xenheap_mfn_start) && \
+ mfn_ < mfn_x(xenheap_mfn_end)); \
})
#else
#define is_xen_heap_page(page) ((page)->count_info & PGC_xen_heap)
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-11-01 14:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 14:03 [PATCH v3 for-next 0/4] xen: Convert __page_to_mfn and _mfn_to_page to use typesafe MFN Julien Grall
2017-11-01 14:03 ` [PATCH v3 for-next 1/4] xen/arm: domain_build: Clean-up insert_11_bank Julien Grall
2017-12-11 23:25 ` Stefano Stabellini
2017-11-01 14:03 ` Julien Grall [this message]
2017-12-11 23:25 ` [PATCH v3 for-next 2/4] xen/arm32: mm: Rework is_xen_heap_page to avoid nameclash Stefano Stabellini
2017-11-01 14:03 ` [PATCH v3 for-next 3/4] xen/tmem: Convert the file common/tmem_xen.c to use typesafe MFN Julien Grall
2017-11-01 18:54 ` Konrad Rzeszutek Wilk
2017-11-02 15:18 ` Julien Grall
2017-11-01 14:03 ` [PATCH v3 for-next 4/4] xen: Convert __page_to_mfn and __mfn_to_page " Julien Grall
2017-11-01 15:35 ` Paul Durrant
2017-11-01 15:43 ` Razvan Cojocaru
2017-11-01 18:38 ` Boris Ostrovsky
2017-11-02 2:52 ` Tian, Kevin
2017-11-02 8:35 ` Tim Deegan
2017-12-11 23:36 ` Stefano Stabellini
2017-11-06 11:37 ` [PATCH v3 for-next 0/4] xen: Convert __page_to_mfn and _mfn_to_page " Jan Beulich
2017-11-06 11:47 ` Julien Grall
2017-11-06 12:11 ` Jan Beulich
2017-11-06 12:16 ` Julien Grall
2017-11-06 12:44 ` Jan Beulich
2017-11-09 15:20 ` Julien Grall
2017-11-09 15:36 ` Jan Beulich
2017-11-09 15:39 ` Julien Grall
2017-11-09 15:47 ` Jan Beulich
2017-11-09 15:48 ` Julien Grall
2017-11-09 16:12 ` Jan Beulich
2017-12-11 23:37 ` Stefano Stabellini
2017-12-11 23:53 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101140316.31333-3-julien.grall@linaro.org \
--to=julien.grall@linaro.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).