From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v3 for-next 3/4] xen/tmem: Convert the file common/tmem_xen.c to use typesafe MFN Date: Wed, 1 Nov 2017 14:54:29 -0400 Message-ID: <20171101185429.GC20519@char.us.oracle.com> References: <20171101140316.31333-1-julien.grall@linaro.org> <20171101140316.31333-4-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20171101140316.31333-4-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Julien Grall Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBOb3YgMDEsIDIwMTcgYXQgMDI6MDM6MTVQTSArMDAwMCwgSnVsaWVuIEdyYWxsIHdy b3RlOgo+IFRoZSBmaWxlIGNvbW1vbi90bWVtX3hlbi5jIGlzIG5vdyBjb252ZXJ0ZWQgdG8gdXNl IHR5cGVzYWZlLiBUaGlzIGlzCj4gcmVxdWlyaW5nIHRvIG92ZXJyaWRlIHRoZSBtYWNybyBwYWdl X3RvX21mbiB0byBtYWtlIGl0IHdvcmsgd2l0aCBtZm5fdC4KPiAKPiBOb3RlIHRoYXQgYWxsIHZh cmlhYmxlcyBjb252ZXJ0ZWQgdG8gbWZuX3QgaGF2ZW0gdGhlcmUgaW5pdGlhbCB2YWx1ZSwKPiB3 aGVuIHNldCwgc3dpdGNoIGZyb20gMCB0byBJTlZBTElEX01GTi4gVGhpcyBpcyBmaW5lIGJlY2F1 c2UgdGhlIGluaXRpYWwKPiB2YWx1ZXMgd2FzIGFsd2F5cyBvdmVycmlkZW4gYmVmb3JlIHVzZWQu Cj4gCj4gQWxzbyBhZGQgYSBjb3VwbGUgb2YgbWlzc2luZyBuZXdsaW5lcyBzdWdnZXN0ZWQgYnkg QW5kcmV3IGluIHRoZSBjb2RlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEp1bGllbiBHcmFsbCA8anVs aWVuLmdyYWxsQGxpbmFyby5vcmc+Cj4gUmV2aWV3ZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJl dy5jb29wZXIzQGNpdHJpeC5jb20+Cj4gCj4gLS0tCj4gCj4gQ2M6IEtvbnJhZCBSemVzenV0ZWsg V2lsayA8a29ucmFkLndpbGtAb3JhY2xlLmNvbT4KCgpBY2tlZC1ieTogS29ucmFkIFJ6ZXN6dXRl ayBXaWxrIDxrb25yYWQud2lsa0BvcmFjbGUuY29tPgoKQnV0IGNvdWxkIHlvdSBjb25maXJtIHRo YXQgeW91IGRpZCBjb21waWxlIHRoaXMgb24geDg2IGFuZCB3aXRoIENPTkZJR19UTUVNPXkgaW4g dGhlIC5jb25maWc/CgpUaGFua3MhCgo+IAo+ICAgICBDaGFuZ2VzIGluIHYyOgo+ICAgICAgICAg LSBBZGQgbWlzc2luZyBuZXdsaW5lcwo+ICAgICAgICAgLSBBZGQgQW5kcmV3J3MgcmV2aWV3ZWQt YnkKPiAtLS0KPiAgeGVuL2NvbW1vbi90bWVtX3hlbi5jIHwgMzAgKysrKysrKysrKysrKysrKysr LS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAxMiBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEveGVuL2NvbW1vbi90bWVtX3hlbi5jIGIveGVuL2Nv bW1vbi90bWVtX3hlbi5jCj4gaW5kZXggMjBmNzRiMjY4Zi4uYmQ1MmU0NGZhZiAxMDA2NDQKPiAt LS0gYS94ZW4vY29tbW9uL3RtZW1feGVuLmMKPiArKysgYi94ZW4vY29tbW9uL3RtZW1feGVuLmMK PiBAQCAtMTQsNiArMTQsMTAgQEAKPiAgI2luY2x1ZGUgPHhlbi9jcHUuaD4KPiAgI2luY2x1ZGUg PHhlbi9pbml0Lmg+Cj4gIAo+ICsvKiBPdmVycmlkZSBtYWNyb3MgZnJvbSBhc20vcGFnZS5oIHRv IG1ha2UgdGhlbSB3b3JrIHdpdGggbWZuX3QgKi8KPiArI3VuZGVmIHBhZ2VfdG9fbWZuCj4gKyNk ZWZpbmUgcGFnZV90b19tZm4ocGcpIF9tZm4oX19wYWdlX3RvX21mbihwZykpCj4gKwo+ICBib29s IF9fcmVhZF9tb3N0bHkgb3B0X3RtZW07Cj4gIGJvb2xlYW5fcGFyYW0oInRtZW0iLCBvcHRfdG1l bSk7Cj4gIAo+IEBAIC0zMSw3ICszNSw3IEBAIHN0YXRpYyBERUZJTkVfUEVSX0NQVV9SRUFEX01P U1RMWSh1bnNpZ25lZCBjaGFyICosIGRzdG1lbSk7Cj4gIHN0YXRpYyBERUZJTkVfUEVSX0NQVV9S RUFEX01PU1RMWSh2b2lkICosIHNjcmF0Y2hfcGFnZSk7Cj4gIAo+ICAjaWYgZGVmaW5lZChDT05G SUdfQVJNKQo+IC1zdGF0aWMgaW5saW5lIHZvaWQgKmNsaV9nZXRfcGFnZSh4ZW5fcGZuX3QgY21m biwgdW5zaWduZWQgbG9uZyAqcGNsaV9tZm4sCj4gK3N0YXRpYyBpbmxpbmUgdm9pZCAqY2xpX2dl dF9wYWdlKHhlbl9wZm5fdCBjbWZuLCBtZm5fdCAqcGNsaV9tZm4sCj4gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHN0cnVjdCBwYWdlX2luZm8gKipwY2xpX3BmcCwgYm9vbCBjbGlf d3JpdGUpCj4gIHsKPiAgICAgIEFTU0VSVF9VTlJFQUNIQUJMRSgpOwo+IEBAIC0zOSwxNCArNDMs MTQgQEAgc3RhdGljIGlubGluZSB2b2lkICpjbGlfZ2V0X3BhZ2UoeGVuX3Bmbl90IGNtZm4sIHVu c2lnbmVkIGxvbmcgKnBjbGlfbWZuLAo+ICB9Cj4gIAo+ICBzdGF0aWMgaW5saW5lIHZvaWQgY2xp X3B1dF9wYWdlKHZvaWQgKmNsaV92YSwgc3RydWN0IHBhZ2VfaW5mbyAqY2xpX3BmcCwKPiAtICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIGNsaV9tZm4sIGJvb2wg bWFya19kaXJ0eSkKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtZm5fdCBjbGlf bWZuLCBib29sIG1hcmtfZGlydHkpCj4gIHsKPiAgICAgIEFTU0VSVF9VTlJFQUNIQUJMRSgpOwo+ ICB9Cj4gICNlbHNlCj4gICNpbmNsdWRlIDxhc20vcDJtLmg+Cj4gIAo+IC1zdGF0aWMgaW5saW5l IHZvaWQgKmNsaV9nZXRfcGFnZSh4ZW5fcGZuX3QgY21mbiwgdW5zaWduZWQgbG9uZyAqcGNsaV9t Zm4sCj4gK3N0YXRpYyBpbmxpbmUgdm9pZCAqY2xpX2dldF9wYWdlKHhlbl9wZm5fdCBjbWZuLCBt Zm5fdCAqcGNsaV9tZm4sCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVj dCBwYWdlX2luZm8gKipwY2xpX3BmcCwgYm9vbCBjbGlfd3JpdGUpCj4gIHsKPiAgICAgIHAybV90 eXBlX3QgdDsKPiBAQCAtNjgsMTYgKzcyLDE3IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCAqY2xpX2dl dF9wYWdlKHhlbl9wZm5fdCBjbWZuLCB1bnNpZ25lZCBsb25nICpwY2xpX21mbiwKPiAgCj4gICAg ICAqcGNsaV9tZm4gPSBwYWdlX3RvX21mbihwYWdlKTsKPiAgICAgICpwY2xpX3BmcCA9IHBhZ2U7 Cj4gLSAgICByZXR1cm4gbWFwX2RvbWFpbl9wYWdlKF9tZm4oKnBjbGlfbWZuKSk7Cj4gKwo+ICsg ICAgcmV0dXJuIG1hcF9kb21haW5fcGFnZSgqcGNsaV9tZm4pOwo+ICB9Cj4gIAo+ICBzdGF0aWMg aW5saW5lIHZvaWQgY2xpX3B1dF9wYWdlKHZvaWQgKmNsaV92YSwgc3RydWN0IHBhZ2VfaW5mbyAq Y2xpX3BmcCwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25n IGNsaV9tZm4sIGJvb2wgbWFya19kaXJ0eSkKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBtZm5fdCBjbGlfbWZuLCBib29sIG1hcmtfZGlydHkpCj4gIHsKPiAgICAgIGlmICggbWFy a19kaXJ0eSApCj4gICAgICB7Cj4gICAgICAgICAgcHV0X3BhZ2VfYW5kX3R5cGUoY2xpX3BmcCk7 Cj4gLSAgICAgICAgcGFnaW5nX21hcmtfZGlydHkoY3VycmVudC0+ZG9tYWluLCBfbWZuKGNsaV9t Zm4pKTsKPiArICAgICAgICBwYWdpbmdfbWFya19kaXJ0eShjdXJyZW50LT5kb21haW4sIGNsaV9t Zm4pOwo+ICAgICAgfQo+ICAgICAgZWxzZQo+ICAgICAgICAgIHB1dF9wYWdlKGNsaV9wZnApOwo+ IEBAIC04OCwxNCArOTMsMTQgQEAgc3RhdGljIGlubGluZSB2b2lkIGNsaV9wdXRfcGFnZSh2b2lk ICpjbGlfdmEsIHN0cnVjdCBwYWdlX2luZm8gKmNsaV9wZnAsCj4gIGludCB0bWVtX2NvcHlfZnJv bV9jbGllbnQoc3RydWN0IHBhZ2VfaW5mbyAqcGZwLAo+ICAgICAgeGVuX3Bmbl90IGNtZm4sIHRt ZW1fY2xpX3ZhX3BhcmFtX3QgY2xpYnVmKQo+ICB7Cj4gLSAgICB1bnNpZ25lZCBsb25nIHRtZW1f bWZuLCBjbGlfbWZuID0gMDsKPiArICAgIG1mbl90IHRtZW1fbWZuLCBjbGlfbWZuID0gSU5WQUxJ RF9NRk47Cj4gICAgICBjaGFyICp0bWVtX3ZhLCAqY2xpX3ZhID0gTlVMTDsKPiAgICAgIHN0cnVj dCBwYWdlX2luZm8gKmNsaV9wZnAgPSBOVUxMOwo+ICAgICAgaW50IHJjID0gMTsKPiAgCj4gICAg ICBBU1NFUlQocGZwICE9IE5VTEwpOwo+ICAgICAgdG1lbV9tZm4gPSBwYWdlX3RvX21mbihwZnAp Owo+IC0gICAgdG1lbV92YSA9IG1hcF9kb21haW5fcGFnZShfbWZuKHRtZW1fbWZuKSk7Cj4gKyAg ICB0bWVtX3ZhID0gbWFwX2RvbWFpbl9wYWdlKHRtZW1fbWZuKTsKPiAgICAgIGlmICggZ3Vlc3Rf aGFuZGxlX2lzX251bGwoY2xpYnVmKSApCj4gICAgICB7Cj4gICAgICAgICAgY2xpX3ZhID0gY2xp X2dldF9wYWdlKGNtZm4sICZjbGlfbWZuLCAmY2xpX3BmcCwgMCk7Cj4gQEAgLTEyNSw3ICsxMzAs NyBAQCBpbnQgdG1lbV9jb21wcmVzc19mcm9tX2NsaWVudCh4ZW5fcGZuX3QgY21mbiwKPiAgICAg IHVuc2lnbmVkIGNoYXIgKndtZW0gPSB0aGlzX2NwdSh3b3JrbWVtKTsKPiAgICAgIGNoYXIgKnNj cmF0Y2ggPSB0aGlzX2NwdShzY3JhdGNoX3BhZ2UpOwo+ICAgICAgc3RydWN0IHBhZ2VfaW5mbyAq Y2xpX3BmcCA9IE5VTEw7Cj4gLSAgICB1bnNpZ25lZCBsb25nIGNsaV9tZm4gPSAwOwo+ICsgICAg bWZuX3QgY2xpX21mbiA9IElOVkFMSURfTUZOOwo+ICAgICAgdm9pZCAqY2xpX3ZhID0gTlVMTDsK PiAgCj4gICAgICBpZiAoIGRtZW0gPT0gTlVMTCB8fCB3bWVtID09IE5VTEwgKQo+IEBAIC0xNTIs NyArMTU3LDcgQEAgaW50IHRtZW1fY29tcHJlc3NfZnJvbV9jbGllbnQoeGVuX3Bmbl90IGNtZm4s Cj4gIGludCB0bWVtX2NvcHlfdG9fY2xpZW50KHhlbl9wZm5fdCBjbWZuLCBzdHJ1Y3QgcGFnZV9p bmZvICpwZnAsCj4gICAgICB0bWVtX2NsaV92YV9wYXJhbV90IGNsaWJ1ZikKPiAgewo+IC0gICAg dW5zaWduZWQgbG9uZyB0bWVtX21mbiwgY2xpX21mbiA9IDA7Cj4gKyAgICBtZm5fdCB0bWVtX21m biwgY2xpX21mbiA9IElOVkFMSURfTUZOOwo+ICAgICAgY2hhciAqdG1lbV92YSwgKmNsaV92YSA9 IE5VTEw7Cj4gICAgICBzdHJ1Y3QgcGFnZV9pbmZvICpjbGlfcGZwID0gTlVMTDsKPiAgICAgIGlu dCByYyA9IDE7Cj4gQEAgLTE2NSw3ICsxNzAsOCBAQCBpbnQgdG1lbV9jb3B5X3RvX2NsaWVudCh4 ZW5fcGZuX3QgY21mbiwgc3RydWN0IHBhZ2VfaW5mbyAqcGZwLAo+ICAgICAgICAgICAgICByZXR1 cm4gLUVGQVVMVDsKPiAgICAgIH0KPiAgICAgIHRtZW1fbWZuID0gcGFnZV90b19tZm4ocGZwKTsK PiAtICAgIHRtZW1fdmEgPSBtYXBfZG9tYWluX3BhZ2UoX21mbih0bWVtX21mbikpOwo+ICsgICAg dG1lbV92YSA9IG1hcF9kb21haW5fcGFnZSh0bWVtX21mbik7Cj4gKwo+ICAgICAgaWYgKCBjbGlf dmEgKQo+ICAgICAgewo+ICAgICAgICAgIG1lbWNweShjbGlfdmEsIHRtZW1fdmEsIFBBR0VfU0la RSk7Cj4gQEAgLTE4MSw3ICsxODcsNyBAQCBpbnQgdG1lbV9jb3B5X3RvX2NsaWVudCh4ZW5fcGZu X3QgY21mbiwgc3RydWN0IHBhZ2VfaW5mbyAqcGZwLAo+ICBpbnQgdG1lbV9kZWNvbXByZXNzX3Rv X2NsaWVudCh4ZW5fcGZuX3QgY21mbiwgdm9pZCAqdG1lbV92YSwKPiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgc2l6ZV90IHNpemUsIHRtZW1fY2xpX3ZhX3BhcmFtX3QgY2xp YnVmKQo+ICB7Cj4gLSAgICB1bnNpZ25lZCBsb25nIGNsaV9tZm4gPSAwOwo+ICsgICAgbWZuX3Qg Y2xpX21mbiA9IElOVkFMSURfTUZOOwo+ICAgICAgc3RydWN0IHBhZ2VfaW5mbyAqY2xpX3BmcCA9 IE5VTEw7Cj4gICAgICB2b2lkICpjbGlfdmEgPSBOVUxMOwo+ICAgICAgY2hhciAqc2NyYXRjaCA9 IHRoaXNfY3B1KHNjcmF0Y2hfcGFnZSk7Cj4gLS0gCj4gMi4xMS4wCj4gCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0 Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK