From: Owen Smith <owen.smith@citrix.com>
To: sstabellini@kernel.org, anthony.perard@citrix.com, kraxel@redhat.com
Cc: xen-devel@lists.xenproject.org, qemu-devel@nongnu.org,
owen.smith@citrix.com
Subject: [PATCH v5 4/4] xenfb: activate input handlers for raw pointer devices
Date: Fri, 3 Nov 2017 11:56:31 +0000 [thread overview]
Message-ID: <20171103115631.15175-5-owen.smith@citrix.com> (raw)
In-Reply-To: <20171103115631.15175-1-owen.smith@citrix.com>
If the frontend requests raw pointers, the input handlers must be
activated to have the input events delivered to the xenfb backend.
Without activation, the input events are delivered to handlers
registered earlier, which would be the emulated USB tablet or
emulated PS/2 mouse.
HVM xen_kbdfront can incorrectly scale absolute coordinates when
the display resolution is not 800x600.
Signed-off-by: Owen Smith <owen.smith@citrix.com>
---
hw/display/xenfb.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c
index 3cbc248c34..c070c84f5b 100644
--- a/hw/display/xenfb.c
+++ b/hw/display/xenfb.c
@@ -387,6 +387,11 @@ static void input_connected(struct XenDevice *xendev)
in->qkbd = qemu_input_handler_register((DeviceState *)in, &xenfb_keyboard);
in->qmou = qemu_input_handler_register((DeviceState *)in,
in->abs_pointer_wanted ? &xenfb_abs_mouse : &xenfb_rel_mouse);
+
+ if (in->raw_pointer_wanted) {
+ qemu_input_handler_activate(in->qkbd);
+ qemu_input_handler_activate(in->qmou);
+ }
}
static void input_disconnect(struct XenDevice *xendev)
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-11-03 11:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 11:56 [PATCH v5 0/4] xenfb: Enablement for Windows PV HID frontend Owen Smith
2017-11-03 11:56 ` [PATCH v5 1/4] ui: generate qcode to linux mappings Owen Smith
2017-11-03 11:56 ` [PATCH v5 2/4] xenfb: Use Input Handlers directly Owen Smith
2017-11-03 11:56 ` [PATCH v5 3/4] xenfb: Add [feature|request]-raw-pointer Owen Smith
2017-11-03 11:56 ` Owen Smith [this message]
2017-11-08 10:21 ` [PATCH v5 0/4] xenfb: Enablement for Windows PV HID frontend Gerd Hoffmann
2017-11-08 10:53 ` Owen Smith
2017-12-11 16:58 ` Anthony PERARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171103115631.15175-5-owen.smith@citrix.com \
--to=owen.smith@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).