From: Brian Woods <brian.woods@amd.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xen.org,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Brian Woods <brian.woods@amd.com>
Subject: Re: [PATCH v2 1/2] x86/svm: Add virtual GIF feature definition
Date: Thu, 16 Nov 2017 12:01:13 -0600 [thread overview]
Message-ID: <20171116180112.GA3632@amd.com> (raw)
In-Reply-To: <20171116174427.GJ21113@char.us.oracle.com>
On Thu, Nov 16, 2017 at 12:44:27PM -0500, Konrad Rzeszutek Wilk wrote:
> The patch says 'v2', but I don't see anything having changed here.
>
> Usually one adds comments in here (right after ---) with something
> to the effect of:
>
> v1: New version
> v2: Nothing new.
>
> Or if something did change (like in second patch), you say exactly what changed.
>
> Thanks!
Sorry about forgetting that. I'll make sure to do that in the future.
The change log for this one was:
- Change the test condition from if it had the vgif feature to if it's
enabled in the vmcb
- Update for the use of C99 bool type
There was some discussion in the irc channel so I'm not sure if there's
going be another version soon or not. I need to fix the style error I
have with the else anyway.
Thank you for the feedback.
--
Brian Woods
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-11-16 18:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 17:19 [PATCH v2 0/2] Virtual GIF Brian Woods
2017-11-16 17:19 ` [PATCH v2 1/2] x86/svm: Add virtual GIF feature definition Brian Woods
2017-11-16 17:44 ` Konrad Rzeszutek Wilk
2017-11-16 18:01 ` Brian Woods [this message]
2017-11-16 17:19 ` [PATCH v2 2/2] x86/svm: Add virtual GIF support Brian Woods
2017-11-16 19:17 ` [PATCH v2 0/2] Virtual GIF Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171116180112.GA3632@amd.com \
--to=brian.woods@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).