From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 1/3 v3] xen: Refactor 16550 UART code Date: Fri, 24 Nov 2017 08:37:52 -0500 Message-ID: <20171124133750.GC16160@localhost.localdomain> References: <1511523552-23628-1-git-send-email-bhupinder.thakur@linaro.org> <1511523552-23628-2-git-send-email-bhupinder.thakur@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIEB8-0001zc-EX for xen-devel@lists.xenproject.org; Fri, 24 Nov 2017 13:38:02 +0000 Received: by mail-qk0-f196.google.com with SMTP id 136so24568752qkd.4 for ; Fri, 24 Nov 2017 05:37:57 -0800 (PST) Content-Disposition: inline In-Reply-To: <1511523552-23628-2-git-send-email-bhupinder.thakur@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Bhupinder Thakur Cc: Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Julien Grall , Jan Beulich , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBOb3YgMjQsIDIwMTcgYXQgMDU6MDk6MTBQTSArMDUzMCwgQmh1cGluZGVyIFRoYWt1 ciB3cm90ZToKPiBUaGlzIHBhdGNoIHJlZmFjdG9ycyB0aGUgODI1MCBVQVJUIGNvZGUgc28gdGhh dCBjb2RlIGNhbiBiZSByZXVzZWQKPiBieSBsYXRlciBwYXRjaGVzLCB3aGljaCBhZGQgc3VwcG9y dCBmb3IgQUNQSSBiYXNlZCBVQVJUCj4gaW5pdGlhbGl6YXRpb24uCj4gCj4gU2lnbmVkLW9mZi1i eTogQmh1cGluZGVyIFRoYWt1ciA8Ymh1cGluZGVyLnRoYWt1ckBsaW5hcm8ub3JnPgo+IC0tLQo+ IENoYW5nZXMgc2luY2UgdjI6Cj4gLSBSZWZhY3RvcmVkIHRoZSBjb2RlIHRvIHByZXBhcmUgZm9y IGxhdGVyIHBhdGNoZXMuCj4gCj4gQ0M6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNp dHJpeC5jb20+Cj4gQ0M6IEdlb3JnZSBEdW5sYXAgPEdlb3JnZS5EdW5sYXBAZXUuY2l0cml4LmNv bT4KPiBDQzogSWFuIEphY2tzb24gPGlhbi5qYWNrc29uQGV1LmNpdHJpeC5jb20+Cj4gQ0M6IEph biBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KPiBDQzogS29ucmFkIFJ6ZXN6dXRlayBXaWxr IDxrb25yYWQud2lsa0BvcmFjbGUuY29tPgo+IENDOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFi ZWxsaW5pQGtlcm5lbC5vcmc+Cj4gQ0M6IFRpbSBEZWVnYW4gPHRpbUB4ZW4ub3JnPgo+IENDOiBX ZWkgTGl1IDx3ZWkubGl1MkBjaXRyaXguY29tPgo+IENDOiBKdWxpZW4gR3JhbGwgPGp1bGllbi5n cmFsbEBhcm0uY29tPgo+IAo+ICB4ZW4vZHJpdmVycy9jaGFyL25zMTY1NTAuYyB8IDUzICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5n ZWQsIDQwIGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS94 ZW4vZHJpdmVycy9jaGFyL25zMTY1NTAuYyBiL3hlbi9kcml2ZXJzL2NoYXIvbnMxNjU1MC5jCj4g aW5kZXggZTBmODE5OS4uYzVkZmMxZSAxMDA2NDQKPiAtLS0gYS94ZW4vZHJpdmVycy9jaGFyL25z MTY1NTAuYwo+ICsrKyBiL3hlbi9kcml2ZXJzL2NoYXIvbnMxNjU1MC5jCj4gQEAgLTE0NjIsMTYg KzE0NjIsMzIgQEAgdm9pZCBfX2luaXQgbnMxNjU1MF9pbml0KGludCBpbmRleCwgc3RydWN0IG5z MTY1NTBfZGVmYXVsdHMgKmRlZmF1bHRzKQo+ICAgICAgbnMxNjU1MF9wYXJzZV9wb3J0X2NvbmZp Zyh1YXJ0LCAoaW5kZXggPT0gMCkgPyBvcHRfY29tMSA6IG9wdF9jb20yKTsKPiAgfQo+ICAKPiAr I2lmZGVmIENPTkZJR19BUk0KPiArc3RhdGljIHZvaWQgbnMxNjU1MF92dWFydF9pbml0KHN0cnVj dCBuczE2NTUwICp1YXJ0KQo+ICt7Cj4gKyAgICB1YXJ0LT52dWFydC5iYXNlX2FkZHIgICA9IHVh cnQtPmlvX2Jhc2U7Cj4gKyAgICB1YXJ0LT52dWFydC5zaXplICAgICAgICA9IHVhcnQtPmlvX3Np emU7Cj4gKyAgICB1YXJ0LT52dWFydC5kYXRhX29mZiAgICA9IFVBUlRfVEhSIDw8IHVhcnQtPnJl Z19zaGlmdDsKPiArICAgIHVhcnQtPnZ1YXJ0LnN0YXR1c19vZmYgID0gVUFSVF9MU1IgPDwgdWFy dC0+cmVnX3NoaWZ0Owo+ICsgICAgdWFydC0+dnVhcnQuc3RhdHVzICAgICAgPSBVQVJUX0xTUl9U SFJFIHwgVUFSVF9MU1JfVEVNVDsKPiArfQo+ICsjZW5kaWYKPiArCj4gK3N0YXRpYyB2b2lkIG5z MTY1NTBfcmVnaXN0ZXJfdWFydChzdHJ1Y3QgbnMxNjU1MCAqdWFydCkKPiArewo+ICsgICAgLyog UmVnaXN0ZXIgd2l0aCBnZW5lcmljIHNlcmlhbCBkcml2ZXIuICovCj4gKyAgICBzZXJpYWxfcmVn aXN0ZXJfdWFydCh1YXJ0IC0gbnMxNjU1MF9jb20sICZuczE2NTUwX2RyaXZlciwgdWFydCk7Cj4g K30KPiArCj4gICNpZmRlZiBDT05GSUdfSEFTX0RFVklDRV9UUkVFCj4gLXN0YXRpYyBpbnQgX19p bml0IG5zMTY1NTBfdWFydF9kdF9pbml0KHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqZGV2LAo+IC0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCB2b2lkICpkYXRhKQo+ ICsKPiArc3RhdGljIGludCBuczE2NTUwX2luaXRfZHQoc3RydWN0IG5zMTY1NTAgKipwdWFydCwK PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IGR0X2RldmljZV9ub2Rl ICpkZXYpCj4gIHsKPiAtICAgIHN0cnVjdCBuczE2NTUwICp1YXJ0Owo+ICAgICAgaW50IHJlczsK PiAgICAgIHUzMiByZWdfc2hpZnQsIHJlZ193aWR0aDsKPiAgICAgIHU2NCBpb19zaXplOwo+IC0K PiAtICAgIHVhcnQgPSAmbnMxNjU1MF9jb21bMF07Cj4gKyAgICBzdHJ1Y3QgbnMxNjU1MCAqdWFy dCA9ICZuczE2NTUwX2NvbVswXTsKCkkgYW0gc3VyZSBJIHVuZGVyc3RhbmQgdGhpcyBjaGFuZ2Uu IEluIHRoZSAjMiBwYXRjaCB5b3UgYXJlIGRvaW5nCnRoaXMgdGhlIG9sZCB3YXk6CgogK3N0YXRp YyBpbnQgbnMxNjU1MF9pbml0X2FjcGkoc3RydWN0IG5zMTY1NTAgKipwdWFydCkKK3sKKyAgICBz dHJ1Y3QgYWNwaV90YWJsZV9zcGNyICpzcGNyOworICAgIGludCBzdGF0dXM7CisgICAgc3RydWN0 IG5zMTY1NTAgKnVhcnQgPSAmbnMxNjU1MF9jb21bMF07CgpBbnkgcGFydGljdWxhciByZXNhb24g Zm9yIHRoaXMgY2hhbmdlPwoKSWYgeW91IGNhbiByZXN0b3JlIHRoaXMgdG8gdGhlIG9yaWdpbmFs IHdheSBpbiB0aGlzIGZ1bmN0aW9uIHlvdQpjYW4gcHV0OgoKUmV2aWV3ZWQtYnk6IEtvbnJhZCBS emVzenV0ZWsgV2lsayA8a29ucmFkLndpbGtAb3JhY2xlLmNvbT4KPiAgCj4gICAgICBuczE2NTUw X2luaXRfY29tbW9uKHVhcnQpOwo+ICAKPiBAQCAtMTUxMCwxOCArMTUyNiwyOSBAQCBzdGF0aWMg aW50IF9faW5pdCBuczE2NTUwX3VhcnRfZHRfaW5pdChzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmRl diwKPiAgCj4gICAgICB1YXJ0LT5kd191c3JfYnN5ID0gZHRfZGV2aWNlX2lzX2NvbXBhdGlibGUo ZGV2LCAic25wcyxkdy1hcGItdWFydCIpOwo+ICAKPiAtICAgIHVhcnQtPnZ1YXJ0LmJhc2VfYWRk ciA9IHVhcnQtPmlvX2Jhc2U7Cj4gLSAgICB1YXJ0LT52dWFydC5zaXplID0gdWFydC0+aW9fc2l6 ZTsKPiAtICAgIHVhcnQtPnZ1YXJ0LmRhdGFfb2ZmID0gVUFSVF9USFIgPDx1YXJ0LT5yZWdfc2hp ZnQ7Cj4gLSAgICB1YXJ0LT52dWFydC5zdGF0dXNfb2ZmID0gVUFSVF9MU1I8PHVhcnQtPnJlZ19z aGlmdDsKPiAtICAgIHVhcnQtPnZ1YXJ0LnN0YXR1cyA9IFVBUlRfTFNSX1RIUkV8VUFSVF9MU1Jf VEVNVDsKPiArICAgICpwdWFydCA9IHVhcnQ7Cj4gIAo+IC0gICAgLyogUmVnaXN0ZXIgd2l0aCBn ZW5lcmljIHNlcmlhbCBkcml2ZXIuICovCj4gLSAgICBzZXJpYWxfcmVnaXN0ZXJfdWFydCh1YXJ0 IC0gbnMxNjU1MF9jb20sICZuczE2NTUwX2RyaXZlciwgdWFydCk7Cj4gKyAgICByZXR1cm4gMDsK PiArfQo+ICsKPiArc3RhdGljIGludCBfX2luaXQgbnMxNjU1MF91YXJ0X2R0X2luaXQoc3RydWN0 IGR0X2RldmljZV9ub2RlICpkZXYsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGNvbnN0IHZvaWQgKmRhdGEpCj4gK3sKPiArICAgIHN0cnVjdCBuczE2NTUwICp1YXJ0 Owo+ICsgICAgaW50IHJldDsKPiArCj4gKyAgICByZXQgPSBuczE2NTUwX2luaXRfZHQoJnVhcnQs IGRhdGEpOwo+ICsKPiArICAgIGlmICggcmV0ICkKPiArICAgICAgICByZXR1cm4gcmV0Owo+ICsK PiArICAgIG5zMTY1NTBfdnVhcnRfaW5pdCh1YXJ0KTsKPiArCj4gKyAgICBuczE2NTUwX3JlZ2lz dGVyX3VhcnQodWFydCk7Cj4gIAo+ICAgICAgZHRfZGV2aWNlX3NldF91c2VkX2J5KGRldiwgRE9N SURfWEVOKTsKPiAgCj4gLSAgICByZXR1cm4gMDsKPiArICAgIHJldHVybiByZXQ7Cj4gIH0KPiAg Cj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHRfZGV2aWNlX21hdGNoIG5zMTY1NTBfZHRfbWF0Y2hb XSBfX2luaXRjb25zdCA9Cj4gLS0gCj4gMi43LjQKPiAKPiAKPiBfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IFhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKPiBY ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKPiBodHRwczovL2xpc3RzLnhlbnByb2plY3Qu b3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVsCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBs aXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4v bGlzdGluZm8veGVuLWRldmVs