From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH] migration, xen: Fix block image lock issue on live migration Date: Mon, 27 Nov 2017 15:00:42 +0000 Message-ID: <20171127150042.GA2004@perard.uk.xensource.com> References: <20171122084504.11984-1-quintela@redhat.com> <20171122084504.11984-2-quintela@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJKtu-0005IK-83 for xen-devel@lists.xenproject.org; Mon, 27 Nov 2017 15:00:50 +0000 Content-Disposition: inline In-Reply-To: <20171122084504.11984-2-quintela@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Julien Grall Cc: xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org SGkgSnVsaWVuLAoKQ2FuIEkgZ2V0IGEgcmVsZWFzZS1hY2sgZm9yIHRoaXMgcGF0Y2g/CgpUaGlz IGZpeCBsb2NhbCBsaXZlIG1pZ3JhdGlvbiBvZiBIVk0gZ3Vlc3Qgd2hlbiB0aGUgZGlzayBiYWNr ZW5kIGlzCnFkaXNrLiAgb3NzdGVzdCBkb2Vzbid0IHJlcG9ydCBhIHJlZ3Jlc3Npb24gYmVjYXVz ZSB0aGUga2VybmVsIG9yIHRoZQpnbGliYyBpcyBqdXN0IGEgYml0IHRvbyBvbGQuCgpUaGFua3Ms CgoKT24gV2VkLCBOb3YgMjIsIDIwMTcgYXQgMDk6NDU6MDNBTSArMDEwMCwgSnVhbiBRdWludGVs YSB3cm90ZToKPiBGcm9tOiBBbnRob255IFBFUkFSRCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNv bT4KPiAKPiBXaGVuIGRvaW5nIGEgbGl2ZSBtaWdyYXRpb24gb2YgYSBYZW4gZ3Vlc3Qgd2l0aCBs aWJ4bCwgdGhlIGltYWdlcyBmb3IKPiBibG9jayBkZXZpY2VzIGFyZSBsb2NrZWQgYnkgdGhlIG9y aWdpbmFsIFFFTVUgcHJvY2VzcywgYW5kIHRoaXMgcHJldmVudAo+IHRoZSBRRU1VIGF0IHRoZSBk ZXN0aW5hdGlvbiB0byB0YWtlIHRoZSBsb2NrIGFuZCB0aGUgbWlncmF0aW9uIGZhaWwuCj4gCj4g PkZyb20gUUVNVSBwb2ludCBvZiB2aWV3LCBvbmNlIHRoZSBSQU0gb2YgYSBkb21haW4gaXMgbWln cmF0ZWQsIHRoZXJlIGlzCj4gdHdvIFFNUCBjb21tYW5kcywgInN0b3AiIHRoZW4gInhlbi1zYXZl LWRldmljZXMtc3RhdGUiLCBhdCB3aGljaCBwb2ludCBhCj4gbmV3IFFFTVUgaXMgc3Bhd25lZCBh dCB0aGUgZGVzdGluYXRpb24uCj4gCj4gUmVsZWFzZSBsb2NrcyBpbiAieGVuLXNhdmUtZGV2aWNl cy1zdGF0ZSIgc28gdGhlIGRlc3RpbmF0aW9uIGNhbiB0YWtlcwo+IHRoZW0sIGlmIGl0J3MgYSBs aXZlIG1pZ3JhdGlvbi4KPiAKPiBUaGlzIHBhdGNoIGFkZCB0aGUgImxpdmUiIHBhcmFtZXRlciB0 byAieGVuLXNhdmUtZGV2aWNlcy1zdGF0ZSIgd2hpY2gKPiBkZWZhdWx0IHRvIHRydWUgc28gb2xk ZXIgdmVyc2lvbiBvZiBsaWJ4ZW5saWdodCBjYW4gd29yayB3aXRoIG5ld2VyCj4gdmVyc2lvbiBv ZiBRRU1VLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFudGhvbnkgUEVSQVJEIDxhbnRob255LnBlcmFy ZEBjaXRyaXguY29tPgo+IFJldmlld2VkLWJ5OiBEci4gRGF2aWQgQWxhbiBHaWxiZXJ0IDxkZ2ls YmVydEByZWRoYXQuY29tPgo+IFJldmlld2VkLWJ5OiBKdWFuIFF1aW50ZWxhIDxxdWludGVsYUBy ZWRoYXQuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEp1YW4gUXVpbnRlbGEgPHF1aW50ZWxhQHJlZGhh dC5jb20+Cj4gLS0tCj4gIG1pZ3JhdGlvbi9zYXZldm0uYyAgfCAyMyArKysrKysrKysrKysrKysr KysrKysrLQo+ICBxYXBpL21pZ3JhdGlvbi5qc29uIHwgIDYgKysrKystCj4gIDIgZmlsZXMgY2hh bmdlZCwgMjcgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv bWlncmF0aW9uL3NhdmV2bS5jIGIvbWlncmF0aW9uL3NhdmV2bS5jCj4gaW5kZXggMTkyZjJkODJj ZC4uYjc5MDhmNjJiZSAxMDA2NDQKPiAtLS0gYS9taWdyYXRpb24vc2F2ZXZtLmMKPiArKysgYi9t aWdyYXRpb24vc2F2ZXZtLmMKPiBAQCAtMjI0MiwxMyArMjI0MiwyMCBAQCBpbnQgc2F2ZV9zbmFw c2hvdChjb25zdCBjaGFyICpuYW1lLCBFcnJvciAqKmVycnApCj4gICAgICByZXR1cm4gcmV0Owo+ ICB9Cj4gIAo+IC12b2lkIHFtcF94ZW5fc2F2ZV9kZXZpY2VzX3N0YXRlKGNvbnN0IGNoYXIgKmZp bGVuYW1lLCBFcnJvciAqKmVycnApCj4gK3ZvaWQgcW1wX3hlbl9zYXZlX2RldmljZXNfc3RhdGUo Y29uc3QgY2hhciAqZmlsZW5hbWUsIGJvb2wgaGFzX2xpdmUsIGJvb2wgbGl2ZSwKPiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBFcnJvciAqKmVycnApCj4gIHsKPiAgICAgIFFFTVVG aWxlICpmOwo+ICAgICAgUUlPQ2hhbm5lbEZpbGUgKmlvYzsKPiAgICAgIGludCBzYXZlZF92bV9y dW5uaW5nOwo+ICAgICAgaW50IHJldDsKPiAgCj4gKyAgICBpZiAoIWhhc19saXZlKSB7Cj4gKyAg ICAgICAgLyogbGl2ZSBkZWZhdWx0IHRvIHRydWUgc28gb2xkIHZlcnNpb24gb2YgWGVuIHRvb2wg c3RhY2sgY2FuIGhhdmUgYQo+ICsgICAgICAgICAqIHN1Y2Nlc3NmdWxsIGxpdmUgbWlncmF0aW9u ICovCj4gKyAgICAgICAgbGl2ZSA9IHRydWU7Cj4gKyAgICB9Cj4gKwo+ICAgICAgc2F2ZWRfdm1f cnVubmluZyA9IHJ1bnN0YXRlX2lzX3J1bm5pbmcoKTsKPiAgICAgIHZtX3N0b3AoUlVOX1NUQVRF X1NBVkVfVk0pOwo+ICAgICAgZ2xvYmFsX3N0YXRlX3N0b3JlX3J1bm5pbmcoKTsKPiBAQCAtMjI2 Myw2ICsyMjcwLDIwIEBAIHZvaWQgcW1wX3hlbl9zYXZlX2RldmljZXNfc3RhdGUoY29uc3QgY2hh ciAqZmlsZW5hbWUsIEVycm9yICoqZXJycCkKPiAgICAgIHFlbXVfZmNsb3NlKGYpOwo+ICAgICAg aWYgKHJldCA8IDApIHsKPiAgICAgICAgICBlcnJvcl9zZXRnKGVycnAsIFFFUlJfSU9fRVJST1Ip Owo+ICsgICAgfSBlbHNlIHsKPiArICAgICAgICAvKiBsaWJ4bCBjYWxscyB0aGUgUU1QIGNvbW1h bmQgInN0b3AiIGJlZm9yZSBjYWxsaW5nCj4gKyAgICAgICAgICogInhlbi1zYXZlLWRldmljZXMt c3RhdGUiIGFuZCBpbiBjYXNlIG9mIG1pZ3JhdGlvbiBmYWlsdXJlLCBsaWJ4bAo+ICsgICAgICAg ICAqIHdvdWxkIGNhbGwgImNvbnQiLgo+ICsgICAgICAgICAqIFNvIGNhbGwgYmRydl9pbmFjdGl2 YXRlX2FsbCAocmVsZWFzZSBsb2NrcykgaGVyZSB0byBsZXQgdGhlIG90aGVyCj4gKyAgICAgICAg ICogc2lkZSBvZiB0aGUgbWlncmF0aW9uIHRha2UgY29udHJvbGUgb2YgdGhlIGltYWdlcy4KPiAr ICAgICAgICAgKi8KPiArICAgICAgICBpZiAobGl2ZSAmJiAhc2F2ZWRfdm1fcnVubmluZykgewo+ ICsgICAgICAgICAgICByZXQgPSBiZHJ2X2luYWN0aXZhdGVfYWxsKCk7Cj4gKyAgICAgICAgICAg IGlmIChyZXQpIHsKPiArICAgICAgICAgICAgICAgIGVycm9yX3NldGcoZXJycCwgIiVzOiBiZHJ2 X2luYWN0aXZhdGVfYWxsKCkgZmFpbGVkICglZCkiLAo+ICsgICAgICAgICAgICAgICAgICAgICAg ICAgICBfX2Z1bmNfXywgcmV0KTsKPiArICAgICAgICAgICAgfQo+ICsgICAgICAgIH0KPiAgICAg IH0KPiAgCj4gICB0aGVfZW5kOgo+IGRpZmYgLS1naXQgYS9xYXBpL21pZ3JhdGlvbi5qc29uIGIv cWFwaS9taWdyYXRpb24uanNvbgo+IGluZGV4IGJiYzQ2NzFkZWQuLjAzZjU3Yzk2MTYgMTAwNjQ0 Cj4gLS0tIGEvcWFwaS9taWdyYXRpb24uanNvbgo+ICsrKyBiL3FhcGkvbWlncmF0aW9uLmpzb24K PiBAQCAtMTA3NSw2ICsxMDc1LDkgQEAKPiAgIyBkYXRhLiBTZWUgeGVuLXNhdmUtZGV2aWNlcy1z dGF0ZS50eHQgZm9yIGEgZGVzY3JpcHRpb24gb2YgdGhlIGJpbmFyeQo+ICAjIGZvcm1hdC4KPiAg Iwo+ICsjIEBsaXZlOiBPcHRpb25hbCBhcmd1bWVudCB0byBhc2sgUUVNVSB0byB0cmVhdCB0aGlz IGNvbW1hbmQgYXMgcGFydCBvZiBhIGxpdmUKPiArIyBtaWdyYXRpb24uIERlZmF1bHQgdG8gdHJ1 ZS4gKHNpbmNlIDIuMTEpCj4gKyMKPiAgIyBSZXR1cm5zOiBOb3RoaW5nIG9uIHN1Y2Nlc3MKPiAg Iwo+ICAjIFNpbmNlOiAxLjEKPiBAQCAtMTA4Niw3ICsxMDg5LDggQEAKPiAgIyA8LSB7ICJyZXR1 cm4iOiB7fSB9Cj4gICMKPiAgIyMKPiAteyAnY29tbWFuZCc6ICd4ZW4tc2F2ZS1kZXZpY2VzLXN0 YXRlJywgJ2RhdGEnOiB7J2ZpbGVuYW1lJzogJ3N0cid9IH0KPiAreyAnY29tbWFuZCc6ICd4ZW4t c2F2ZS1kZXZpY2VzLXN0YXRlJywKPiArICAnZGF0YSc6IHsnZmlsZW5hbWUnOiAnc3RyJywgJyps aXZlJzonYm9vbCcgfSB9Cj4gIAo+ICAjIwo+ICAjIEB4ZW4tc2V0LXJlcGxpY2F0aW9uOgo+IC0t IAo+IDIuMTMuNgo+IAoKLS0gCkFudGhvbnkgUEVSQVJECgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZl bEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxt YW4vbGlzdGluZm8veGVuLWRldmVs