From: Sameer Goel <sameer.goel@linaro.org>
To: xen-devel@lists.xenproject.org, julien.grall@arm.com,
mjaggi@caviumnetworks.com
Cc: sstabellini@kernel.org, Andrew.Cooper3@citrix.com,
andre.przywara@linaro.org, jbeulich@suse.com,
Sameer Goel <sameer.goel@linaro.org>,
shankerd@codeaurora.org
Subject: [RFC v4 2/8] xen/bitops: Rename LOG_2 to ilog2
Date: Mon, 18 Dec 2017 20:16:57 -0700 [thread overview]
Message-ID: <20171219031703.23420-3-sameer.goel@linaro.org> (raw)
In-Reply-To: <20171219031703.23420-1-sameer.goel@linaro.org>
Changing the name of the macro from LOG_2 to ilog2.This makes the function name
similar to its Linux counterpart. Since, this is not used in mutiple places, so the code churn is minimal.
This change helps in porting unchanged code from Linux.
Signed-off-by: Sameer Goel <sameer.goel@linaro.org>
---
xen/arch/x86/x86_64/asm-offsets.c | 2 +-
xen/include/xen/bitops.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/x86/x86_64/asm-offsets.c b/xen/arch/x86/x86_64/asm-offsets.c
index e136af6b99..4bccbc9bdf 100644
--- a/xen/arch/x86/x86_64/asm-offsets.c
+++ b/xen/arch/x86/x86_64/asm-offsets.c
@@ -157,7 +157,7 @@ void __dummy__(void)
BLANK();
#endif
- DEFINE(IRQSTAT_shift, LOG_2(sizeof(irq_cpustat_t)));
+ DEFINE(IRQSTAT_shift, ilog2(sizeof(irq_cpustat_t)));
OFFSET(IRQSTAT_softirq_pending, irq_cpustat_t, __softirq_pending);
BLANK();
diff --git a/xen/include/xen/bitops.h b/xen/include/xen/bitops.h
index e2019b02a3..a103e49089 100644
--- a/xen/include/xen/bitops.h
+++ b/xen/include/xen/bitops.h
@@ -223,7 +223,7 @@ static inline __u32 ror32(__u32 word, unsigned int shift)
#define __L4(_x) (((_x) & 0x0000000c) ? ( 2 + __L2( (_x)>> 2)) : __L2( _x))
#define __L8(_x) (((_x) & 0x000000f0) ? ( 4 + __L4( (_x)>> 4)) : __L4( _x))
#define __L16(_x) (((_x) & 0x0000ff00) ? ( 8 + __L8( (_x)>> 8)) : __L8( _x))
-#define LOG_2(_x) (((_x) & 0xffff0000) ? (16 + __L16((_x)>>16)) : __L16(_x))
+#define ilog2(_x) (((_x) & 0xffff0000) ? (16 + __L16((_x)>>16)) : __L16(_x))
/**
* for_each_set_bit - iterate over every set bit in a memory region
--
2.14.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2017-12-19 3:17 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 3:16 [RFC v4 0/8] SMMUv3 driver Sameer Goel
2017-12-19 3:16 ` [RFC v4 1/8] Port WARN_ON_ONCE() from Linux Sameer Goel
2018-01-23 11:33 ` Julien Grall
2018-01-23 16:13 ` Wei Liu
2018-01-26 1:45 ` Sameer Goel
2017-12-19 3:16 ` Sameer Goel [this message]
2018-01-23 11:36 ` [RFC v4 2/8] xen/bitops: Rename LOG_2 to ilog2 Julien Grall
2018-01-23 11:39 ` Roger Pau Monné
2018-01-23 11:44 ` Julien Grall
2018-01-23 12:10 ` Roger Pau Monné
2018-01-23 12:17 ` Julien Grall
2017-12-19 3:16 ` [RFC v4 3/8] xen/linux_compat: Add a Linux compat header Sameer Goel
2018-01-23 16:28 ` Wei Liu
2018-01-23 16:51 ` Roger Pau Monné
2018-02-09 17:54 ` Sameer Goel
2017-12-19 3:16 ` [RFC v4 4/8] passthrough/arm: Modify SMMU driver to use generic device definition Sameer Goel
2018-01-23 11:41 ` Julien Grall
2017-12-19 3:17 ` [RFC v4 5/8] Add verbatim copy of arm-smmu-v3.c from Linux Sameer Goel
2017-12-19 3:17 ` [RFC v4 6/8] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver Sameer Goel
2018-01-03 5:47 ` Manish Jaggi
2018-01-15 20:34 ` Julien Grall
2018-01-16 12:37 ` Manish Jaggi
2018-01-16 13:13 ` Julien Grall
2018-01-23 15:18 ` Julien Grall
2018-02-09 17:56 ` Sameer Goel
2018-02-09 18:11 ` Julien Grall
2017-12-19 3:17 ` [RFC v4 7/8] xen/smmu: Add a new config define for legacy SMMU Sameer Goel
2018-01-23 15:26 ` Julien Grall
2017-12-19 3:17 ` [RFC v4 8/8] drivers/passthrough/arm: Refactor code for arm smmu drivers Sameer Goel
2018-01-03 5:34 ` Manish Jaggi
2018-01-15 20:41 ` Julien Grall
2018-01-16 12:40 ` Manish Jaggi
2018-01-16 13:14 ` Julien Grall
2018-01-16 13:27 ` Manish Jaggi
2018-01-16 13:40 ` Julien Grall
2018-01-17 6:37 ` Manish Jaggi
2018-01-23 15:38 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219031703.23420-3-sameer.goel@linaro.org \
--to=sameer.goel@linaro.org \
--cc=Andrew.Cooper3@citrix.com \
--cc=andre.przywara@linaro.org \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=mjaggi@caviumnetworks.com \
--cc=shankerd@codeaurora.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).