From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: wei.liu2@citrix.com
Subject: [PATCH RFC v1 33/74] x86/guest: enable event channels upcalls
Date: Thu, 4 Jan 2018 13:05:44 +0000 [thread overview]
Message-ID: <20180104130625.28605-34-wei.liu2@citrix.com> (raw)
In-Reply-To: <20180104130625.28605-1-wei.liu2@citrix.com>
From: Sergey Dyasli <sergey.dyasli@citrix.com>
Signed-off-by: Sergey Dyasli <sergey.dyasli@citrix.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
xen/arch/x86/guest/xen.c | 74 +++++++++++++++++++++++++++++++++++
xen/arch/x86/smpboot.c | 4 ++
xen/include/asm-x86/guest/hypercall.h | 17 ++++++++
xen/include/asm-x86/guest/xen.h | 5 +++
4 files changed, 100 insertions(+)
diff --git a/xen/arch/x86/guest/xen.c b/xen/arch/x86/guest/xen.c
index 594eae0828..781bfa493b 100644
--- a/xen/arch/x86/guest/xen.c
+++ b/xen/arch/x86/guest/xen.c
@@ -21,6 +21,7 @@
#include <xen/init.h>
#include <xen/types.h>
+#include <asm/apic.h>
#include <asm/guest.h>
#include <asm/msr.h>
#include <asm/processor.h>
@@ -30,6 +31,7 @@
bool xen_guest;
static uint32_t xen_cpuid_base;
+static uint8_t evtchn_upcall_vector;
extern char hypercall_page[];
static void __init find_xen_leaves(void)
@@ -91,9 +93,81 @@ static void map_shared_info(struct e820map *e820)
set_fixmap(FIX_XEN_SHARED_INFO, frame);
}
+static void xen_evtchn_upcall(struct cpu_user_regs *regs)
+{
+ unsigned int cpu = smp_processor_id();
+ struct vcpu_info *vcpu_info = &XEN_shared_info->vcpu_info[cpu];
+
+ vcpu_info->evtchn_upcall_pending = 0;
+ xchg(&vcpu_info->evtchn_pending_sel, 0);
+
+ ack_APIC_irq();
+}
+
+static void ap_setup_event_channels(bool clear)
+{
+ unsigned int i, cpu = smp_processor_id();
+ struct vcpu_info *vcpu_info = &XEN_shared_info->vcpu_info[cpu];
+ int rc;
+
+ ASSERT(evtchn_upcall_vector);
+ ASSERT(cpu < ARRAY_SIZE(XEN_shared_info->vcpu_info));
+
+ if ( !clear )
+ {
+ /*
+ * This is necessary to ensure that a CPU will be interrupted in case
+ * of an event channel notification.
+ */
+ ASSERT(vcpu_info->evtchn_upcall_pending == 0);
+ ASSERT(vcpu_info->evtchn_pending_sel == 0);
+ }
+
+ rc = xen_hypercall_set_evtchn_upcall_vector(cpu, evtchn_upcall_vector);
+ if ( rc )
+ panic("Unable to set evtchn upcall vector: %d", rc);
+
+ if ( clear )
+ {
+ /*
+ * Clear any pending upcall bits. This makes us effectively ignore any
+ * previous upcalls which might be suboptimal.
+ */
+ vcpu_info->evtchn_upcall_pending = 0;
+ xchg(&vcpu_info->evtchn_pending_sel, 0);
+
+ /*
+ * evtchn_pending can be cleared only on the boot CPU because it's
+ * located in a shared structure.
+ */
+ for ( i = 0; i < 8; i++ )
+ xchg(&XEN_shared_info->evtchn_pending[i], 0);
+ }
+}
+
+static void __init init_evtchn(void)
+{
+ unsigned int i;
+
+ alloc_direct_apic_vector(&evtchn_upcall_vector, xen_evtchn_upcall);
+
+ /* Mask all upcalls */
+ for ( i = 0; i < 8; i++ )
+ xchg(&XEN_shared_info->evtchn_mask[i], ~0ul);
+
+ ap_setup_event_channels(true);
+}
+
void __init hypervisor_early_setup(struct e820map *e820)
{
map_shared_info(e820);
+
+ init_evtchn();
+}
+
+void hypervisor_ap_setup(void)
+{
+ ap_setup_event_channels(false);
}
/*
diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c
index 7b97ff86cb..9a9fbc6ee0 100644
--- a/xen/arch/x86/smpboot.c
+++ b/xen/arch/x86/smpboot.c
@@ -45,6 +45,7 @@
#include <mach_apic.h>
#include <mach_wakecpu.h>
#include <smpboot_hooks.h>
+#include <asm/guest.h>
/* Override macros from asm/page.h to make them work with mfn_t */
#undef mfn_to_page
@@ -372,6 +373,9 @@ void start_secondary(void *unused)
cpumask_set_cpu(cpu, &cpu_online_map);
unlock_vector_lock();
+ if ( xen_guest )
+ hypervisor_ap_setup();
+
/* We can take interrupts now: we're officially "up". */
local_irq_enable();
mtrr_ap_init();
diff --git a/xen/include/asm-x86/guest/hypercall.h b/xen/include/asm-x86/guest/hypercall.h
index d5fe535c03..d6d4d1946b 100644
--- a/xen/include/asm-x86/guest/hypercall.h
+++ b/xen/include/asm-x86/guest/hypercall.h
@@ -23,6 +23,7 @@
#include <public/xen.h>
#include <public/sched.h>
+#include <public/hvm/hvm_op.h>
#ifdef CONFIG_XEN_GUEST
@@ -96,6 +97,11 @@ static inline long xen_hypercall_memory_op(unsigned int cmd, void *arg)
return _hypercall64_2(long, __HYPERVISOR_memory_op, cmd, arg);
}
+static inline long xen_hypercall_hvm_op(unsigned int op, void *arg)
+{
+ return _hypercall64_2(long, __HYPERVISOR_hvm_op, op, arg);
+}
+
/*
* Higher level hypercall helpers
*/
@@ -111,6 +117,17 @@ static inline long xen_hypercall_shutdown(unsigned int reason)
return xen_hypercall_sched_op(SCHEDOP_shutdown, &reason);
}
+static inline long xen_hypercall_set_evtchn_upcall_vector(
+ unsigned int cpu, unsigned int vector)
+{
+ struct xen_hvm_evtchn_upcall_vector a = {
+ .vcpu = cpu,
+ .vector = vector,
+ };
+
+ return xen_hypercall_hvm_op(HVMOP_set_evtchn_upcall_vector, &a);
+}
+
#else /* CONFIG_XEN_GUEST */
static inline void xen_hypercall_console_write(
diff --git a/xen/include/asm-x86/guest/xen.h b/xen/include/asm-x86/guest/xen.h
index 2f3bcd2fe4..56cabb1934 100644
--- a/xen/include/asm-x86/guest/xen.h
+++ b/xen/include/asm-x86/guest/xen.h
@@ -32,6 +32,7 @@ extern bool xen_guest;
void probe_hypervisor(void);
void hypervisor_early_setup(struct e820map *e820);
+void hypervisor_ap_setup(void);
#else
@@ -42,6 +43,10 @@ static inline void hypervisor_early_setup(struct e820map *e820)
{
ASSERT_UNREACHABLE();
};
+static inline void hypervisor_ap_setup(void)
+{
+ ASSERT_UNREACHABLE();
+};
#endif /* CONFIG_XEN_GUEST */
#endif /* __X86_GUEST_XEN_H__ */
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-01-04 13:28 UTC|newest]
Thread overview: 206+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 13:05 [PATCH RFC v1 00/74] Run PV guest in PVH container Wei Liu
2018-01-04 13:05 ` [PATCH RFC v1 01/74] x86/svm: Offer CPUID Faulting to AMD HVM guests as well Wei Liu
2018-01-04 14:00 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 02/74] x86: Common cpuid faulting support Wei Liu
2018-01-04 14:19 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 03/74] x86/upcall: inject a spurious event after setting upcall vector Wei Liu
2018-01-04 13:05 ` [PATCH RFC v1 04/74] tools/libxc: initialise hvm loader elf log fd to get more logging Wei Liu
2018-01-04 13:05 ` [PATCH RFC v1 05/74] tools/libxc: remove extraneous newline in xc_dom_load_acpi Wei Liu
2018-01-04 13:05 ` [PATCH RFC v1 06/74] tools/libelf: fix elf notes check for PVH guest Wei Liu
2018-01-04 14:37 ` Jan Beulich
2018-01-08 15:34 ` Wei Liu
2018-01-08 16:02 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 07/74] tools/libxc: Multi modules support Wei Liu
2018-01-04 13:05 ` [PATCH RFC v1 08/74] libxl: Introduce hack to allow PVH mode to add a shim Wei Liu
2018-01-04 13:05 ` [PATCH RFC v1 09/74] xen/common: Widen the guest logging buffer slightly Wei Liu
2018-01-04 13:05 ` [PATCH RFC v1 10/74] x86/time: Print a more helpful error when a platform timer can't be found Wei Liu
2018-01-05 10:37 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 11/74] x86/link: Introduce and use SECTION_ALIGN Wei Liu
2018-01-05 10:38 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 12/74] xen/acpi: mark the PM timer FADT field as optional Wei Liu
2018-01-05 10:52 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 13/74] xen/domctl: Return arch_config via getdomaininfo Wei Liu
2018-01-05 10:58 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 14/74] tools/ocaml: Expose arch_config in domaininfo Wei Liu
2018-01-04 13:05 ` [PATCH RFC v1 15/74] tools/ocaml: Extend domain_create() to take arch_domainconfig Wei Liu
2018-01-04 13:05 ` [PATCH RFC v1 16/74] x86/fixmap: Modify fix_to_virt() to return a void pointer Wei Liu
2018-01-05 11:05 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 17/74] ---- x86/Kconfig: Options for Xen and PVH support Wei Liu
2018-01-05 11:11 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 18/74] x86/link: Relocate program headers Wei Liu
2018-01-05 11:20 ` Jan Beulich
2018-01-08 15:43 ` Wei Liu
2018-01-08 16:26 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 19/74] x86: introduce ELFNOTE macro Wei Liu
2018-01-05 11:27 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 20/74] x86: produce a binary that can be booted as PVH Wei Liu
2018-01-05 11:39 ` Jan Beulich
2018-01-08 15:59 ` Wei Liu
2018-01-08 16:42 ` Jan Beulich
2018-01-09 13:49 ` Wei Liu
2018-01-10 19:10 ` Wei Liu
2018-01-04 13:05 ` [PATCH RFC v1 21/74] x86/entry: Early PVH boot code Wei Liu
2018-01-05 13:32 ` Jan Beulich
2018-01-09 15:45 ` Wei Liu
2018-01-09 16:41 ` Jan Beulich
2018-01-09 17:10 ` Wei Liu
2018-01-04 13:05 ` [PATCH RFC v1 22/74] x86/boot: Map more than the first 16MB Wei Liu
2018-01-04 13:05 ` [PATCH RFC v1 23/74] x86/entry: Probe for Xen early during boot Wei Liu
2018-01-05 13:40 ` Jan Beulich
2018-01-10 17:45 ` Wei Liu
2018-01-11 7:55 ` Jan Beulich
2018-01-11 9:43 ` Wei Liu
2018-01-04 13:05 ` [PATCH RFC v1 24/74] x86/guest: Hypercall support Wei Liu
2018-01-05 13:53 ` Jan Beulich
2018-01-05 14:09 ` Andrew Cooper
2018-01-04 13:05 ` [PATCH RFC v1 25/74] x86/shutdown: Support for using SCHEDOP_{shutdown, reboot} Wei Liu
2018-01-05 14:01 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 26/74] x86/pvh: Retrieve memory map from Xen Wei Liu
2018-01-05 14:05 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 27/74] xen/console: Introduce console=xen Wei Liu
2018-01-05 14:08 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 28/74] x86: initialise shared_info page Wei Liu
2018-01-05 14:11 ` Jan Beulich
2018-01-05 14:20 ` Andrew Cooper
2018-01-05 14:28 ` Roger Pau Monné
2018-01-05 14:40 ` Andrew Cooper
2018-01-04 13:05 ` [PATCH RFC v1 29/74] x86: xen pv clock time source Wei Liu
2018-01-05 14:17 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 30/74] x86: APIC timer calibration when running as a guest Wei Liu
2018-01-05 14:35 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 31/74] x86: read wallclock from Xen running in pvh mode Wei Liu
2018-01-05 14:43 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 32/74] x86: don't swallow the first command line item " Wei Liu
2018-01-05 14:49 ` Jan Beulich
2018-01-09 14:30 ` Roger Pau Monné
2018-01-04 13:05 ` Wei Liu [this message]
2018-01-05 15:07 ` [PATCH RFC v1 33/74] x86/guest: enable event channels upcalls Jan Beulich
2018-01-05 15:19 ` Andrew Cooper
2018-01-04 13:05 ` [PATCH RFC v1 34/74] x86/guest: add PV console code Wei Liu
2018-01-05 15:22 ` Jan Beulich
2018-01-10 15:33 ` Roger Pau Monné
2018-01-10 15:55 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 35/74] x86/guest: use PV console for Xen/Dom0 I/O Wei Liu
2018-01-04 13:05 ` [PATCH RFC v1 36/74] --- x86/shim: Kconfig and command line options Wei Liu
2018-01-05 15:26 ` Jan Beulich
2018-01-05 17:51 ` Andrew Cooper
2018-01-08 8:22 ` Jan Beulich
2018-01-08 11:33 ` Andrew Cooper
2018-01-08 11:46 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 37/74] tools/firmware: Build and install xen-shim Wei Liu
2018-01-04 13:05 ` [PATCH RFC v1 38/74] x86/pv-shim: Force CPUID faulting in pv-shim mode Wei Liu
2018-01-08 10:16 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 39/74] xen/x86: make VGA support selectable Wei Liu
2018-01-08 10:22 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 40/74] xen/x86: report domain id on cpuid Wei Liu
2018-01-08 10:27 ` Jan Beulich
2018-01-08 10:34 ` Andrew Cooper
2018-01-08 11:11 ` Jan Beulich
2018-01-08 11:22 ` Andrew Cooper
2018-01-08 11:27 ` Jan Beulich
2018-01-08 11:29 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 41/74] xen/pvh: do not mark the low 1MB as IO mem Wei Liu
2018-01-08 10:30 ` Jan Beulich
2018-01-08 10:37 ` Roger Pau Monné
2018-01-08 11:11 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 42/74] sched/null: skip vCPUs on the waitqueue that are blocked Wei Liu
2018-01-08 10:37 ` Jan Beulich
2018-01-08 11:12 ` George Dunlap
2018-01-12 9:54 ` Dario Faggioli
2018-01-12 10:45 ` Roger Pau Monné
2018-01-12 11:16 ` Dario Faggioli
2018-01-12 11:22 ` Roger Pau Monné
2018-01-12 10:41 ` Dario Faggioli
2018-01-04 13:05 ` [PATCH RFC v1 43/74] xen: introduce rangeset_reserve_hole Wei Liu
2018-01-08 10:46 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 44/74] xen/pvshim: keep track of unused pages Wei Liu
2018-01-08 10:58 ` Jan Beulich
2018-01-08 11:04 ` Roger Pau Monné
2018-01-08 11:22 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 45/74] x86/guest: use unpopulated memory to map the shared_info page Wei Liu
2018-01-08 11:03 ` Jan Beulich
2018-01-08 11:06 ` Roger Pau Monné
2018-01-08 11:25 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 46/74] xen/guest: fetch vCPU ID from Xen Wei Liu
2018-01-08 11:04 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 47/74] x86/guest: fix upcall vector setup Wei Liu
2018-01-08 11:08 ` Jan Beulich
2018-01-04 13:05 ` [PATCH RFC v1 48/74] x86/guest: unmask console event channel Wei Liu
2018-01-04 13:06 ` [PATCH RFC v1 49/74] x86/guest: map per-cpu vcpu_info area Wei Liu
2018-01-08 13:21 ` Jan Beulich
2018-01-09 12:08 ` Roger Pau Monné
2018-01-04 13:06 ` [PATCH RFC v1 50/74] xen/pvshim: remove Dom0 kernel support check Wei Liu
2018-01-08 13:28 ` Jan Beulich
2018-01-04 13:06 ` [PATCH RFC v1 51/74] xen/pvshim: don't allow access to iomem or ioports Wei Liu
2018-01-08 13:29 ` Jan Beulich
2018-01-04 13:06 ` [PATCH RFC v1 52/74] xen: mark xenstore/console pages as RAM and add them to dom_io Wei Liu
2018-01-08 13:49 ` Jan Beulich
2018-01-09 9:25 ` Roger Pau Monné
2018-01-09 11:03 ` Jan Beulich
2018-01-09 11:26 ` Roger Pau Monné
2018-01-09 13:34 ` Jan Beulich
2018-01-04 13:06 ` [PATCH RFC v1 53/74] xen/pvshim: modify Dom0 builder in order to build a DomU Wei Liu
2018-01-08 14:06 ` Jan Beulich
2018-01-09 16:09 ` Roger Pau Monné
2018-01-09 16:26 ` Jan Beulich
2018-01-09 9:06 ` Jan Beulich
2018-01-04 13:06 ` [PATCH RFC v1 54/74] xen/pvshim: set correct domid value Wei Liu
2018-01-08 14:17 ` Jan Beulich
2018-01-09 16:27 ` Roger Pau Monné
2018-01-04 13:06 ` [PATCH RFC v1 55/74] xen/pvshim: forward evtchn ops between L0 Xen and L2 DomU Wei Liu
2018-01-08 16:05 ` Jan Beulich
2018-01-08 16:22 ` Roger Pau Monné
2018-01-09 8:00 ` Jan Beulich
2018-01-09 16:45 ` Roger Pau Monné
2018-01-09 17:42 ` Jan Beulich
2018-01-09 17:50 ` Anthony Liguori
2018-01-10 12:23 ` Roger Pau Monné
2018-01-09 7:49 ` Jan Beulich
2018-01-04 13:06 ` [PATCH RFC v1 56/74] xen/pvshim: add grant table operations Wei Liu
2018-01-08 17:19 ` Jan Beulich
2018-01-09 18:34 ` Roger Pau Monné
2018-01-10 7:28 ` Jan Beulich
2018-01-10 8:01 ` Roger Pau Monné
2018-01-04 13:06 ` [PATCH RFC v1 57/74] x86/pv-shim: shadow PV console's page for L2 DomU Wei Liu
2018-01-09 9:13 ` Jan Beulich
2018-01-09 15:43 ` Sergey Dyasli
2018-01-09 16:28 ` Jan Beulich
2018-01-10 16:56 ` Sergey Dyasli
2018-01-12 7:03 ` Sarah Newman
2018-01-04 13:06 ` [PATCH RFC v1 58/74] xen/pvshim: add migration support Wei Liu
2018-01-09 9:38 ` Jan Beulich
2018-01-10 12:54 ` Roger Pau Monné
2018-01-04 13:06 ` [PATCH RFC v1 59/74] xen/pvshim: add shim_mem cmdline parameter Wei Liu
2018-01-09 9:47 ` Jan Beulich
2018-01-04 13:06 ` [PATCH RFC v1 60/74] xen/pvshim: set max_pages to the value of tot_pages Wei Liu
2018-01-09 9:48 ` Jan Beulich
2018-01-04 13:06 ` [PATCH RFC v1 61/74] xen/pvshim: support vCPU hotplug Wei Liu
2018-01-09 10:16 ` Jan Beulich
2018-01-10 13:07 ` Roger Pau Monné
2018-01-10 13:33 ` Jan Beulich
2018-01-10 14:40 ` Roger Pau Monné
2018-01-04 13:06 ` [PATCH RFC v1 62/74] xen/pvshim: memory hotplug Wei Liu
2018-01-09 10:42 ` Jan Beulich
2018-01-10 13:36 ` Roger Pau Monné
2018-01-10 13:42 ` Jan Beulich
2018-01-04 13:06 ` [PATCH RFC v1 63/74] xen/shim: modify shim_mem parameter behaviour Wei Liu
2018-01-09 10:48 ` Jan Beulich
2018-01-04 13:06 ` [PATCH RFC v1 64/74] xen/pvshim: use default position for the m2p mappings Wei Liu
2018-01-09 10:50 ` Jan Beulich
2018-01-04 13:06 ` [PATCH RFC v1 65/74] xen/shim: crash instead of reboot in shim mode Wei Liu
2018-01-09 10:52 ` Jan Beulich
2018-01-04 13:06 ` [PATCH RFC v1 66/74] xen/shim: allow DomU to have as many vcpus as available Wei Liu
2018-01-09 10:59 ` Jan Beulich
2018-01-10 16:14 ` Roger Pau Monné
2018-01-04 13:06 ` [PATCH RFC v1 67/74] libxl: libxl__build_hvm: Introduce separate b_info parameter Wei Liu
2018-01-04 13:06 ` [PATCH RFC v1 68/74] libxl__domain_build_info_setdefault_pvhhvm: introduce Wei Liu
2018-01-04 13:06 ` [PATCH RFC v1 69/74] libxl_bitmap_copy_alloc: copy 0, NULL as 0, NULL Wei Liu
2018-01-04 13:06 ` [PATCH RFC v1 70/74] libxl: pvshim: Check state->shim_path before domain type Wei Liu
2018-01-04 13:06 ` [PATCH RFC v1 71/74] libxl: pvshim: Provide first-class config settings to enable shim mode Wei Liu
2018-01-04 13:06 ` [PATCH RFC v1 72/74] libxl: pvshim: Introduce pvhshim_extra Wei Liu
2018-01-04 13:06 ` [PATCH RFC v1 73/74] xl: pvshim: Provide and document xl config Wei Liu
2018-01-04 13:06 ` [PATCH RFC v1 74/74] libxl: pvshim: Set video_memkb to ~0 Wei Liu
2018-01-08 16:12 ` [PATCH RFC v1 00/74] Run PV guest in PVH container Ian Jackson
2018-01-11 15:39 ` Ian Jackson
2018-01-10 16:26 ` George Dunlap
2018-01-10 16:28 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180104130625.28605-34-wei.liu2@citrix.com \
--to=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).