From: Brian Woods <brian.woods@amd.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Brian Woods <brian.woods@amd.com>,
Jan Beulich <jbeulich@suse.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH 2/2] x86/svm: Add checks for nested HW features
Date: Fri, 5 Jan 2018 09:27:30 -0600 [thread overview]
Message-ID: <20180105152730.GA11036@amd.com> (raw)
In-Reply-To: <8eb9d4df-e911-c213-4c32-dd20a54d0728@citrix.com>
On Fri, Dec 22, 2017 at 03:15:48PM +0000, Andrew Cooper wrote:
> Unfortunately, nestedhvm_enabled() is guaranteed to be false at the
> point that construct_vmcb() is called (due the order in which
> information appears while constructing the VM), which means we will
> never enable these optimisations.
>
> Combined with the observation of EFER in the pipeline, the logic to
> enable/disable these optimisations needs to be in
> svm_update_guest_efer(), and need to trigger when EFER.SVME changes.
>
> ~Andrew
Sorry for the late reply. I tired working this before vacation but it
turned out to be a little bit longer than that... I have a set of
patches that _should_ work, but there are other issues. Turns out there
are interrupt issues with nestted SVM HVM and I'm trying to hunt those
down and fix them so I can properly test the patches I've done. Oddly
enough you can at least get a system booted on 17h family systems even
if it's fragile but 15h just fails to even boot. Not sure how it even
worked when I tested previous patches on the 15h system.
--
Brian Woods
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2018-01-05 15:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 15:26 [PATCH 0/2] Various SVM Patches Brian Woods
2017-12-21 15:26 ` [PATCH 1/2] x86/svm: Add SVME checking for SVM intercepts Brian Woods
2017-12-22 4:52 ` Boris Ostrovsky
2017-12-22 15:07 ` Brian Woods
2017-12-21 15:26 ` [PATCH 2/2] x86/svm: Add checks for nested HW features Brian Woods
2017-12-22 4:55 ` Boris Ostrovsky
2017-12-22 15:15 ` Andrew Cooper
2018-01-05 15:27 ` Brian Woods [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180105152730.GA11036@amd.com \
--to=brian.woods@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).