* [PATCH] tools/misc/xen-hvmctx: fix the build
@ 2016-03-29 15:55 Paul Durrant
2016-03-29 16:14 ` Wei Liu
0 siblings, 1 reply; 5+ messages in thread
From: Paul Durrant @ 2016-03-29 15:55 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Paul Durrant, Ian Jackson, Stefano Stabellini
Commit 78c5f59e "x86/hvm/viridian: save APIC assist vector" changed
the name of a field in the viridian vcpu save record. Unfortunately this
record has a decode function in xen-hvmctx and so it no longer builds.
This patch fixes the field name in xen-hvmctx and also adds a decode of
the additional field that was added to the save record.
Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
tools/misc/xen-hvmctx.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/misc/xen-hvmctx.c b/tools/misc/xen-hvmctx.c
index 5a69245..32be120 100644
--- a/tools/misc/xen-hvmctx.c
+++ b/tools/misc/xen-hvmctx.c
@@ -379,8 +379,9 @@ static void dump_viridian_vcpu(void)
{
HVM_SAVE_TYPE(VIRIDIAN_VCPU) p;
READ(p);
- printf(" VIRIDIAN_VCPU: apic_assist 0x%llx\n",
- (unsigned long long) p.apic_assist);
+ printf(" VIRIDIAN_VCPU: apic_assist_msr 0x%llx, apic_assist_vector 0x%x\n",
+ (unsigned long long) p.apic_assist_msr,
+ p.apic_assist_vector);
}
static void dump_vmce_vcpu(void)
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] tools/misc/xen-hvmctx: fix the build
2016-03-29 15:55 Paul Durrant
@ 2016-03-29 16:14 ` Wei Liu
2016-03-29 17:11 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 5+ messages in thread
From: Wei Liu @ 2016-03-29 16:14 UTC (permalink / raw)
To: Paul Durrant; +Cc: xen-devel, Ian Jackson, Wei Liu, Stefano Stabellini
On Tue, Mar 29, 2016 at 04:55:23PM +0100, Paul Durrant wrote:
> Commit 78c5f59e "x86/hvm/viridian: save APIC assist vector" changed
> the name of a field in the viridian vcpu save record. Unfortunately this
> record has a decode function in xen-hvmctx and so it no longer builds.
>
> This patch fixes the field name in xen-hvmctx and also adds a decode of
> the additional field that was added to the save record.
>
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
> ---
> tools/misc/xen-hvmctx.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tools/misc/xen-hvmctx.c b/tools/misc/xen-hvmctx.c
> index 5a69245..32be120 100644
> --- a/tools/misc/xen-hvmctx.c
> +++ b/tools/misc/xen-hvmctx.c
> @@ -379,8 +379,9 @@ static void dump_viridian_vcpu(void)
> {
> HVM_SAVE_TYPE(VIRIDIAN_VCPU) p;
> READ(p);
> - printf(" VIRIDIAN_VCPU: apic_assist 0x%llx\n",
> - (unsigned long long) p.apic_assist);
> + printf(" VIRIDIAN_VCPU: apic_assist_msr 0x%llx, apic_assist_vector 0x%x\n",
> + (unsigned long long) p.apic_assist_msr,
> + p.apic_assist_vector);
> }
>
> static void dump_vmce_vcpu(void)
> --
> 2.1.4
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tools/misc/xen-hvmctx: fix the build
2016-03-29 16:14 ` Wei Liu
@ 2016-03-29 17:11 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 5+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-03-29 17:11 UTC (permalink / raw)
To: Wei Liu; +Cc: xen-devel, Paul Durrant, Ian Jackson, Stefano Stabellini
On Tue, Mar 29, 2016 at 05:14:42PM +0100, Wei Liu wrote:
> On Tue, Mar 29, 2016 at 04:55:23PM +0100, Paul Durrant wrote:
> > Commit 78c5f59e "x86/hvm/viridian: save APIC assist vector" changed
> > the name of a field in the viridian vcpu save record. Unfortunately this
> > record has a decode function in xen-hvmctx and so it no longer builds.
> >
> > This patch fixes the field name in xen-hvmctx and also adds a decode of
> > the additional field that was added to the save record.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > Cc: Wei Liu <wei.liu2@citrix.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
And applied.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] tools/misc/xen-hvmctx: fix the build
@ 2018-01-19 14:08 Paul Durrant
2018-01-19 14:13 ` Wei Liu
0 siblings, 1 reply; 5+ messages in thread
From: Paul Durrant @ 2018-01-19 14:08 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Paul Durrant, Ian Jackson
The recent commit 66bf4ef0 "x86/hvm: re-work viridian APIC assist code"
modified one of the field names in struct hvm_viridian_vcpu_context but
did not accordingly modify xen-hvmctx, leading to a failure to build tools.
This patch makes the necessary change to fix the build.
Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
tools/misc/xen-hvmctx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/misc/xen-hvmctx.c b/tools/misc/xen-hvmctx.c
index bde41f3816..026bed8134 100644
--- a/tools/misc/xen-hvmctx.c
+++ b/tools/misc/xen-hvmctx.c
@@ -379,9 +379,9 @@ static void dump_viridian_vcpu(void)
{
HVM_SAVE_TYPE(VIRIDIAN_VCPU) p;
READ(p);
- printf(" VIRIDIAN_VCPU: vp_assist_msr 0x%llx, vp_assist_vector 0x%x\n",
+ printf(" VIRIDIAN_VCPU: vp_assist_msr 0x%llx, vp_assist_pending %s\n",
(unsigned long long) p.vp_assist_msr,
- p.vp_assist_vector);
+ p.vp_assist_pending ? "true" : "false");
}
static void dump_vmce_vcpu(void)
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] tools/misc/xen-hvmctx: fix the build
2018-01-19 14:08 [PATCH] tools/misc/xen-hvmctx: fix the build Paul Durrant
@ 2018-01-19 14:13 ` Wei Liu
0 siblings, 0 replies; 5+ messages in thread
From: Wei Liu @ 2018-01-19 14:13 UTC (permalink / raw)
To: Paul Durrant; +Cc: xen-devel, Ian Jackson, Wei Liu
On Fri, Jan 19, 2018 at 09:08:14AM -0500, Paul Durrant wrote:
> The recent commit 66bf4ef0 "x86/hvm: re-work viridian APIC assist code"
> modified one of the field names in struct hvm_viridian_vcpu_context but
> did not accordingly modify xen-hvmctx, leading to a failure to build tools.
>
> This patch makes the necessary change to fix the build.
>
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-19 14:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-19 14:08 [PATCH] tools/misc/xen-hvmctx: fix the build Paul Durrant
2018-01-19 14:13 ` Wei Liu
-- strict thread matches above, loose matches on Subject: below --
2016-03-29 15:55 Paul Durrant
2016-03-29 16:14 ` Wei Liu
2016-03-29 17:11 ` Konrad Rzeszutek Wilk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).