From: Wei Liu <wei.liu2@citrix.com>
To: Bhupinder Thakur <bhupinder.thakur@linaro.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Julien Grall <julien.grall@linaro.org>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Julien Grall <julien.grall@arm.com>,
Jan Beulich <jbeulich@suse.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/4 v3 for-4.10] libxl: Fix the bug introduced in commit "libxl: use correct type modifier for vuart_gfn"
Date: Wed, 24 Jan 2018 12:34:54 +0000 [thread overview]
Message-ID: <20180124123454.eyggelo46kqwz6v2@citrix.com> (raw)
In-Reply-To: <20171114135611.htpdhrovmirz7vss@citrix.com>
On Tue, Nov 14, 2017 at 01:56:11PM +0000, Wei Liu wrote:
> On Tue, Nov 14, 2017 at 05:12:26PM +0530, Bhupinder Thakur wrote:
> > Hi,
> >
> > On 14 Nov 2017 3:35 pm, "Wei Liu" <wei.liu2@citrix.com> wrote:
> >
> > > On Mon, Nov 13, 2017 at 03:56:23PM +0000, Julien Grall wrote:
> > > > Hi Wei,
> > > >
> > > > Sorry I missed that e-mail.
> > > >
> > > > On 10/31/2017 10:07 AM, Wei Liu wrote:
> > > > > Change the tag to for-4.10.
> > > > >
> > > > > Julien, this is needed to fix vuart emulation.
> > > >
> > > > To confirm, only patch #1 is candidate for Xen 4.10, right? The rest
> > > will be
> > > > queued for Xen 4.11?
> > > >
> > >
> > > I think so.
> > >
> > > Bhupinder, can you confirm that?
> > >
> >
> > Yes. Only first patch is required for fixing the compilation issue.
> >
>
> Thanks. I will commit the first patch and put the rest in my for-next
> queue.
OK, patch 2 to 4 applied cleanly but the build is broken by them.
libxl_console.c: In function ‘libxl__device_console_add’:
libxl_console.c:332:68: error: ‘libxl__domain_build_state {aka struct <anonymous>}’ has no member named ‘console_mfn’; did you mean ‘console_gfn’?
flexarray_append(ro_front, GCSPRINTF("%"PRIu_xen_pfn, state->console_mfn));
^
libxl_internal.h:3921:58: note: in definition of macro ‘GCSPRINTF’
#define GCSPRINTF(fmt, ...) (libxl__sprintf((gc), (fmt), __VA_ARGS__))
^~~~~~~~~~~
For now I've dropped this series.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2018-01-24 12:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 6:55 [PATCH 1/4 v3] libxl: Fix the bug introduced in commit "libxl: use correct type modifier for vuart_gfn" Bhupinder Thakur
2017-10-31 6:55 ` [PATCH 2/4 v3] libxl: Change the type of console_mfn to xen_pfn_t Bhupinder Thakur
2017-10-31 10:05 ` Wei Liu
2017-10-31 6:55 ` [PATCH 3/4 v3] xenconsole: Change the type of ring_ref to xen_pfn_t in console_create_ring Bhupinder Thakur
2017-10-31 6:55 ` [PATCH 4/4 v3] xenconsole: Define and use a macro XEN_INVALID_PFN instead of -1 Bhupinder Thakur
2017-10-31 10:06 ` Wei Liu
2017-10-31 10:07 ` [PATCH 1/4 v3 for-4.10] libxl: Fix the bug introduced in commit "libxl: use correct type modifier for vuart_gfn" Wei Liu
2017-11-13 15:56 ` Julien Grall
2017-11-14 10:05 ` Wei Liu
2017-11-14 11:42 ` Bhupinder Thakur
2017-11-14 13:56 ` Wei Liu
2018-01-24 12:34 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124123454.eyggelo46kqwz6v2@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=bhupinder.thakur@linaro.org \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=julien.grall@linaro.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).