From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Jan Beulich <jbeulich@suse.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 5/5] x86: remove usage of .skip with non-absolute expressions
Date: Mon, 29 Jan 2018 12:53:14 +0000 [thread overview]
Message-ID: <20180129125314.f2mgrrlceemsbhso@MacBook-Pro-de-Roger.local> (raw)
In-Reply-To: <20180129124310.whaq7z37t7kvlsxg@citrix.com>
On Mon, Jan 29, 2018 at 12:43:10PM +0000, Wei Liu wrote:
> On Mon, Jan 29, 2018 at 12:26:43PM +0000, Roger Pau Monne wrote:
> > Clang assembler doesn't support using .skip with non-absolute
> > expressions:
> >
>
> But so is GNU as. From its manual for .skip:
>
> "This directive emits size bytes, each of value fill. Both size and fill
> are absolute expressions."
I guess clang and as have different interpretations of what's an
absolute expression. Sadly I don't seem to be able to find neither
definitions.
I've already reported this to upstream clang long time ago, but
it doesn't seem to make any progress:
https://bugs.llvm.org/show_bug.cgi?id=27369
And I don't think I can hack this myself.
> > entry.S:109:15: error: expected absolute expression
> > .skip .Lcr4_alt_end - .Lcr4_alt, 0x90
> > ^
> >
>
> OOI what makes .Lcr4_alt_end - .Lcr4_alt non-absolute?
Clang doesn't consider symbols as absolute expressions, at least in the
context of .skip.
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-01-29 12:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 12:26 [PATCH v3 0/5] clang fixes Roger Pau Monne
2018-01-29 12:26 ` [PATCH v3 1/5] build: filter out command line assembler arguments Roger Pau Monne
2018-01-29 14:12 ` Ian Jackson
2018-01-29 12:26 ` [PATCH v3 2/5] x86/clang: fix build with indirect thunks Roger Pau Monne
2018-01-29 16:42 ` Jan Beulich
2018-01-29 12:26 ` [PATCH v3 3/5] x86: fix indirect thunk usage of CONFIG_INDIRECT_THUNK Roger Pau Monne
2018-01-29 16:45 ` Jan Beulich
2018-01-29 17:00 ` Roger Pau Monné
2018-01-29 12:26 ` [PATCH v3 4/5] x86: move declaration of the exception_table to C Roger Pau Monne
2018-01-29 16:46 ` Jan Beulich
2018-01-29 12:26 ` [PATCH v3 5/5] x86: remove usage of .skip with non-absolute expressions Roger Pau Monne
2018-01-29 12:43 ` Wei Liu
2018-01-29 12:53 ` Roger Pau Monné [this message]
2018-01-29 13:02 ` Jan Beulich
2018-01-29 13:05 ` Andrew Cooper
2018-01-29 13:39 ` Jan Beulich
2018-01-29 16:50 ` Jan Beulich
2018-01-29 18:22 ` Andrew Cooper
2018-01-30 9:23 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180129125314.f2mgrrlceemsbhso@MacBook-Pro-de-Roger.local \
--to=roger.pau@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).