From: Michael Glasgow <glasgow@beer.net>
To: "Roger Pau [Monn_]" <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: firmware/shim: fix build process to use POSIX find options
Date: Tue, 30 Jan 2018 12:57:28 -0600 (CST) [thread overview]
Message-ID: <201801301857.w0UIvSXT062690@dark.beer.net> (raw)
In-Reply-To: <20180129113709.afgogfzp3pszcav3@MacBook-Pro-de-Roger.local> from "Roger Pau [Monn_]" at "Jan 29, 2018 11:37:31 am"
Roger Pau [Monn_] wrote:
> On Fri, Jan 26, 2018 at 01:54:30PM -0600, Michael Glasgow wrote:
> > This recent patch can be simplified a bit. (The patch below is
> > untested, just a suggestion.)
>
> Thanks, this LGTM, but it needs your Signed-off-by tag in order to be
> applied.
Simplify posix-friendly changes a bit.
Signed-off-by: Michael Glasgow <glasgow@beer.net>
---
diff -ur a/tools/firmware/xen-dir/Makefile b/tools/firmware/xen-dir/Makefile
--- a/tools/firmware/xen-dir/Makefile 2018-01-26 11:40:00.711389605 -0600
+++ b/tools/firmware/xen-dir/Makefile 2018-01-26 11:51:41.279825142 -0600
@@ -20,9 +20,8 @@
rm -f linkfarm.stamp.tmp
$(foreach d, $(LINK_DIRS), \
(mkdir -p $(D)/$(d); \
- cd $(D)/$(d); \
- find $(XEN_ROOT)/$(d)/ -type d -exec sh -c \
- "echo {} | sed 's,^$(XEN_ROOT)/$(d)/,,g' | xargs mkdir -p"
\;);)
+ cd $(D)/$(d) && \
+ (cd $(XEN_ROOT)/$(d) && find . -type d) | xargs mkdir -p \;);)
$(foreach d, $(LINK_DIRS), \
(cd $(XEN_ROOT); \
find $(d) ! -type l -type f \
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-01-30 18:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 19:54 firmware/shim: fix build process to use POSIX find options Michael Glasgow
2018-01-29 11:37 ` Roger Pau Monné
2018-01-30 18:57 ` Michael Glasgow [this message]
2018-02-01 10:13 ` Roger Pau Monné
2018-02-01 10:25 ` Jan Beulich
2018-02-01 10:29 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201801301857.w0UIvSXT062690@dark.beer.net \
--to=glasgow@beer.net \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).