From: Brian Woods <brian.woods@amd.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Brian Woods <brian.woods@amd.com>,
Jan Beulich <jbeulich@suse.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH 2/3] x86/svm: add EFER SVME support for VGIF/VLOAD
Date: Mon, 5 Feb 2018 10:39:17 -0600 [thread overview]
Message-ID: <20180205163916.GA8527@amd.com> (raw)
In-Reply-To: <59c966b0-4e3e-579a-910c-caa974f84b57@citrix.com>
On Mon, Feb 05, 2018 at 03:37:06PM +0000, Andrew Cooper wrote:
> Indenting is off, but that can be fixed on commit.
Oopsy, sorry about that.
> As some extra cleanup, what about folding this diff in? It avoids
> repeatedly hitting the cleanbits, and is clearer to follow IMO.
>
> ~Andrew
>
It's functionally the same. It's a trade off of whether you want to
write/read to the VMCB twice (assuming both are changing) or go through
more if statements every time. The clean bits are just a field in the
VMCB so. Some of the VMCB fields are only read on change with my
version but to be honest, I don't think it matters either way. I like
the locality of mine better, but I'm perfectly fine with either.
--
Brian Woods
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-02-05 16:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 20:35 [PATCH 0/3] Various SVM Cleanups Brian Woods
2018-01-31 20:35 ` [PATCH 1/3] x86/svm: update VGIF support Brian Woods
2018-02-03 16:51 ` Boris Ostrovsky
2018-01-31 20:35 ` [PATCH 2/3] x86/svm: add EFER SVME support for VGIF/VLOAD Brian Woods
2018-02-03 16:55 ` Boris Ostrovsky
2018-02-05 9:09 ` Jan Beulich
2018-02-05 16:47 ` Brian Woods
2018-02-05 17:02 ` Jan Beulich
2018-02-05 15:37 ` Andrew Cooper
2018-02-05 16:39 ` Brian Woods [this message]
2018-02-07 21:06 ` [PATCH v2 " Brian Woods
2018-02-07 21:15 ` Brian Woods
[not found] ` <5A7B6A7C0200003403432E6E@prv-mh.provo.novell.com>
2018-02-08 9:45 ` Jan Beulich
2018-02-08 16:23 ` Brian Woods
[not found] ` <5A7C82880200003F043E54B7@prv-mh.provo.novell.com>
2018-02-13 9:31 ` [PATCH v3 " Jan Beulich
2018-02-13 18:37 ` Woods, Brian
2018-02-14 8:01 ` Jan Beulich
2018-02-08 17:01 ` Brian Woods
2018-02-20 22:27 ` [PATCH v4 " Brian Woods
2018-02-20 22:52 ` Boris Ostrovsky
2018-02-20 22:00 ` [PATCH v2 " Brian Woods
2018-02-20 22:09 ` Boris Ostrovsky
2018-02-20 22:14 ` Brian Woods
2018-01-31 20:35 ` [PATCH 3/3] x86/svm: correct EFER.SVME intercept checks Brian Woods
2018-02-03 17:03 ` Boris Ostrovsky
2018-02-03 17:10 ` Andrew Cooper
2018-02-03 17:15 ` Boris Ostrovsky
2018-02-05 9:18 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180205163916.GA8527@amd.com \
--to=brian.woods@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).