From: Wei Liu <wei.liu2@citrix.com>
To: Oleksandr Grytsov <al1img@gmail.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Oleksandr Grytsov <oleksandr_grytsov@epam.com>
Subject: Re: [PATCH v1 3/6] libxl: add backend type and id to vkb
Date: Tue, 6 Feb 2018 16:54:10 +0000 [thread overview]
Message-ID: <20180206165410.4t3fbdzdpdhebg5y@citrix.com> (raw)
In-Reply-To: <CACvf2oXxVy4LT7CCy7tv+PSTDALwESFNVsthGO_NkDqtHRecaA@mail.gmail.com>
On Tue, Feb 06, 2018 at 06:45:15PM +0200, Oleksandr Grytsov wrote:
> > > +static int libxl__set_xenstore_vkb(libxl__gc *gc, uint32_t domid,
> > > + libxl_device_vkb *vkb,
> > > + flexarray_t *back, flexarray_t
> > *front,
> > > + flexarray_t *ro_front)
> > > +{
> > > + if (vkb->id) {
> > > + flexarray_append_pair(front, "id", vkb->id);
> > > + }
> > > +
> >
> > Ditto.
> >
> > And, isn't 0 a valid device id?
> >
> >
> id here is char *. I put it to xenstore only if it is defined. It shall be
> defined for linux backend
> in case of multiple instances of kbd device are defined. The backend
> distinguishes them
> by id.
Oh I was a fool -- I misread that as dev_id which had numeric value.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-02-06 16:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 15:05 [PATCH v1 0/6] libxl: create standalone vkb device Oleksandr Grytsov
2017-11-01 15:05 ` [PATCH v1 1/6] libxl: move vkb device to libxl_vkb.c Oleksandr Grytsov
2017-11-01 15:05 ` [PATCH v1 2/6] libxl: fix vkb XS entry and type Oleksandr Grytsov
2017-11-01 15:05 ` [PATCH v1 3/6] libxl: add backend type and id to vkb Oleksandr Grytsov
2018-02-06 14:25 ` Wei Liu
2018-02-06 16:45 ` Oleksandr Grytsov
2018-02-06 16:54 ` Wei Liu [this message]
2017-11-01 15:05 ` [PATCH v1 4/6] libxl: vkb add list and info functions Oleksandr Grytsov
2018-02-06 14:26 ` Wei Liu
2018-02-06 14:27 ` Wei Liu
2017-11-01 15:05 ` [PATCH v1 5/6] xl: add vkb config parser and CLI Oleksandr Grytsov
2018-02-06 14:27 ` Wei Liu
2017-11-01 15:05 ` [PATCH v1 6/6] docs: add vkb device to xl.cfg and xl Oleksandr Grytsov
2018-02-06 14:28 ` Wei Liu
2017-11-14 12:39 ` [PATCH v1 0/6] libxl: create standalone vkb device Oleksandr Grytsov
2017-11-20 13:44 ` Oleksandr Grytsov
2018-01-09 11:31 ` Oleksandr Grytsov
2018-02-05 11:03 ` Oleksandr Grytsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206165410.4t3fbdzdpdhebg5y@citrix.com \
--to=wei.liu2@citrix.com \
--cc=al1img@gmail.com \
--cc=ian.jackson@eu.citrix.com \
--cc=oleksandr_grytsov@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).