From: Simon Gaiser <simon@invisiblethingslab.com>
To: xen-devel@lists.xenproject.org
Cc: "Simon Gaiser" <simon@invisiblethingslab.com>,
"Wei Liu" <wei.liu2@citrix.com>,
"Ian Jackson" <ian.jackson@eu.citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH 2/3] libxl: Improve logging in libxl__build_dom()
Date: Thu, 8 Feb 2018 22:49:09 +0100 [thread overview]
Message-ID: <20180208214910.10699-3-simon@invisiblethingslab.com> (raw)
In-Reply-To: <20180208214910.10699-1-simon@invisiblethingslab.com>
xc_dom_parse_image() does not set errno (at least in many code paths).
So LOGE() is not useful.
Signed-off-by: Simon Gaiser <simon@invisiblethingslab.com>
---
tools/libxl/libxl_dom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
index ef834e652d..52b6137943 100644
--- a/tools/libxl/libxl_dom.c
+++ b/tools/libxl/libxl_dom.c
@@ -715,7 +715,7 @@ static int libxl__build_dom(libxl__gc *gc, uint32_t domid,
}
#endif
if ( (ret = xc_dom_parse_image(dom)) != 0 ) {
- LOGE(ERROR, "xc_dom_parse_image failed");
+ LOG(ERROR, "xc_dom_parse_image failed");
goto out;
}
if ( (ret = libxl__arch_domain_init_hw_description(gc, info, state, dom)) != 0 ) {
--
2.15.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-02-08 21:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 21:49 libx[lc]: Improve error reporting for invalid kernel images Simon Gaiser
2018-02-08 21:49 ` [PATCH 1/3] libxc: Cleanup xc_dom_parse_elf_kernel()'s return value Simon Gaiser
2018-02-09 12:00 ` Roger Pau Monné
2018-02-08 21:49 ` Simon Gaiser [this message]
2018-02-09 12:08 ` [PATCH 2/3] libxl: Improve logging in libxl__build_dom() Roger Pau Monné
2018-02-08 21:49 ` [PATCH 3/3] libxc: xc_dom_parse_elf_kernel: Return error for invalid kernel images Simon Gaiser
2018-02-09 12:19 ` Roger Pau Monné
2018-02-12 14:51 ` libx[lc]: Improve error reporting " Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180208214910.10699-3-simon@invisiblethingslab.com \
--to=simon@invisiblethingslab.com \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).