PVH Dom0 ACPI tables

PVH Dom0 ACPI tables

[Roger Pau Monné]

Hello,

After the comments on the ACPI whitelisting patch for PVH Dom0 I've
decided to post the list of ACPI tables that I've used to create the
current whitelist, together with other tables that I've not yet added.

Allowed tables

DSDT*, FACP*, FACS*, PSDT*, SSDT*, SBST*, ASF, MCFG*, SLIC*, MSDM*,
UEFI, WDAT*, BGRT, FPDT*, S3PT*, IBFT.

* Already whitelisted.

Tables that might need mappings

BERT, MCHI, SPCR, SPMI, TCPA, WDDT, WDRT, PCCT, WPBT

Tables that could point to devices being used by Xen

DBG2, DBGP

Tables related to devices in use by Xen (or not available to Dom0)

HPET, DMAR, IVRS, WAET, CSRT, BOOT, MADT,

System topology related

SLIT, SRAT, MPST, PMTT, RASF*

* Not sure allowing Dom0 to activate 'patrol scrub' is safe.

ARM only

IORT, GTDT, STAO

Missing documentation

DRTM

This is based on the table signatures currently know to Xen (from the
actblX.h headers). I guess there are more that I'm missing.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: PVH Dom0 ACPI tables

[Jan Beulich]

>>> On 14.02.18 at 11:30, <roger.pau@citrix.com> wrote:
> Hello,
> 
> After the comments on the ACPI whitelisting patch for PVH Dom0 I've
> decided to post the list of ACPI tables that I've used to create the
> current whitelist, together with other tables that I've not yet added.
> 
> Allowed tables
> 
> DSDT*, FACP*, FACS*, PSDT*, SSDT*, SBST*, ASF, MCFG*, SLIC*, MSDM*,
> UEFI, WDAT*, BGRT, FPDT*, S3PT*, IBFT.
> 
> * Already whitelisted.
> 
> Tables that might need mappings
> 
> BERT, MCHI, SPCR, SPMI, TCPA, WDDT, WDRT, PCCT, WPBT

You have BERT here, but none of ERST, EINJ, or HEST above.
Albeit ERST and HEST are in use by Xen, so may need to go on
the list further down instead.

> Tables that could point to devices being used by Xen
> 
> DBG2, DBGP
> 
> Tables related to devices in use by Xen (or not available to Dom0)
> 
> HPET, DMAR, IVRS, WAET, CSRT, BOOT, MADT,

Why WAET, CSRT, and BOOT? I can't find Xen using any of these.

> System topology related
> 
> SLIT, SRAT, MPST, PMTT, RASF*
> 
> * Not sure allowing Dom0 to activate 'patrol scrub' is safe.
> 
> ARM only
> 
> IORT, GTDT, STAO

I didn't think STAO is ARM-specific.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: PVH Dom0 ACPI tables

[Roger Pau Monné]

On Thu, Feb 15, 2018 at 03:05:03AM -0700, Jan Beulich wrote:
> >>> On 14.02.18 at 11:30, <roger.pau@citrix.com> wrote:
> > Hello,
> > 
> > After the comments on the ACPI whitelisting patch for PVH Dom0 I've
> > decided to post the list of ACPI tables that I've used to create the
> > current whitelist, together with other tables that I've not yet added.
> > 
> > Allowed tables
> > 
> > DSDT*, FACP*, FACS*, PSDT*, SSDT*, SBST*, ASF, MCFG*, SLIC*, MSDM*,
> > UEFI, WDAT*, BGRT, FPDT*, S3PT*, IBFT.
> > 
> > * Already whitelisted.
> > 
> > Tables that might need mappings
> > 
> > BERT, MCHI, SPCR, SPMI, TCPA, WDDT, WDRT, PCCT, WPBT
> 
> You have BERT here, but none of ERST, EINJ, or HEST above.
> Albeit ERST and HEST are in use by Xen, so may need to go on
> the list further down instead.

Hm, right I've missed those. So ERST and HEST are in used by Xen and
should go below (or to a new category, since it's not a device but a
table itself that's being used by Xen).

EINJ doesn't look safe to pass through to Dom0, since Injection
actions contain Register Regions that could contain Dom0 GFNs.

> > Tables that could point to devices being used by Xen
> > 
> > DBG2, DBGP
> > 
> > Tables related to devices in use by Xen (or not available to Dom0)
> > 
> > HPET, DMAR, IVRS, WAET, CSRT, BOOT, MADT,
> 
> Why WAET, CSRT, and BOOT? I can't find Xen using any of these.

WAET contains information about devices not available to Dom0 (RTC and
ACPI PM timer).

CSRT is more of a grey area, it contains information about interrupt
controllers and timers, and those devices are likely not available to
Dom0.

BOOT contains an offset into the CMOS, which is not available to Dom0.

> 
> > System topology related
> > 
> > SLIT, SRAT, MPST, PMTT, RASF*
> > 
> > * Not sure allowing Dom0 to activate 'patrol scrub' is safe.
> > 
> > ARM only
> > 
> > IORT, GTDT, STAO
> 
> I didn't think STAO is ARM-specific.

Right, it also shouldn't be present when booting on bare metal.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: PVH Dom0 ACPI tables

[Jan Beulich]

>>> On 15.02.18 at 17:59, <roger.pau@citrix.com> wrote:
> On Thu, Feb 15, 2018 at 03:05:03AM -0700, Jan Beulich wrote:
>> >>> On 14.02.18 at 11:30, <roger.pau@citrix.com> wrote:
>> > Tables related to devices in use by Xen (or not available to Dom0)
>> > 
>> > HPET, DMAR, IVRS, WAET, CSRT, BOOT, MADT,
>> 
>> Why WAET, CSRT, and BOOT? I can't find Xen using any of these.
> 
> WAET contains information about devices not available to Dom0 (RTC and
> ACPI PM timer).
> 
> CSRT is more of a grey area, it contains information about interrupt
> controllers and timers, and those devices are likely not available to
> Dom0.
> 
> BOOT contains an offset into the CMOS, which is not available to Dom0.

CMOS and RTC are usable by Dom0, aren't they?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: PVH Dom0 ACPI tables

[Roger Pau Monné]

On Thu, Feb 15, 2018 at 10:23:32AM -0700, Jan Beulich wrote:
> >>> On 15.02.18 at 17:59, <roger.pau@citrix.com> wrote:
> > On Thu, Feb 15, 2018 at 03:05:03AM -0700, Jan Beulich wrote:
> >> >>> On 14.02.18 at 11:30, <roger.pau@citrix.com> wrote:
> >> > Tables related to devices in use by Xen (or not available to Dom0)
> >> > 
> >> > HPET, DMAR, IVRS, WAET, CSRT, BOOT, MADT,
> >> 
> >> Why WAET, CSRT, and BOOT? I can't find Xen using any of these.
> > 
> > WAET contains information about devices not available to Dom0 (RTC and
> > ACPI PM timer).
> > 
> > CSRT is more of a grey area, it contains information about interrupt
> > controllers and timers, and those devices are likely not available to
> > Dom0.
> > 
> > BOOT contains an offset into the CMOS, which is not available to Dom0.
> 
> CMOS and RTC are usable by Dom0, aren't they?

Sure, I was confused with DomU which of course doesn't have RTC/CMOS.
Dom0 should be able to access the RTC/CMOS from the IO space.

BOOT should be fine to pass through to Dom0.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel