xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] grant: Release domain lock on 'map' path in cache_flush
@ 2018-02-22 17:08 George Dunlap
  0 siblings, 0 replies; only message in thread
From: George Dunlap @ 2018-02-22 17:08 UTC (permalink / raw)
  To: xen-devel
  Cc: Stefano Stabellini, Wei Liu, Andrew Cooper, Tim Deegan,
	George Dunlap, Jan Beulich, Ian Jackson

common/grant_table.c:cache_flush() grabs the rcu lock for the current
domain, but only releases it on error paths.

Note that this is not a security issue, as the preempt count is used
exclusively for assertions at the moment.

Signed-off-by: George Dunlap <george.dunlap@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
CC: Ian Jackson <ian.jackson@citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Tim Deegan <tim@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Konrad Wilk <konrad.wilk@oracle.com>
---
 xen/common/grant_table.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index 48c547930c..8346994de6 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -3273,6 +3273,7 @@ static int cache_flush(const gnttab_cache_flush_t *cflush, grant_ref_t *cur_ref)
 
     unmap_domain_page(v);
     put_page(page);
+    rcu_unlock_domain(d);
 
     return ret;
 }
-- 
2.15.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2018-02-22 17:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-22 17:08 [PATCH] grant: Release domain lock on 'map' path in cache_flush George Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).