* [PATCH][next] xen-netback: make function xenvif_rx_skb static
@ 2018-02-23 17:16 Colin King
2018-02-23 17:32 ` Wei Liu
2018-02-26 16:37 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2018-02-23 17:16 UTC (permalink / raw)
To: Wei Liu, Paul Durrant, xen-devel, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function xenvif_rx_skb is local to the source and does not need
to be in global scope, so make it static.
Cleans up sparse warning:
drivers/net/xen-netback/rx.c:422:6: warning: symbol 'xenvif_rx_skb'
was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/xen-netback/rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/xen-netback/rx.c b/drivers/net/xen-netback/rx.c
index b1cf7c6f407a..ef5887037b22 100644
--- a/drivers/net/xen-netback/rx.c
+++ b/drivers/net/xen-netback/rx.c
@@ -419,7 +419,7 @@ static void xenvif_rx_extra_slot(struct xenvif_queue *queue,
BUG();
}
-void xenvif_rx_skb(struct xenvif_queue *queue)
+static void xenvif_rx_skb(struct xenvif_queue *queue)
{
struct xenvif_pkt_state pkt;
--
2.15.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] xen-netback: make function xenvif_rx_skb static
2018-02-23 17:16 [PATCH][next] xen-netback: make function xenvif_rx_skb static Colin King
@ 2018-02-23 17:32 ` Wei Liu
2018-02-26 16:37 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Wei Liu @ 2018-02-23 17:32 UTC (permalink / raw)
To: Colin King
Cc: Wei Liu, netdev, kernel-janitors, linux-kernel, Paul Durrant,
xen-devel
On Fri, Feb 23, 2018 at 05:16:57PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function xenvif_rx_skb is local to the source and does not need
> to be in global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/net/xen-netback/rx.c:422:6: warning: symbol 'xenvif_rx_skb'
> was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Thanks
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] xen-netback: make function xenvif_rx_skb static
2018-02-23 17:16 [PATCH][next] xen-netback: make function xenvif_rx_skb static Colin King
2018-02-23 17:32 ` Wei Liu
@ 2018-02-26 16:37 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-02-26 16:37 UTC (permalink / raw)
To: colin.king
Cc: wei.liu2, netdev, kernel-janitors, linux-kernel, paul.durrant,
xen-devel
From: Colin King <colin.king@canonical.com>
Date: Fri, 23 Feb 2018 17:16:57 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> The function xenvif_rx_skb is local to the source and does not need
> to be in global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/net/xen-netback/rx.c:422:6: warning: symbol 'xenvif_rx_skb'
> was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-26 16:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-23 17:16 [PATCH][next] xen-netback: make function xenvif_rx_skb static Colin King
2018-02-23 17:32 ` Wei Liu
2018-02-26 16:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).